Skip to contentSkip to conversation

vfs: Check attribute names in posix acl xattr handers

PATCH New Andreas Gruenbacher 1 participant 1 message Oct 8, 2015 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vfs: Check attribute names in posix acl xattr handers

The get and set operations of the posix acl xattr handlers failed to check the attribute names, so all names with "system.posix_acl_access" or "system.posix_acl_default" as a prefix were accepted. Reject invalid names from now on.

---
 fs/posix_acl.c | 4 ++++
 1 file changed, 4 insertions(+)
fs/posix_acl.c +4 -0
index 4fb17de..b1a66e8 100644
@@ -768,6 +768,8 @@ posix_acl_xattr_get(struct dentry *dentry, const char *name,
 	struct posix_acl *acl;
 	int error;
 
+	if (strcmp(name, "") != 0)
+		return -EINVAL;
 	if (!IS_POSIXACL(d_backing_inode(dentry)))
 		return -EOPNOTSUPP;
 	if (d_is_symlink(dentry))
@@ -793,6 +795,8 @@ posix_acl_xattr_set(struct dentry *dentry, const char *name,
 	struct posix_acl *acl = NULL;
 	int ret;
 
+	if (strcmp(name, "") != 0)
+		return -EINVAL;
 	if (!IS_POSIXACL(inode))
 		return -EOPNOTSUPP;
 	if (!inode->i_op->set_acl)
Signature · 1 line
2.5.0