Fix missing function declarations when building tests
Subsystems (2)
PATCH 1/2 Fix missing function declarations when building tests
Fix these compiler warnings by declaring test_exit() and test_main() regardless of whether TEST_NO_WRAPPERS is defined:
test-cmdline.c: In function ‘send_ioctl’:
test-cmdline.c:268:2: warning: implicit declaration of function ‘test_exit’ [-Wimplicit-function-declaration]
test_exit(0);
^test-common.c: In function ‘test_cmdline’:
test-common.c:361:21: warning: implicit declaration of function ‘test_main’ [-Wimplicit-function-declaration]
rc = rc ? rc - 1 : test_main(argc, argv);
^Signed-off-by Ben Hutchings <[email protected]>
---
These warnings are longstanding so I'm not sure why I didn't notice them before! I've applied this post-4.2.
Ben.
internal.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
internal.h +3 -2
@@ -132,10 +132,11 @@ struct cmd_expect {int test_ioctl (const struct cmd_expect *expect,void *cmd);#define TEST_IOCTL_MISMATCH (-2) -#ifndef TEST_NO_WRAPPERS int test_main (int argc,char **argp); -#define main (...) test_main(__VA_ARGS__)void test_exit (int rc) __attribute__((noreturn)); + +#ifndef TEST_NO_WRAPPERS +#define main (...) test_main(__VA_ARGS__)#undef exit#define exit (rc) test_exit(rc)void *test_malloc (size_t size);
Signature · 2 lines
Ben Hutchings If the facts do not conform to your theory, they must be disposed of.