Skip to contentSkip to conversation

x86/io_apic: Make eoi_ioapic_pin() static

PATCH New Andy Shevchenko 2 participants 2 messages Oct 9, 2015 – Oct 11, 2015 x86

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/io_apic: Make eoi_ioapic_pin() static

We have to define internally used function as static, otherwise the following warning will be generated:

arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for ‘eoi_ioapic_pin’ [-Wmissing-prototypes]

---
v2:
- amend commit message
- add tag

 arch/x86/kernel/apic/io_apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/apic/io_apic.c +1 -1
index 5c60bb1..b5a0e3c 100644
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
 	}
 }
 
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
 {
 	unsigned long flags;
 	struct irq_pin_list *entry;
Signature · 1 line
2.5.3
#1 lore raw
x86/io_apic: Make eoi_ioapic_pin() static
Commit-ID:  4faefda97bc1be6ca909ba0fd0927ea78f37f67e
Gitweb:     http://git.kernel.org/tip/4faefda97bc1be6ca909ba0fd0927ea78f37f67e
Author:     Andy Shevchenko <[email protected]>
AuthorDate: Fri, 9 Oct 2015 17:24:45 +0300
Committer:  Thomas Gleixner <[email protected]>
CommitDate: Sun, 11 Oct 2015 21:10:31 +0200

x86/io_apic: Make eoi_ioapic_pin() static

We have to define internally used function as static, otherwise the following warning will be generated:

arch/x86/kernel/apic/io_apic.c:532:6: warning: no previous prototype for 'eoi_ioapic_pin' [-Wmissing-prototypes]

---
 arch/x86/kernel/apic/io_apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/apic/io_apic.c +1 -1
index 5c60bb1..b5a0e3c 100644
@@ -529,7 +529,7 @@ static void __eoi_ioapic_pin(int apic, int pin, int vector)
 	}
 }
 
-void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
+static void eoi_ioapic_pin(int vector, struct mp_chip_data *data)
 {
 	unsigned long flags;
 	struct irq_pin_list *entry;