Reorganize how max DP vswing and pre-emph values are stored
Subsystems (2)
cover Reorganize how max DP vswing and pre-emph values are stored
(I'm resending this due to a typo on intel-gfx@ mailing list address, sorry for duplications.)
Hi,
This patch series reorganizes how the limits for DP voltage swing and pre emphasis are stored. It moves that information into a struct that holds the data for a given platform or a set of platforms. The if ladder to chose the right value is then restrict to one function that sets up a pointer in intel_dp.
I smoke-tested this in a haswell laptop. To verify that the values are unchanged, I also wrote a small program that exercises the code and prints the values for different platforms. I then ran it with the old and new code and verified that there are no differences. The code for that program is in the link below:
https://github.com/anderco/linux/commit/36268e777effefb3e906b35e2052d5488271b3ff
This patch series applies on top of the link training series I sent earlier this week.
Thanks,
Ander
Ander Conselvan de Oliveira (9):
drm/i915: Merge intel_dp_update_signal_levels() with
set_signal_levels()
drm/i915: Split setting of vswing and pre_emph levels to separate file drm/i915: Introduce struct intel_dp_signal_levels drm/i915: Use struct intel_dp_signal_levels for eDP on SNB and IVB drm/i915: Use struct intel_dp_signal_levels for VLV drm/i915: Use struct intel_dp_signal_levels for CHV drm/i915: Use struct intel_dp_signal_levels for DDI platforms drm/i915: Remove old functions for maximum DP vswing and pre-emph
levels
drm/i915: Move ddi_signal_levels() to intel_dp_signal_levels.c
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/intel_ddi.c | 78 +-- drivers/gpu/drm/i915/intel_dp.c | 534 +------------------- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 694 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_drv.h | 24 +- 5 files changed, 724 insertions(+), 607 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_dp_signal_levels.c
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/9 drm/i915: Merge intel_dp_update_signal_levels() with set_signal_levels()
Merge intel_dp_update_signal_levels() and intel_dp_set_signal_levels(), since the former is the only user of the latter and doing so allow us to not pass a pointer to intel_dp->DP around.
--- drivers/gpu/drm/i915/intel_dp.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +8 -17
@@ -3526,13 +3526,13 @@ gen7_edp_signal_levels(uint8_t train_set) } } -/* Properly updates "DP" with the correct signal levels. */ -static void -intel_dp_set_signal_levels (struct intel_dp *intel_dp,uint32_t *DP ) +void +intel_dp_update_signal_levels (struct intel_dp *intel_dp) {struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);enum port port = intel_dig_port->port;struct drm_device *dev = intel_dig_port->base.base.dev; +struct drm_i915_private *dev_priv =to_i915 (dev);uint32_t signal_levels, mask =0 ;uint8_t train_set = intel_dp->train_set[0 ];
@@ -3567,31 +3567,22 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, uint32_t *DP) (train_set &DP_TRAIN_PRE_EMPHASIS_MASK ) >> DP_TRAIN_PRE_EMPHASIS_SHIFT); - *DP = (*DP & ~mask) | signal_levels; -} - -void -intel_dp_program_link_training_pattern (struct intel_dp *intel_dp, -uint8_t dp_train_pat) -{ -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -struct drm_i915_private *dev_priv = -to_i915 (intel_dig_port->base.base.dev); - -_intel_dp_set_link_train (intel_dp, &intel_dp->DP, dp_train_pat); + intel_dp->DP &= ~mask; + intel_dp->DP |= signal_levels;I915_WRITE (intel_dp->output_reg, intel_dp->DP);POSTING_READ (intel_dp->output_reg); }void -intel_dp_update_signal_levels (struct intel_dp *intel_dp) +intel_dp_program_link_training_pattern (struct intel_dp *intel_dp, +uint8_t dp_train_pat) {struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);struct drm_i915_private *dev_priv =to_i915 (intel_dig_port->base.base.dev); -intel_dp_set_signal_levels (intel_dp, &intel_dp->DP); +_intel_dp_set_link_train (intel_dp, &intel_dp->DP, dp_train_pat);I915_WRITE (intel_dp->output_reg, intel_dp->DP);POSTING_READ (intel_dp->output_reg);
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/9 drm/i915: Split setting of vswing and pre_emph levels to separate file
In reply to Ander Conselvan de OliveiraNo functional changes, just moving code around.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/intel_dp.c | 523 ------------------------- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 542 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_drv.h | 7 + 4 files changed, 550 insertions(+), 523 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_dp_signal_levels.c
drivers/gpu/drm/i915/Makefile +1 -0
@@ -79,6 +79,7 @@ i915-y += dvo_ch7017.o \ intel_ddi.o \ intel_dp_link_training.o \ intel_dp_mst.o \ + intel_dp_signal_levels.o \ intel_dp.o \ intel_dsi.o \ intel_dsi_panel_vbt.o \
drivers/gpu/drm/i915/intel_dp.c +0 -523
535 lines not on this page · raw message
drivers/gpu/drm/i915/intel_dp_signal_levels.c new file +542 -0
542 lines not on this page · raw message
drivers/gpu/drm/i915/intel_drv.h +7 -0
@@ -936,6 +936,13 @@ dp_to_dig_port(struct intel_dp *intel_dp) return container_of(intel_dp, struct intel_digital_port, dp); } +static inline struct drm_device *intel_dp_to_dev (struct intel_dp *intel_dp) +{ +struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); + +return intel_dig_port->base.base.dev; +} +static inline struct intel_digital_port *hdmi_to_dig_port (struct intel_hdmi *intel_hdmi) {
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/9 drm/i915: Introduce struct intel_dp_signal_levels
In reply to Ander Conselvan de OliveiraIn order to clarify which platforms support which combination of voltage swing and pre emphasis level, introduce struct intel_dp_signal_levels. With the new struct, the if ladder to determine the values used is put in one place, intel_dp_init_signal_levels().
This also wires gens 4, 5 and non-eDP ports on gen 6 and 7 to use the new struct.
--- drivers/gpu/drm/i915/intel_dp.c | 2 + drivers/gpu/drm/i915/intel_dp_signal_levels.c | 103 ++++++++++++++++++++++---- drivers/gpu/drm/i915/intel_drv.h | 11 +++ 3 files changed, 100 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +2 -0
@@ -5220,6 +5220,8 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,if (HAS_DDI (dev)) intel_dp->prepare_link_retrain = intel_ddi_prepare_link_retrain; +intel_dp_init_signal_levels (intel_dp); +/* Preserve the current hw state. */ intel_dp->DP =I915_READ (intel_dp->output_reg); intel_dp->attached_connector = intel_connector;
drivers/gpu/drm/i915/intel_dp_signal_levels.c +87 -16
159 lines not on this page · raw message
drivers/gpu/drm/i915/intel_drv.h +11 -0
@@ -740,6 +740,14 @@ struct sink_crc {int last_count; }; +struct intel_dp ; +struct signal_levels { +uint8_t max_voltage; +uint8_t max_pre_emph[4 ]; + +void (*set)(struct intel_dp *intel_dp,uint8_t train_set); +}; +struct intel_dp {uint32_t output_reg;uint32_t aux_ch_ctl_reg;
@@ -758,6 +766,7 @@ struct intel_dp {int sink_rates[DP_MAX_SUPPORTED_RATES ];struct sink_crc sink_crc;struct drm_dp_aux aux; +const struct signal_levels *signal_levels;uint8_t train_set[4 ];int panel_power_up_delay;int panel_power_down_delay;
@@ -1274,6 +1283,8 @@ bool intel_dp_source_supports_hbr2(struct intel_dp *intel_dp);bool intel_dp_get_link_status (struct intel_dp *intel_dp,uint8_t link_status[DP_LINK_STATUS_SIZE ]); +void intel_dp_init_signal_levels (struct intel_dp *intel_dp); +/* intel_dp_mst.c */ int intel_dp_mst_encoder_init (struct intel_digital_port *intel_dig_port,int conn_id);void intel_dp_mst_encoder_cleanup (struct intel_digital_port *intel_dig_port);
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/9 drm/i915: Use struct intel_dp_signal_levels for eDP on SNB and IVB
In reply to Ander Conselvan de OliveiraUse the new struct intel_dp_signal_levels to store voltage swing and pre emphasis levels for eDP on SNB and IVB.
--- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 132 ++++++++++++++++++-------- 1 file changed, 91 insertions(+), 41 deletions(-)
drivers/gpu/drm/i915/intel_dp_signal_levels.c +91 -41
@@ -448,7 +448,6 @@ static const struct signal_levels gen4_signal_levels = { .set = gen4_set_signal_levels, }; -/* Not for eDP */ static const struct signal_levels snb_signal_levels = { .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_3 , .max_pre_emph = {
@@ -461,73 +460,123 @@ static const struct signal_levels snb_signal_levels = { .set = gen4_set_signal_levels, }; -/* Gen6's DP voltage swing and pre-emphasis control */ -static uint32_t -gen6_edp_signal_levels (uint8_t train_set) +/* SNB's DP voltage swing and pre-emphasis control */ +static void +snb_edp_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) { -int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | -DP_TRAIN_PRE_EMPHASIS_MASK ); -switch (signal_levels) { +uint32_t signal_levels; + + train_set &= + (DP_TRAIN_VOLTAGE_SWING_MASK |DP_TRAIN_PRE_EMPHASIS_MASK ); + +switch (train_set) {case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_0 :case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_0 : -return EDP_LINK_TRAIN_400_600MV_0DB_SNB_B ; + signal_levels =EDP_LINK_TRAIN_400_600MV_0DB_SNB_B ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_1 : -return EDP_LINK_TRAIN_400MV_3_5DB_SNB_B ; + signal_levels =EDP_LINK_TRAIN_400MV_3_5DB_SNB_B ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_2 :case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_2 : -return EDP_LINK_TRAIN_400_600MV_6DB_SNB_B ; + signal_levels =EDP_LINK_TRAIN_400_600MV_6DB_SNB_B ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_1 :case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 |DP_TRAIN_PRE_EMPH_LEVEL_1 : -return EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B ; + signal_levels =EDP_LINK_TRAIN_600_800MV_3_5DB_SNB_B ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 |DP_TRAIN_PRE_EMPH_LEVEL_0 :case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 |DP_TRAIN_PRE_EMPH_LEVEL_0 : -return EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B ; + signal_levels =EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B ; +break ;default :DRM_DEBUG_KMS ("Unsupported voltage swing/pre-emphasis level:" -"0x%x\n" , signal_levels); -return EDP_LINK_TRAIN_400_600MV_0DB_SNB_B ; +"0x%x\n" , train_set); + signal_levels =EDP_LINK_TRAIN_400_600MV_0DB_SNB_B ; } + +DRM_DEBUG_KMS ("Using signal levels %08x\n" , signal_levels); + + intel_dp->DP &= ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB ; + intel_dp->DP |= signal_levels; } -/* Gen7's DP voltage swing and pre-emphasis control */ -static uint32_t -gen7_edp_signal_levels (uint8_t train_set) +static const struct signal_levels snb_edp_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_2 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = snb_edp_set_signal_levels, +}; + +/* IVB's DP voltage swing and pre-emphasis control */ +static void +ivb_edp_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) { -int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | -DP_TRAIN_PRE_EMPHASIS_MASK ); -switch (signal_levels) { +uint32_t signal_levels; + + train_set &= + (DP_TRAIN_VOLTAGE_SWING_MASK |DP_TRAIN_PRE_EMPHASIS_MASK ); + +switch (train_set) {case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_0 : -return EDP_LINK_TRAIN_400MV_0DB_IVB ; + signal_levels =EDP_LINK_TRAIN_400MV_0DB_IVB ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_1 : -return EDP_LINK_TRAIN_400MV_3_5DB_IVB ; + signal_levels =EDP_LINK_TRAIN_400MV_3_5DB_IVB ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_2 : -return EDP_LINK_TRAIN_400MV_6DB_IVB ; + signal_levels =EDP_LINK_TRAIN_400MV_6DB_IVB ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_0 : -return EDP_LINK_TRAIN_600MV_0DB_IVB ; + signal_levels =EDP_LINK_TRAIN_600MV_0DB_IVB ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_1 : -return EDP_LINK_TRAIN_600MV_3_5DB_IVB ; + signal_levels =EDP_LINK_TRAIN_600MV_3_5DB_IVB ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 |DP_TRAIN_PRE_EMPH_LEVEL_0 : -return EDP_LINK_TRAIN_800MV_0DB_IVB ; + signal_levels =EDP_LINK_TRAIN_800MV_0DB_IVB ; +break ;case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 |DP_TRAIN_PRE_EMPH_LEVEL_1 : -return EDP_LINK_TRAIN_800MV_3_5DB_IVB ; + signal_levels =EDP_LINK_TRAIN_800MV_3_5DB_IVB ; +break ;default :DRM_DEBUG_KMS ("Unsupported voltage swing/pre-emphasis level:" -"0x%x\n" , signal_levels); -return EDP_LINK_TRAIN_500MV_0DB_IVB ; +"0x%x\n" , train_set); + signal_levels =EDP_LINK_TRAIN_500MV_0DB_IVB ; } + +DRM_DEBUG_KMS ("Using signal levels %08x\n" , signal_levels); + + intel_dp->DP &= ~EDP_LINK_TRAIN_VOL_EMP_MASK_IVB ; + intel_dp->DP |= signal_levels; } +static const struct signal_levels ivb_edp_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_2 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = ivb_edp_set_signal_levels, +}; +static void _update_signal_levels (struct intel_dp *intel_dp) {struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -enum port port = intel_dig_port->port;struct drm_device *dev = intel_dig_port->base.base.dev;uint32_t signal_levels, mask =0 ; -uint8_t train_set = intel_dp->train_set[0 ];if (HAS_DDI (dev)) { signal_levels =ddi_signal_levels (intel_dp);
@@ -540,12 +589,6 @@ _update_signal_levels(struct intel_dp *intel_dp) signal_levels =chv_signal_levels (intel_dp); }else if (IS_VALLEYVIEW (dev)) { signal_levels =vlv_signal_levels (intel_dp); - }else if (IS_GEN7 (dev) && port ==PORT_A ) { - signal_levels =gen7_edp_signal_levels (train_set); - mask =EDP_LINK_TRAIN_VOL_EMP_MASK_IVB ; - }else if (IS_GEN6 (dev) && port ==PORT_A ) { - signal_levels =gen6_edp_signal_levels (train_set); - mask =EDP_LINK_TRAIN_VOL_EMP_MASK_SNB ; }else {WARN (1 ,"Should be calling intel_dp->signal_levels->set instead." );return ;
@@ -605,9 +648,16 @@ intel_dp_init_signal_levels(struct intel_dp *intel_dp)struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);enum port port = intel_dig_port->port; -if (port !=PORT_A && (IS_IVYBRIDGE (dev) ||IS_GEN6 (dev))) - intel_dp->signal_levels = &snb_signal_levels; - -if (INTEL_INFO (dev)->gen <=5 ) +if (IS_IVYBRIDGE (dev)) { +if (port ==PORT_A ) + intel_dp->signal_levels = &ivb_edp_signal_levels; +else + intel_dp->signal_levels = &snb_signal_levels; + }else if (IS_GEN6 (dev)) { +if (port ==PORT_A ) + intel_dp->signal_levels = &snb_edp_signal_levels; +else + intel_dp->signal_levels = &snb_signal_levels; + }else if (INTEL_INFO (dev)->gen <=5 ) intel_dp->signal_levels = &gen4_signal_levels; }
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/9 drm/i915: Use struct intel_dp_signal_levels for VLV
In reply to Ander Conselvan de OliveiraUse the new struct intel_dp_signal_levels to store voltage swing and pre emphasis levels for VLV.
--- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 38 ++++++++++++++++++--------- 1 file changed, 26 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_dp_signal_levels.c +26 -12
@@ -115,7 +115,7 @@ _dp_pre_emphasis_max(struct intel_dp *intel_dp, uint8_t voltage_swing) } } -static uint32_t vlv_signal_levels (struct intel_dp *intel_dp) +static void vlv_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private;
@@ -124,7 +124,6 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp)to_intel_crtc (dport->base.base.crtc);unsigned long demph_reg_value, preemph_reg_value, uniqtranscale_reg_value; -uint8_t train_set = intel_dp->train_set[0 ];enum dpio_channel port =vlv_dport_to_channel (dport);int pipe = intel_crtc->pipe;
@@ -149,7 +148,8 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x5598DA3A ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;case DP_TRAIN_PRE_EMPH_LEVEL_1 :
@@ -168,7 +168,8 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x55ADDA3A ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;case DP_TRAIN_PRE_EMPH_LEVEL_2 :
@@ -183,7 +184,8 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x55ADDA3A ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;case DP_TRAIN_PRE_EMPH_LEVEL_3 :
@@ -194,11 +196,13 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp) uniqtranscale_reg_value =0x55ADDA3A ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_PRE_EMPHASIS_MASK ); +return ; }mutex_lock (&dev_priv->sb_lock);
@@ -211,10 +215,20 @@ static uint32_t vlv_signal_levels(struct intel_dp *intel_dp)vlv_dpio_write (dev_priv, pipe,VLV_PCS_DW9 (port), preemph_reg_value);vlv_dpio_write (dev_priv, pipe,VLV_TX_DW5 (port),0x80000000 );mutex_unlock (&dev_priv->sb_lock); - -return 0 ; } +static const struct signal_levels vlv_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_3 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_3 , +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = vlv_set_signal_levels, +}; +static bool chv_need_uniq_trans_scale (uint8_t train_set) { return (train_set & DP_TRAIN_PRE_EMPHASIS_MASK) == DP_TRAIN_PRE_EMPH_LEVEL_0 &&
@@ -587,8 +601,6 @@ _update_signal_levels(struct intel_dp *intel_dp) mask =DDI_BUF_EMP_MASK ; }else if (IS_CHERRYVIEW (dev)) { signal_levels =chv_signal_levels (intel_dp); - }else if (IS_VALLEYVIEW (dev)) { - signal_levels =vlv_signal_levels (intel_dp); }else {WARN (1 ,"Should be calling intel_dp->signal_levels->set instead." );return ;
@@ -648,7 +660,9 @@ intel_dp_init_signal_levels(struct intel_dp *intel_dp)struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);enum port port = intel_dig_port->port; -if (IS_IVYBRIDGE (dev)) { +if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev)) { + intel_dp->signal_levels = &vlv_signal_levels; + }else if (IS_IVYBRIDGE (dev)) {if (port ==PORT_A ) intel_dp->signal_levels = &ivb_edp_signal_levels;else
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/9 drm/i915: Use struct intel_dp_signal_levels for CHV
In reply to Ander Conselvan de OliveiraUse the new struct intel_dp_signal_levels to store voltage swing and pre emphasis levels for CHV.
--- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 38 ++++++++++++++++++--------- 1 file changed, 26 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_dp_signal_levels.c +26 -12
@@ -235,14 +235,13 @@ static bool chv_need_uniq_trans_scale(uint8_t train_set) (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ) ==DP_TRAIN_VOLTAGE_SWING_LEVEL_3 ; } -static uint32_t chv_signal_levels (struct intel_dp *intel_dp) +static void chv_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) {struct drm_device *dev =intel_dp_to_dev (intel_dp);struct drm_i915_private *dev_priv = dev->dev_private;struct intel_digital_port *dport =dp_to_dig_port (intel_dp);struct intel_crtc *intel_crtc =to_intel_crtc (dport->base.base.crtc);u32 deemph_reg_value, margin_reg_value, val; -uint8_t train_set = intel_dp->train_set[0 ];enum dpio_channel ch =vlv_dport_to_channel (dport);enum pipe pipe = intel_crtc->pipe;int i;
@@ -268,7 +267,8 @@ static uint32_t chv_signal_levels(struct intel_dp *intel_dp)/* FIXME extra to set for 1200 */ break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;case DP_TRAIN_PRE_EMPH_LEVEL_1 :
@@ -286,7 +286,8 @@ static uint32_t chv_signal_levels(struct intel_dp *intel_dp) margin_reg_value =154 ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;case DP_TRAIN_PRE_EMPH_LEVEL_2 :
@@ -300,7 +301,8 @@ static uint32_t chv_signal_levels(struct intel_dp *intel_dp) margin_reg_value =154 ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;case DP_TRAIN_PRE_EMPH_LEVEL_3 :
@@ -310,11 +312,13 @@ static uint32_t chv_signal_levels(struct intel_dp *intel_dp) margin_reg_value =154 ;break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_VOLTAGE_SWING_MASK ); +return ; }break ;default : -return 0 ; +MISSING_CASE (train_set &DP_TRAIN_PRE_EMPHASIS_MASK ); +return ; }mutex_lock (&dev_priv->sb_lock);
@@ -404,10 +408,20 @@ static uint32_t chv_signal_levels(struct intel_dp *intel_dp)vlv_dpio_write (dev_priv, pipe,CHV_CMN_DW30 , val);mutex_unlock (&dev_priv->sb_lock); - -return 0 ; } +static const struct signal_levels chv_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_3 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_3 , +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = chv_set_signal_levels, +}; +static void gen4_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) {
@@ -599,8 +613,6 @@ _update_signal_levels(struct intel_dp *intel_dp) signal_levels =0 ; else mask =DDI_BUF_EMP_MASK ; - }else if (IS_CHERRYVIEW (dev)) { - signal_levels =chv_signal_levels (intel_dp); }else {WARN (1 ,"Should be calling intel_dp->signal_levels->set instead." );return ;
@@ -660,7 +672,9 @@ intel_dp_init_signal_levels(struct intel_dp *intel_dp)struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);enum port port = intel_dig_port->port; -if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev)) { +if (IS_CHERRYVIEW (dev)) { + intel_dp->signal_levels = &chv_signal_levels; + }else if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev)) { intel_dp->signal_levels = &vlv_signal_levels; }else if (IS_IVYBRIDGE (dev)) {if (port ==PORT_A )
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/9 drm/i915: Use struct intel_dp_signal_levels for DDI platforms
In reply to Ander Conselvan de OliveiraUse the new struct intel_dp_signal_levels to store voltage swing and pre emphasis levels for DDI platforms.
--- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 63 ++++++++++++++++++++++++++- 1 file changed, 62 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp_signal_levels.c +62 -1
@@ -115,6 +115,59 @@ _dp_pre_emphasis_max(struct intel_dp *intel_dp, uint8_t voltage_swing) } } +static void +hsw_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) +{ +uint32_t signal_levels =ddi_signal_levels (intel_dp); + +DRM_DEBUG_KMS ("Using signal levels %08x\n" , signal_levels); + + intel_dp->DP &= ~DDI_BUF_EMP_MASK ; + intel_dp->DP |= signal_levels; +} + +static const struct signal_levels hsw_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_2 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_3 , +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = hsw_set_signal_levels, +}; + +static const struct signal_levels skl_edp_low_vswing_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_3 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_3 , +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = hsw_set_signal_levels, +}; + +static void +bxt_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) +{ +ddi_signal_levels (intel_dp); +} + +static const struct signal_levels bxt_signal_levels = { + .max_voltage =DP_TRAIN_VOLTAGE_SWING_LEVEL_3 , + .max_pre_emph = { +DP_TRAIN_PRE_EMPH_LEVEL_3 , +DP_TRAIN_PRE_EMPH_LEVEL_2 , +DP_TRAIN_PRE_EMPH_LEVEL_1 , +DP_TRAIN_PRE_EMPH_LEVEL_0 , + }, + + .set = bxt_set_signal_levels, +}; +static void vlv_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) {struct drm_device *dev =intel_dp_to_dev (intel_dp);
@@ -669,10 +722,18 @@ void intel_dp_init_signal_levels(struct intel_dp *intel_dp) {struct drm_device *dev =intel_dp_to_dev (intel_dp); +struct drm_i915_private *dev_priv =to_i915 (dev);struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);enum port port = intel_dig_port->port; -if (IS_CHERRYVIEW (dev)) { +if (IS_BROXTON (dev)) { + intel_dp->signal_levels = &bxt_signal_levels; + }else if (IS_SKYLAKE (dev) && + port ==PORT_A && dev_priv->edp_low_vswing) { + intel_dp->signal_levels = &skl_edp_low_vswing_signal_levels; + }else if (HAS_DDI (dev)) { + intel_dp->signal_levels = &hsw_signal_levels; + }else if (IS_CHERRYVIEW (dev)) { intel_dp->signal_levels = &chv_signal_levels; }else if (IS_VALLEYVIEW (dev) && !IS_CHERRYVIEW (dev)) { intel_dp->signal_levels = &vlv_signal_levels;
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/9 drm/i915: Remove old functions for maximum DP vswing and pre-emph levels
In reply to Ander Conselvan de OliveiraRemove the old functions for maximum DP voltage swing and pre-emphasis levels, now that all platforms use the new intel_dp_signal_values struct.
--- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 133 +------------------------- 1 file changed, 3 insertions(+), 130 deletions(-)
drivers/gpu/drm/i915/intel_dp_signal_levels.c +3 -130
@@ -23,98 +23,6 @@#include "intel_drv.h" -/* These are source-specific values. */ -static uint8_t -_dp_voltage_max (struct intel_dp *intel_dp) -{ -struct drm_device *dev =intel_dp_to_dev (intel_dp); -struct drm_i915_private *dev_priv = dev->dev_private; -enum port port =dp_to_dig_port (intel_dp)->port; - -if (IS_BROXTON (dev)) -return DP_TRAIN_VOLTAGE_SWING_LEVEL_3 ; -else if (INTEL_INFO (dev)->gen >=9 ) { -if (dev_priv->edp_low_vswing && port ==PORT_A ) -return DP_TRAIN_VOLTAGE_SWING_LEVEL_3 ; -return DP_TRAIN_VOLTAGE_SWING_LEVEL_2 ; - }else if (IS_VALLEYVIEW (dev)) -return DP_TRAIN_VOLTAGE_SWING_LEVEL_3 ; -else if (IS_GEN7 (dev) && port ==PORT_A ) -return DP_TRAIN_VOLTAGE_SWING_LEVEL_2 ; -else if (HAS_PCH_CPT (dev) && port !=PORT_A ) -return DP_TRAIN_VOLTAGE_SWING_LEVEL_3 ; -else -return DP_TRAIN_VOLTAGE_SWING_LEVEL_2 ; -} - -static uint8_t -_dp_pre_emphasis_max (struct intel_dp *intel_dp,uint8_t voltage_swing) -{ -struct drm_device *dev =intel_dp_to_dev (intel_dp); -enum port port =dp_to_dig_port (intel_dp)->port; - -if (INTEL_INFO (dev)->gen >=9 ) { -switch (voltage_swing &DP_TRAIN_VOLTAGE_SWING_MASK ) { -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 : -return DP_TRAIN_PRE_EMPH_LEVEL_3 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 : -return DP_TRAIN_PRE_EMPH_LEVEL_2 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 : -return DP_TRAIN_PRE_EMPH_LEVEL_1 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 : -return DP_TRAIN_PRE_EMPH_LEVEL_0 ; -default : -return DP_TRAIN_PRE_EMPH_LEVEL_0 ; - } - }else if (IS_HASWELL (dev) ||IS_BROADWELL (dev)) { -switch (voltage_swing &DP_TRAIN_VOLTAGE_SWING_MASK ) { -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 : -return DP_TRAIN_PRE_EMPH_LEVEL_3 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 : -return DP_TRAIN_PRE_EMPH_LEVEL_2 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 : -return DP_TRAIN_PRE_EMPH_LEVEL_1 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 : -default : -return DP_TRAIN_PRE_EMPH_LEVEL_0 ; - } - }else if (IS_VALLEYVIEW (dev)) { -switch (voltage_swing &DP_TRAIN_VOLTAGE_SWING_MASK ) { -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 : -return DP_TRAIN_PRE_EMPH_LEVEL_3 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 : -return DP_TRAIN_PRE_EMPH_LEVEL_2 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 : -return DP_TRAIN_PRE_EMPH_LEVEL_1 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 : -default : -return DP_TRAIN_PRE_EMPH_LEVEL_0 ; - } - }else if (IS_GEN7 (dev) && port ==PORT_A ) { -switch (voltage_swing &DP_TRAIN_VOLTAGE_SWING_MASK ) { -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 : -return DP_TRAIN_PRE_EMPH_LEVEL_2 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 : -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 : -return DP_TRAIN_PRE_EMPH_LEVEL_1 ; -default : -return DP_TRAIN_PRE_EMPH_LEVEL_0 ; - } - }else { -switch (voltage_swing &DP_TRAIN_VOLTAGE_SWING_MASK ) { -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 : -return DP_TRAIN_PRE_EMPH_LEVEL_2 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 : -return DP_TRAIN_PRE_EMPH_LEVEL_2 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 : -return DP_TRAIN_PRE_EMPH_LEVEL_1 ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 : -default : -return DP_TRAIN_PRE_EMPH_LEVEL_0 ; - } - } -} -static void hsw_set_signal_levels (struct intel_dp *intel_dp,uint8_t train_set) {
@@ -652,48 +560,16 @@ static const struct signal_levels ivb_edp_signal_levels = { .set = ivb_edp_set_signal_levels, }; -static void -_update_signal_levels (struct intel_dp *intel_dp) -{ -struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp); -struct drm_device *dev = intel_dig_port->base.base.dev; -uint32_t signal_levels, mask =0 ; - -if (HAS_DDI (dev)) { - signal_levels =ddi_signal_levels (intel_dp); - -if (IS_BROXTON (dev)) - signal_levels =0 ; -else - mask =DDI_BUF_EMP_MASK ; - }else { -WARN (1 ,"Should be calling intel_dp->signal_levels->set instead." ); -return ; - } - -if (mask) -DRM_DEBUG_KMS ("Using signal levels %08x\n" , signal_levels); - - intel_dp->DP &= ~mask; - intel_dp->DP |= signal_levels; -} -uint8_t intel_dp_voltage_max (struct intel_dp *intel_dp) { -if (intel_dp->signal_levels) -return intel_dp->signal_levels->max_voltage; -else -return _dp_voltage_max (intel_dp); +return intel_dp->signal_levels->max_voltage; }uint8_t intel_dp_pre_emphasis_max (struct intel_dp *intel_dp,uint8_t voltage_swing) { -if (intel_dp->signal_levels) -return intel_dp->signal_levels->max_pre_emph[voltage_swing]; -else -return _dp_pre_emphasis_max (intel_dp, voltage_swing); +return intel_dp->signal_levels->max_pre_emph[voltage_swing]; }void
@@ -703,10 +579,7 @@ intel_dp_update_signal_levels(struct intel_dp *intel_dp)struct drm_i915_private *dev_priv =to_i915 (dev);uint8_t train_set = intel_dp->train_set[0 ]; -if (intel_dp->signal_levels) - intel_dp->signal_levels->set (intel_dp, train_set); -else -_update_signal_levels (intel_dp); + intel_dp->signal_levels->set (intel_dp, train_set);DRM_DEBUG_KMS ("Using vswing level %d\n" , train_set &DP_TRAIN_VOLTAGE_SWING_MASK );
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/9 drm/i915: Move ddi_signal_levels() to intel_dp_signal_levels.c
In reply to Ander Conselvan de OliveiraThe logic for writing the DP register based on the vswing and pre emph values is in that file for all other platforms, so follow suit and move ddi_signal_levels() to intel_dp_signal_levels.c too.
--- drivers/gpu/drm/i915/intel_ddi.c | 78 ++------------------------- drivers/gpu/drm/i915/intel_dp_signal_levels.c | 73 ++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_drv.h | 6 ++- 3 files changed, 80 insertions(+), 77 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +4 -74
@@ -301,9 +301,6 @@ static const struct bxt_ddi_buf_trans bxt_ddi_translations_hdmi[] = { { 154, 0x9A, 1, 128, true }, /* 9: 1200 0 */ }; -static void bxt_ddi_vswing_sequence (struct drm_device *dev,u32 level, -enum port port,int type); -static void ddi_get_encoder_port (struct intel_encoder *intel_encoder,struct intel_digital_port **dig_port,enum port *port)
@@ -2063,8 +2060,8 @@ void intel_ddi_disable_pipe_clock(struct intel_crtc *intel_crtc) TRANS_CLK_SEL_DISABLED); } -static void skl_ddi_set_iboost (struct drm_device *dev,u32 level, -enum port port,int type) +void skl_ddi_set_iboost (struct drm_device *dev,u32 level, +enum port port,int type) {struct drm_i915_private *dev_priv = dev->dev_private;const struct ddi_buf_trans *ddi_translations;
@@ -2120,8 +2117,8 @@ static void skl_ddi_set_iboost(struct drm_device *dev, u32 level,I915_WRITE (DISPIO_CR_TX_BMU_CR0 , reg); } -static void bxt_ddi_vswing_sequence (struct drm_device *dev,u32 level, -enum port port,int type) +void bxt_ddi_vswing_sequence (struct drm_device *dev,u32 level, +enum port port,int type) {struct drm_i915_private *dev_priv = dev->dev_private;const struct bxt_ddi_buf_trans *ddi_translations;
@@ -2189,73 +2186,6 @@ static void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level,I915_WRITE (BXT_PORT_PCS_DW10_GRP (port), val); } -static uint32_t translate_signal_level (int signal_levels) -{ -uint32_t level; - -switch (signal_levels) { -default : -DRM_DEBUG_KMS ("Unsupported voltage swing/pre-emphasis level: 0x%x\n" , - signal_levels); -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_0 : - level =0 ; -break ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_1 : - level =1 ; -break ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_2 : - level =2 ; -break ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_0 |DP_TRAIN_PRE_EMPH_LEVEL_3 : - level =3 ; -break ; - -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_0 : - level =4 ; -break ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_1 : - level =5 ; -break ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_1 |DP_TRAIN_PRE_EMPH_LEVEL_2 : - level =6 ; -break ; - -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 |DP_TRAIN_PRE_EMPH_LEVEL_0 : - level =7 ; -break ; -case DP_TRAIN_VOLTAGE_SWING_LEVEL_2 |DP_TRAIN_PRE_EMPH_LEVEL_1 : - level =8 ; -break ; - -case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 |DP_TRAIN_PRE_EMPH_LEVEL_0 : - level =9 ; -break ; - } - -return level; -} - -uint32_t ddi_signal_levels (struct intel_dp *intel_dp) -{ -struct intel_digital_port *dport =dp_to_dig_port (intel_dp); -struct drm_device *dev = dport->base.base.dev; -struct intel_encoder *encoder = &dport->base; -uint8_t train_set = intel_dp->train_set[0 ]; -int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | -DP_TRAIN_PRE_EMPHASIS_MASK ); -enum port port = dport->port; -uint32_t level; - - level =translate_signal_level (signal_levels); - -if (IS_SKYLAKE (dev)) -skl_ddi_set_iboost (dev, level, port, encoder->type); -else if (IS_BROXTON (dev)) -bxt_ddi_vswing_sequence (dev, level, port, encoder->type); - -return DDI_BUF_TRANS_SELECT (level); -} -static void intel_ddi_pre_enable (struct intel_encoder *intel_encoder) {struct drm_encoder *encoder = &intel_encoder->base;
drivers/gpu/drm/i915/intel_dp_signal_levels.c +71 -2
88 lines not on this page · raw message
drivers/gpu/drm/i915/intel_drv.h +5 -1
@@ -1034,7 +1034,11 @@ void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder);void intel_ddi_clock_get (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config);void intel_ddi_set_vc_payload_alloc (struct drm_crtc *crtc,bool state); -uint32_t ddi_signal_levels (struct intel_dp *intel_dp); + +void skl_ddi_set_iboost (struct drm_device *dev,u32 level, +enum port port,int type); +void bxt_ddi_vswing_sequence (struct drm_device *dev,u32 level, +enum port port,int type);/* intel_frontbuffer.c */ void intel_fb_obj_invalidate(struct drm_i915_gem_object *obj,
Signature · 6 lines
2.4.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx