Skip to contentSkip to conversation

NVMe: Add explicit block config dependency

PATCH New Keith Busch 2 participants 2 messages Oct 12, 2015 NVMe

lore
Share & tools
lore

Keith Busch

author
#0 lore raw

PATCH 1/1 NVMe: Add explicit block config dependency

The nvme driver was moved from drivers/block, losing our implicit dependency on CONFIG_BLOCK. This makes it an explicit driver dependency.

Reported-by Jim Davis <jim.epost at gmail.com>
Signed-off-by Keith Busch <keith.busch at intel.com>
---
 drivers/nvme/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/Kconfig +1 -1
index 0089f78..002a94a 100644
@@ -1,6 +1,6 @@
 config BLK_DEV_NVME
 	tristate "NVM Express block device"
-	depends on PCI
+	depends on PCI && BLOCK
 	---help---
 	  The NVM Express driver is for solid state drives directly
 	  connected to the PCI or PCI Express bus.  If you know you
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

PATCH 1/1 NVMe: Add explicit block config dependency

Quoted 5 lines · Keith Busch

The nvme driver was moved from drivers/block, losing our implicit dependency on CONFIG_BLOCK. This makes it an explicit driver dependency.

Reported-by Jim Davis <jim.epost at gmail.com>
Signed-off-by Keith Busch <keith.busch at intel.com>

Oh, that explains the odd errors - I actually just got a similar one from the buildbot and couldn't make sense of it.

Looks good,

Reviewed-by Christoph Hellwig <hch at lst.de>