Skip to contentSkip to conversation

drivers :staging: android: make alignment match open parenthesis

PATCH In review Liao Tonglang 2 participants 3 messages Oct 13, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers :staging: android: make alignment match open parenthesis

Cleanup for checkpatch.pl warn below:

	CHECK: Alignment should match open parenthesis
	#836: FILE: drivers/staging/android/ashmem.c:836:

by split three lines to four.

---
 drivers/staging/android/ashmem.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/android/ashmem.c +4 -3
index 60200a3..99fc7dc 100644
@@ -832,9 +832,10 @@ static int __init ashmem_init(void)
 {
 	int ret;
 
-	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
-					  sizeof(struct ashmem_area),
-					  0, 0, NULL);
+	ashmem_area_cachep =
+		kmem_cache_create("ashmem_area_cache",
+				  sizeof(struct ashmem_area),
+				  0, 0, NULL);
 	if (unlikely(!ashmem_area_cachep)) {
 		pr_err("failed to create slab cache\n");
 		return -ENOMEM;
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 15 lines · Liao Tonglang

Cleanup for checkpatch.pl warn below:

	CHECK: Alignment should match open parenthesis
	#836: FILE: drivers/staging/android/ashmem.c:836:

by split three lines to four.

---
 drivers/staging/android/ashmem.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/android/ashmem.c +0 -0
index 60200a3..99fc7dc 100644

drivers/staging/android/ashmem.c static int __init ashmem_init(void) · line 838

Quoted 10 lines
drivers/staging/android/ashmem.c +4 -3
@@ -832,9 +832,10 @@ static int __init ashmem_init(void)
 {
 	int ret;
 
-	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
-					  sizeof(struct ashmem_area),
-					  0, 0, NULL);
+	ashmem_area_cachep =
+		kmem_cache_create("ashmem_area_cache",
+				  sizeof(struct ashmem_area),
+				  0, 0, NULL);

Now you are just getting very picky for checkpatch issues, is this really more readable?

thanks,

greg k-h

#2 lore raw
Quoted 8 lines · Greg KH

drivers/staging/android/ashmem.c static int __init ashmem_init(void) · line 838

Quoted 7 lines
drivers/staging/android/ashmem.c +4 -3
-	ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
-					  sizeof(struct ashmem_area),
-					  0, 0, NULL);
+	ashmem_area_cachep =
+		kmem_cache_create("ashmem_area_cache",
+				  sizeof(struct ashmem_area),
+				  0, 0, NULL);

is this really more readable?

You are right. The four-line version looks stupid. Just ignore these changes.

Thanks for your patience,

liao