Skip to contentSkip to conversation

MAINTAINERS: fix entry of char/misc

PATCH In review Sudip Mukherjee 3 participants 6 messages Oct 13, 2015 – Oct 14, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: fix entry of char/misc

Greg and Arnd are supporter of char and misc drivers. While using getmaintainer.pl on any patch or any file in these directories their names were never displayed.
And for this reason quite a few patches for these char and misc have never been picked up as they never had Greg or Arnd in To or Cc.

---

I personally faced this multiple times and faced again just now while sending another patch for misc. Greg can also confirm about the missing patches. But this maybe a problem with getmaintainer.pl file also. So adding Joe Perches to Cc list.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
MAINTAINERS +2 -2
index 21348d8..a8a1676 100644
@@ -2698,8 +2698,8 @@ M:	Arnd Bergmann <[email protected]>
 M:	Greg Kroah-Hartman <[email protected]>
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
 S:	Supported
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h
 
 CHECKPATCH
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Sudip Mukherjee

Greg and Arnd are supporter of char and misc drivers. While using getmaintainer.pl on any patch or any file in these directories their names were never displayed.

[]

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

MAINTAINERS M: Arnd Bergmann <[email protected]> · line 2703

Quoted 8 lines

M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported

MAINTAINERS +2 -2
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h

Do Greg and Arnd really want to be supporting all subsystems below drivers/char like agp and xillybus?

#2 lore raw
Quoted 7 lines · Joe Perches
Quoted 3 lines · Sudip Mukherjee

Greg and Arnd are supporter of char and misc drivers. While using getmaintainer.pl on any patch or any file in these directories their names were never displayed.

[]

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

Quoted 11 lines

MAINTAINERS M: Arnd Bergmann <[email protected]> · line 2703

Quoted 8 lines

M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported

MAINTAINERS +2 -2
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h

Do Greg and Arnd really want to be supporting all subsystems below drivers/char like agp and xillybus?

I don't know that. Maybe Greg and Arnd can say.
But wasn't that the intention when char/* and misc/* was mentioned here?

regards
sudip

#3 lore raw
Quoted 20 lines · Sudip Mukherjee
Quoted 7 lines · Joe Perches
Quoted 3 lines · Sudip Mukherjee

Greg and Arnd are supporter of char and misc drivers. While using getmaintainer.pl on any patch or any file in these directories their names were never displayed.

[]

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

Quoted 11 lines

MAINTAINERS M: Arnd Bergmann <[email protected]> · line 2703

Quoted 8 lines

M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported

MAINTAINERS +2 -2
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h

Do Greg and Arnd really want to be supporting all subsystems below drivers/char like agp and xillybus?

Quoted 2 lines

I don't know that. Maybe Greg and Arnd can say.
But wasn't that the intention when char/* *nd misc/* was mentioned here?

No.

It was specific to files that are only in the top level directories drivers/char/ and drivers/misc/ but not any files in directories below those.

There should be some difference between S: uses for some of the char and misc bits.

Besides, as commit 46e642614b36 shows, Greg and Arnd are self-described fools...

Still, it may be sensible have 2 MAINTAINERS sections like:

CHAR and MISC CORE
M: Arnd Bergmann <[email protected]>
M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported
F: drivers/char/*
F: drivers/misc/*
F: include/linux/miscdevice.h

CHAR and MISC DRIVERS
M: Arnd Bergmann <[email protected]>
M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Odd fixes
F: drivers/char/
F: drivers/misc/

but maybe there should be some exclusions in the drivers block like:

X: drivers/char/hw_random/
X: drivers/char/ipmi/

and probably some others.

#4 lore raw
In reply to Sudip Mukherjee
Quoted 20 lines · Sudip Mukherjee
Quoted 7 lines · Joe Perches
Quoted 3 lines · Sudip Mukherjee

Greg and Arnd are supporter of char and misc drivers. While using getmaintainer.pl on any patch or any file in these directories their names were never displayed.

[]

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

Quoted 11 lines

MAINTAINERS M: Arnd Bergmann <[email protected]> · line 2703

Quoted 8 lines

M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported

MAINTAINERS +2 -2
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h

Do Greg and Arnd really want to be supporting all subsystems below drivers/char like agp and xillybus?

Quoted 2 lines

I don't know that. Maybe Greg and Arnd can say.
But wasn't that the intention when char/* and misc/* was mentioned here?

Kind of, I'm here to pick up the portions of this tree that do not have a maintainer already (random.c is one example.)

thanks,

greg k-h

#5 lore raw
Quoted 21 lines · Greg Kroah-Hartman
Quoted 20 lines · Sudip Mukherjee
Quoted 18 lines · Joe Perches
Quoted 3 lines · Sudip Mukherjee

Greg and Arnd are supporter of char and misc drivers. While using getmaintainer.pl on any patch or any file in these directories their names were never displayed.

[]

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

MAINTAINERS M: Arnd Bergmann <[email protected]> · line 2703

Quoted 8 lines

M: Greg Kroah-Hartman <[email protected]>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
S: Supported

MAINTAINERS +2 -2
-F:	drivers/char/*
-F:	drivers/misc/*
+F:	drivers/char/
+F:	drivers/misc/
 F:	include/linux/miscdevice.h

Do Greg and Arnd really want to be supporting all subsystems below drivers/char like agp and xillybus?

Quoted 5 lines
Quoted 2 lines

I don't know that. Maybe Greg and Arnd can say.
But wasn't that the intention when char/* and misc/* was mentioned here?

Kind of, I'm here to pick up the portions of this tree that do not have a maintainer already (random.c is one example.)

Then what about the ones that has a maintainer? I had specifically sgi-gru in mind when I made this patch. I hope you remember the issue that I pointed out when i sent some patches for that.

regards
sudip