Skip to contentSkip to conversation

toaster: fixed crash in store_started_task

PATCH New Ed Bartosh 1 participant 1 message Oct 14, 2015

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 toaster: fixed crash in store_started_task

get_update_recipe_object was called with a parameter 'must_exist' set to True, which causes it to raise this exception:
NotExisting("Recipe object created when expected to exist"

Obviously recipe was expected to exist for some reason, but that changed. Probably order of events from bitbake changed in a way that when this event comes to toastergui there is no other events came yet that would cause recipe to be created.

Removed must_exist parameter from the call solved the issue. Now Toaster UI shows a lot more info about command line builds.

[YOCTO #8279]

---
 bitbake/lib/bb/ui/buildinfohelper.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/bb/ui/buildinfohelper.py +1 -1
index a8c884d..1571065 100644
@@ -1021,7 +1021,7 @@ class BuildInfoHelper(object):
         identifier = event.taskfile + ":" + event.taskname
 
         recipe_information = self._get_recipe_information_from_taskfile(event.taskfile)
-        recipe = self.orm_wrapper.get_update_recipe_object(recipe_information, True)
+        recipe = self.orm_wrapper.get_update_recipe_object(recipe_information)
 
         task_information = self._get_task_information(event, recipe)
         task_information['outcome'] = Task.OUTCOME_NA
Signature · 1 line
2.1.4