Skip to contentSkip to conversation

image-fit: Fix signature checking

PATCH In review andrej at inversepath.com 2 participants 2 messages Oct 14, 2015 – Oct 20, 2015

lore
Share & tools
lore

andrej at inversepath.com

author
#0 lore raw

PATCH 1/1 image-fit: Fix signature checking

From: Andrej Rosano <[email protected]>

On signature verification failures fit_image_verify() should exit with error.

Signed-off-by Andrej Rosano <[email protected]>
---
 common/image-fit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
common/image-fit.c +3 -1
index 28f7aa8..c531ee7 100644
@@ -1030,8 +1030,10 @@ int fit_image_verify(const void *fit, int image_noffset)
 					strlen(FIT_SIG_NODENAME))) {
 			ret = fit_image_check_sig(fit, noffset, data,
 							size, -1, &err_msg);
-			if (ret)
+			if (ret) {
 				puts("- ");
+				goto error;
+			}
 			else
 				puts("+ ");
 		}
Signature · 1 line
2.1.4
#1 lore raw
Quoted 6 lines · andrej at inversepath.com

From: Andrej Rosano <[email protected]>

On signature verification failures fit_image_verify() should exit with error.

Signed-off-by Andrej Rosano <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151019/46c186b7/attachment.sig>