bitops.h: improve sign extending API
PATCH 1/2 improves the doc of sign_extend32()
This should help to avoid different manual approaches to sign extension
PATCH 2/2 adds sign_extend64()
An informal example of what could follow inarch/sh/kernel/traps_64.c after PATCH 2/2:
@@ -101,7 +102,7 @@ static int generate_and_check_address(struct pt_regs *regs,
__s64 displacement;
displacement = (opcode >> 10) & 0x3ff;
- displacement = ((displacement << 54) >> 54); /* sign extend */
+ displacement = sign_extend64(displacement, 9);
addr = (__u64)((__s64)base_address + (displacement << width_shift));
} else {PATCH 1/2 bitops.h: Improve sign_extend32()'s documentation
It is often overlooked that sign_extend32(), despite it's name, is safe to use for 16 and 8 bit types aswell. This should help that sign extension isn't done manually some other way.
--- include/linux/bitops.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/bitops.h +2 -0
@@ -164,6 +164,8 @@ static inline __u8 ror8(__u8 word, unsigned int shift)* sign_extend32 - sign extend a 32-bit value using specified bit as sign-bit * @value: value to sign extend * @index: 0 based bit index (0<=index<32) to sign bit +* +* This is safe to use for 16- and 8-bit types aswell. */ static inline __s32 sign_extend32 (__u32 value,int index) {
Signature · 1 line
2.1.4
Re: [PATCH 1/2] bitops.h: Improve sign_extend32()'s documentation
"as well" is two words, not one.
Also, a third patch adding users of sign_extend64 would help; otherwise it's just adding dead code.
PATCH 2/2 bitops.h: add sign_extend64()
In reply to Martin KepplingerMonths back, this was discussed, see https://lkml.org/lkml/2015/1/18/289
The result was the 64-bit version being "likely fine", "valuable" and "correct". The discussion only fell asleep but since there are possible users, let's add it.
--- include/linux/bitops.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/linux/bitops.h +11 -0
@@ -173,6 +173,17 @@ static inline __s32 sign_extend32(__u32 value, int index)return (__s32)(value << shift) >> shift; } +/** +* sign_extend64 - sign extend a 64-bit value using specified bit as sign-bit +* @value: value to sign extend +* @index: 0 based bit index (0<=index<64) to sign bit +*/ +static inline __s64 sign_extend64 (__u64 value,int index) +{ +__u8 shift =63 - index; +return (__s64)(value << shift) >> shift; +} +static inline unsigned fls_long (unsigned long l) {if (sizeof (l) ==4 )
Signature · 1 line
2.1.4