Skip to contentSkip to conversation

Staging: sm750fb: Include appropriate KERN_ facility level

PATCH In review Aybuke Ozdemir 4 participants 7 messages Oct 16, 2015 – Oct 17, 2015

Subsystems (2)
Staging Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Aybuke Ozdemir

author
#0 lore raw

PATCH v2 1/2 Staging: sm750fb: Include appropriate KERN_ facility level

Problem found using checkpatch.pl:
"WARNING: printk() should include KERN_ facility level"

Signed-off-by Aybuke Ozdemir <[email protected]>

---
Changes since v1:
* used dev_info instead of pr_info.

---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +1 -1
index 9637dd3..d20cd92 100644
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		dev_info("found sm750le\n");
 }
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v2 2/2 Staging: sm750fb: Remove multiple blank lines

Remove multiple blank lines. Problem found using checkpatch.pl
CHECK: Please don't use multiple blank lines.

Signed-off-by Aybuke Ozdemir <[email protected]>

---
Changes since v1:
* it is part of a set, was re-versioning.

---
 drivers/staging/sm750fb/ddk750_help.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/sm750fb/ddk750_help.c +0 -2
index d20cd92..2982a7b 100644
@@ -13,5 +13,3 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	if (revId == 0xfe)
 		dev_info("found sm750le\n");
 }
-
-
Signature · 1 line
1.9.1
maintainer
#2 lore raw
In reply to Aybuke Ozdemir
Quoted 16 lines · Aybuke Ozdemir

Problem found using checkpatch.pl:
"WARNING: printk() should include KERN_ facility level"

Signed-off-by Aybuke Ozdemir <[email protected]>

---
Changes since v1:
* used dev_info instead of pr_info.

---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_help.c +0 -0
index 9637dd3..d20cd92 100644

drivers/staging/sm750fb/ddk750_help.c void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) · line 15

Quoted 6 lines
drivers/staging/sm750fb/ddk750_help.c +1 -1
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		dev_info("found sm750le\n");
 }

You obviously did not try to build this patch :(

author
#3 lore raw

Hi Greg,

I used this command "make drivers/staging/sm750fb/" before applying the patch.
I sent that I faced no problems. :( command output:

aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
aybuke@kripton:~/git/kernels/staging$
#4 lore raw

Hi Aybuke

Quoted 3 lines · Aybuke Ozdemir

Hi Greg,

I used this command "make drivers/staging/sm750fb/" before applying the

I'm not sure if that command is correct, try :
make drivers/staging/sm750fb/ddk750_help.o

Quoted 23 lines

patch.
I sent that I faced no problems. :( command output:

aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
aybuke@kripton:~/git/kernels/staging$

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/CAEAX3JrU%3D56tg94bo1w6gHNBr9nEtcgRauXfa%2BGFxa8r477hmw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

#5 lore raw
In reply to Aybuke Ozdemir
Quoted 6 lines · Aybuke Ozdemir

Hi Greg,

I used this command "make drivers/staging/sm750fb/" before applying the patch.
I sent that I faced no problems. :( command output:

Quoted 9 lines
aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
aybuke@kripton:~/git/kernels/staging$

It doesn't look like it compiled anything. You would have a CC command if it had. Do you have a .o file for the .c file that you changed?

julia

Quoted 12 lines

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAEAX3JrU%3D56tg94bo1w6g HNBr9nEtcgRauXfa%2BGFxa8r477hmw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

author
#6 lore raw

Yes, it really does not compile, I'm sorry for mail traffic. Very thanks for helps :)

2015-10-17 13:44 GMT+03:00 Julia Lawall <[email protected]>:

Quoted 37 lines · Aybuke Ozdemir
Quoted 7 lines

Hi Greg,

I used this command "make drivers/staging/sm750fb/" before applying the patch.
I sent that I faced no problems. :( command output:

Quoted 9 lines
aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
aybuke@kripton:~/git/kernels/staging$

It doesn't look like it compiled anything. You would have a CC command if it had. Do you have a .o file for the .c file that you changed?

julia

Quoted 8 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/CAEAX3JrU%3D56tg94bo1w6g

Quoted 4 lines

HNBr9nEtcgRauXfa%2BGFxa8r477hmw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.

Signature · 2 lines
Aybüke Özdemir
https://about.me/aybukeozdemir