Skip to contentSkip to conversation

fault-inject: fix inverted interval/probability values in printk

PATCH In review Florian Westphal 2 participants 2 messages Oct 17, 2015 – Oct 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fault-inject: fix inverted interval/probability values in printk

interval displays the probability and vice versa.

Fixes 6adc4a22f20bb ("fault-inject: add ratelimit option")
---
 lib/fault-inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/fault-inject.c +1 -1
index f1cdeb0..6a823a5 100644
@@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
 		printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
 		       "name %pd, interval %lu, probability %lu, "
 		       "space %d, times %d\n", attr->dname,
-		       attr->probability, attr->interval,
+		       attr->interval, attr->probability,
 		       atomic_read(&attr->space),
 		       atomic_read(&attr->times));
 		if (attr->verbose > 1)
Signature · 1 line
2.0.5
maintainer Acked-by on v1 1/1
#1 lore raw

2015-10-17 17:51 GMT+09:00 Florian Westphal <[email protected]>:

Quoted 4 lines

interval displays the probability and vice versa.

Fixes 6adc4a22f20bb ("fault-inject: add ratelimit option")

Looks good to me.

Andrew, could you consider to merge this patch to your tree?

Quoted 20 lines
---
 lib/fault-inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/fault-inject.c +1 -2
index f1cdeb0..6a823a5 100644
@@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
                printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
                       "name %pd, interval %lu, probability %lu, "
                       "space %d, times %d\n", attr->dname,
-                      attr->probability, attr->interval,
+                      attr->interval, attr->probability,
                       atomic_read(&attr->space),
                       atomic_read(&attr->times));
                if (attr->verbose > 1)
--

2.0.5