Skip to contentSkip to conversation

taskd: new package

PATCH Superseded Ben Boeckel 4 participants 6 messages Oct 18, 2015 – Mar 10, 2016

lore
Share & tools
lore

Ben Boeckel

author
#0 lore raw

PATCH 1/1 taskd: new package

Taskwarrior is a task management suite of tools. Taskd is the synchronization server for it.

Signed-off-by Ben Boeckel <[email protected]>
---
 package/Config.in       |  1 +
 package/taskd/Config.in |  9 +++++++++
 package/taskd/taskd.mk  | 14 ++++++++++++++
 3 files changed, 24 insertions(+)
 create mode 100644 package/taskd/Config.in
 create mode 100644 package/taskd/taskd.mk
package/Config.in +1 -0
index 7746742..0620465 100644
@@ -1370,6 +1370,7 @@ endif
 	source "package/sshpass/Config.in"
 	source "package/strongswan/Config.in"
 	source "package/stunnel/Config.in"
+	source "package/taskd/Config.in"
 	source "package/tcpdump/Config.in"
 	source "package/tcping/Config.in"
 	source "package/tcpreplay/Config.in"
package/taskd/Config.in new file +9 -0
new file mode 100644
index 0000000..534881f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_TASKD
+	bool "taskd"
+	select BR2_PACKAGE_GNUTLS
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	help
+	  Task management synchronization daemon.
+
+	  http://taskwarrior.org/
package/taskd/taskd.mk new file +14 -0
new file mode 100644
index 0000000..0bdf81d
@@ -0,0 +1,14 @@
+################################################################################
+#
+# taskd
+#
+################################################################################
+
+TASKD_VERSION = 1.1.0
+TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
+TASKD_SITE = http://taskwarrior.org/download
+TASKD_LICENSE = MIT
+TASKD_LICENSE_FILES = COPYING LICENSE
+TASKD_DEPENDENCIES = gnutls util-linux
+
+$(eval $(cmake-package))
Signature · 1 line
2.6.1
author
#1 lore raw

PATCH 1/1 taskd: new package

Quoted 2 lines · Ben Boeckel

Taskwarrior is a task management suite of tools. Taskd is the synchronization server for it.

Bump.

--Ben

#2 lore raw

PATCH 1/1 taskd: new package

In reply to Ben Boeckel

Ben, All,

Sorry for the dlong delay... Here's my review, there ar ea few comments, see below...

On 2015-10-18 17:36 -0400, Ben Boeckel spake thusly:

Quoted 5 lines

Taskwarrior is a task management suite of tools. Taskd is the synchronization server for it.

Signed-off-by Ben Boeckel <[email protected]>

---

[--SNIP--]

package/taskd/Config.in line 2

Quoted 8 lines
package/taskd/Config.in new file +2 -0
new file mode 100644
index 0000000..534881f
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_TASKD
+	bool "taskd"

taskd uses fork(), so you need to depend on BR2_USE_MMU.

package/taskd/Config.in line 4

Quoted 2 lines
package/taskd/Config.in new file +2 -0
+	select BR2_PACKAGE_GNUTLS
+	select BR2_PACKAGE_UTIL_LINUX

gnutls and util-linux both depend on BR2_USE_WCHAR, so you need to propagate that dependency.

However, taskd depends on widechar for itself, so you also need that dependency anyway.

Otherwise, sems OK...

Care to fix and respin, please? In the meantime, I marked your patch as Changes Requested in our patchwork.

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 32 lines
package/taskd/Config.in new file +5 -0
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	help
+	  Task management synchronization daemon.
+
+	  http://taskwarrior.org/
package/taskd/taskd.mk new file +14 -0
new file mode 100644
index 0000000..0bdf81d
@@ -0,0 +1,14 @@
+################################################################################
+#
+# taskd
+#
+################################################################################
+
+TASKD_VERSION = 1.1.0
+TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
+TASKD_SITE = http://taskwarrior.org/download
+TASKD_LICENSE = MIT
+TASKD_LICENSE_FILES = COPYING LICENSE
+TASKD_DEPENDENCIES = gnutls util-linux
+
+$(eval $(cmake-package))
Signature · 6 lines
2.6.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#3 lore raw

PATCH v2 1/1 taskd: new package

In reply to Ben Boeckel

Taskwarrior is a task management suite of tools. Taskd is the synchronization server for it.

Signed-off-by Ben Boeckel <[email protected]>
---
 package/Config.in       |  1 +
 package/taskd/Config.in | 11 +++++++++++
 package/taskd/taskd.mk  | 14 ++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/taskd/Config.in
 create mode 100644 package/taskd/taskd.mk
package/Config.in +1 -0
index d916154..35a24ba 100644
@@ -1489,6 +1489,7 @@ endif
 	source "package/sshpass/Config.in"
 	source "package/strongswan/Config.in"
 	source "package/stunnel/Config.in"
+	source "package/taskd/Config.in"
 	source "package/tcpdump/Config.in"
 	source "package/tcping/Config.in"
 	source "package/tcpreplay/Config.in"
package/taskd/Config.in new file +11 -0
new file mode 100644
index 0000000..5b357f5
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_TASKD
+	bool "taskd"
+	select BR2_PACKAGE_GNUTLS
+	select BR2_USE_MMU
+	select BR2_USE_WCHAR
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	help
+	  Task management synchronization daemon.
+
+	  http://taskwarrior.org/
package/taskd/taskd.mk new file +14 -0
new file mode 100644
index 0000000..0bdf81d
@@ -0,0 +1,14 @@
+################################################################################
+#
+# taskd
+#
+################################################################################
+
+TASKD_VERSION = 1.1.0
+TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz
+TASKD_SITE = http://taskwarrior.org/download
+TASKD_LICENSE = MIT
+TASKD_LICENSE_FILES = COPYING LICENSE
+TASKD_DEPENDENCIES = gnutls util-linux
+
+$(eval $(cmake-package))
Signature · 1 line
2.7.2
#4 lore raw

PATCH v2 1/1 taskd: new package

Quoted 17 lines · Ben Boeckel

Taskwarrior is a task management suite of tools. Taskd is the synchronization server for it.

Signed-off-by Ben Boeckel <[email protected]>
---
  package/Config.in       |  1 +
  package/taskd/Config.in | 11 +++++++++++
  package/taskd/taskd.mk  | 14 ++++++++++++++
  3 files changed, 26 insertions(+)

create mode 100644 package/taskd/Config.in
create mode 100644 package/taskd/taskd.mk

package/Config.in +0 -0
index d916154..35a24ba 100644

package/Config.in endif · line 1492

Quoted 4 lines
package/Config.in +1 -0
@@ -1489,6 +1489,7 @@ endif
  	source "package/sshpass/Config.in"
  	source "package/strongswan/Config.in"
  	source "package/stunnel/Config.in"
+	source "package/taskd/Config.in"

I don't think networking tools is the appropriate location. Miscellaneous maybe.

Quoted 9 lines
package/Config.in +0 -0
  	source "package/tcpdump/Config.in"
  	source "package/tcping/Config.in"
  	source "package/tcpreplay/Config.in"
package/taskd/Config.in new file +0 -0
new file mode 100644
index 0000000..5b357f5

package/taskd/Config.in line 5

Quoted 5 lines
package/taskd/Config.in new file +5 -0
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_TASKD
+	bool "taskd"
+	select BR2_PACKAGE_GNUTLS
+	select BR2_USE_MMU
+	select BR2_USE_WCHAR

You cannot select MMU and WCHAR, you need to depend on it. See
https://buildroot.org/downloads/manual/manual.html#depends-on-vs-select
The depends lines should come immediately after bool "taskd". There should also be a comment at the end of the file that tells the user that taskd is only available with wchar.

In addition to these two, it also needs C++11. So definitely
BR2_INSTALL_LIBSTDCPP, and probably also some minimal gcc version. Try with the Arago ARMv7 2011.09 if 4.5 works; if it does, add BR2_TOOLCHAIN_GCC_AT_LEAST_4_5, and so on until you find the minimal version.

Quoted 12 lines
package/taskd/Config.in new file +6 -0
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
+	help
+	  Task management synchronization daemon.
+
+	  http://taskwarrior.org/
package/taskd/taskd.mk new file +0 -0
new file mode 100644
index 0000000..0bdf81d

package/taskd/taskd.mk line 8

Quoted 8 lines
package/taskd/taskd.mk new file +8 -0
@@ -0,0 +1,14 @@
+################################################################################
+#
+# taskd
+#
+################################################################################
+
+TASKD_VERSION = 1.1.0
+TASKD_SOURCE = taskd-$(TASKD_VERSION).tar.gz

This is the default, not needed.

package/taskd/taskd.mk line 11

Quoted 3 lines
package/taskd/taskd.mk new file +3 -0
+TASKD_SITE = http://taskwarrior.org/download
+TASKD_LICENSE = MIT
+TASKD_LICENSE_FILES = COPYING LICENSE

AFAICS both files are identical, so specifying only one of them (COPYING) is
sufficient.

Regards,
Arnout

Quoted 4 lines
package/taskd/taskd.mk new file +3 -0
+TASKD_DEPENDENCIES = gnutls util-linux
+
+$(eval $(cmake-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#5 lore raw

PATCH v2 1/1 taskd: new package

In reply to Ben Boeckel

Ben,

Quoted 4 lines · Ben Boeckel

Taskwarrior is a task management suite of tools. Taskd is the synchronization server for it.

Signed-off-by Ben Boeckel <[email protected]>

Thanks for this updated version! I've applied, but there were still a few things to fix. Here are the changes I did:

[Thomas:
- use 'depends on' for BR2_USE_MMU, and add a comment indicating that the dependency is due to the use of fork()
- use 'depends on' for BR2_USE_WCHAR, and add a comment indicating that the dependency is due to gnutls and util-linux.
- add a hash file.]

Also, it would be a good idea to send a new patch that adds a simple init script to start this server at boot time. This way, taskd can work "out of the box".

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com