Skip to contentSkip to conversation

Coding Style Cleanning

PATCH In review Paul McQuade 3 participants 7 messages Oct 19, 2015 – Feb 2, 2016

Subsystems (4)
Networking Network drivers Networking drivers (wireless) Redpine wireless driver
lore
Share & tools
lore

Paul McQuade

author
#0 lore raw

v2 cover Coding Style Cleanning

Paul McQuade (3):
net: wireless: rsi: Coding Spaces
net: wireless: b43: Coding Style
net: wireless: b43: Statics are init to 0

 drivers/net/wireless/b43/main.c             | 8 ++++----
 drivers/net/wireless/b43/main.h             | 2 +-
 drivers/net/wireless/b43/phy_lp.c           | 2 +-
 drivers/net/wireless/b43/xmit.h             | 2 +-
 drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +-
 drivers/net/wireless/rsi/rsi_mgmt.h         | 4 ++--
 6 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
2.6.1
author
#1 lore raw

PATCH v2 1/3 net: wireless: rsi: Coding Spaces

Removed space before that ','

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +-
 drivers/net/wireless/rsi/rsi_mgmt.h         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/rsi/rsi_91x_sdio_ops.c +1 -1
index 40d7231..8fa241b 100644
@@ -435,7 +435,7 @@ void rsi_interrupt_handler(struct rsi_hw *adapter)
 				} else {
 					rsi_dbg(ERR_ZONE,
 						"%s: Firmware Status is 0x%x\n",
-						__func__ , fw_status);
+						__func__, fw_status);
 					rsi_sdio_ack_intr(common->priv,
 							  (1 << FW_ASSERT_IND));
 				}
drivers/net/wireless/rsi/rsi_mgmt.h +2 -2
index 3741173..3d4eddd 100644
@@ -173,9 +173,9 @@ enum cmd_frame_type {
 	AUTO_RATE_IND,
 	BOOTUP_PARAMS_REQUEST,
 	VAP_CAPABILITIES,
-	EEPROM_READ_TYPE ,
+	EEPROM_READ_TYPE,
 	EEPROM_WRITE,
-	GPIO_PIN_CONFIG ,
+	GPIO_PIN_CONFIG,
 	SET_RX_FILTER,
 	AMPDU_IND,
 	STATS_REQUEST_FRAME,
Signature · 1 line
2.6.1
author
#2 lore raw

PATCH v2 2/3 net: wireless: b43: Coding Style

In reply to Paul McQuade

Fixed Pointer Coding Style

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/net/wireless/b43/main.c | 6 +++---
 drivers/net/wireless/b43/main.h | 2 +-
 drivers/net/wireless/b43/xmit.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/b43/main.c +3 -3
index 2849070..040caa4 100644
@@ -364,7 +364,7 @@ static struct ieee80211_supported_band b43_band_2ghz_limited = {
 
 static void b43_wireless_core_exit(struct b43_wldev *dev);
 static int b43_wireless_core_init(struct b43_wldev *dev);
-static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev);
+static struct b43_wldev *b43_wireless_core_stop(struct b43_wldev *dev);
 static int b43_wireless_core_start(struct b43_wldev *dev);
 static void b43_op_bss_info_changed(struct ieee80211_hw *hw,
 				    struct ieee80211_vif *vif,

@@ -989,7 +989,7 @@ static void do_key_write(struct b43_wldev *dev,
 		 * 0xffffffff and let's b43_op_update_tkip_key provide a
 		 * correct pair.
 		 */
-		rx_tkip_phase1_write(dev, index, 0xffffffff, (u16*)buf);
+		rx_tkip_phase1_write(dev, index, 0xffffffff, (u16 *)buf);
 	} else if (index >= pairwise_keys_start) /* clear it */
 		rx_tkip_phase1_write(dev, index, 0, NULL);
 	if (key)

@@ -4334,7 +4334,7 @@ out_unlock:
 /* Locking: wl->mutex
  * Returns the current dev. This might be different from the passed in dev,
  * because the core might be gone away while we unlocked the mutex. */
-static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev)
+static struct b43_wldev *b43_wireless_core_stop(struct b43_wldev *dev)
 {
 	struct b43_wl *wl;
 	struct b43_wldev *orig_dev;
drivers/net/wireless/b43/main.h +1 -1
index c46430c..fa56b22 100644
@@ -73,7 +73,7 @@ static inline int b43_is_ofdm_rate(int rate)
 u8 b43_ieee80211_antenna_sanitize(struct b43_wldev *dev,
 				  u8 antenna_nr);
 
-void b43_tsf_read(struct b43_wldev *dev, u64 * tsf);
+void b43_tsf_read(struct b43_wldev *dev, u64 *tsf);
 void b43_tsf_write(struct b43_wldev *dev, u64 tsf);
 
 u32 b43_shm_read32(struct b43_wldev *dev, u16 routing, u16 offset);
drivers/net/wireless/b43/xmit.h +1 -1
index ba61153..fed8657 100644
@@ -203,7 +203,7 @@ size_t b43_txhdr_size(struct b43_wldev *dev)
 
 
 int b43_generate_txhdr(struct b43_wldev *dev,
-		       u8 * txhdr,
+		       u8 *txhdr,
 		       struct sk_buff *skb_frag,
 		       struct ieee80211_tx_info *txctl, u16 cookie);
Signature · 1 line
2.6.1
Acked-by on v2 2/3
#3 lore raw

Re: [PATCH v2 2/3] net: wireless: b43: Coding Style

Quoted 58 lines · On Mon, 19 Oct 2015 17:02:22 +0100 Paul McQuade <[email protected]> wrote:

Fixed Pointer Coding Style

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/net/wireless/b43/main.c | 6 +++---
 drivers/net/wireless/b43/main.h | 2 +-
 drivers/net/wireless/b43/xmit.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/net/wireless/b43/main.c +3 -3
index 2849070..040caa4 100644
@@ -364,7 +364,7 @@ static struct ieee80211_supported_band b43_band_2ghz_limited = {
 
 static void b43_wireless_core_exit(struct b43_wldev *dev);
 static int b43_wireless_core_init(struct b43_wldev *dev);
-static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev);
+static struct b43_wldev *b43_wireless_core_stop(struct b43_wldev *dev);
 static int b43_wireless_core_start(struct b43_wldev *dev);
 static void b43_op_bss_info_changed(struct ieee80211_hw *hw,
 				    struct ieee80211_vif *vif,

@@ -989,7 +989,7 @@ static void do_key_write(struct b43_wldev *dev,
 		 * 0xffffffff and let's b43_op_update_tkip_key provide a
 		 * correct pair.
 		 */
-		rx_tkip_phase1_write(dev, index, 0xffffffff, (u16*)buf);
+		rx_tkip_phase1_write(dev, index, 0xffffffff, (u16 *)buf);
 	} else if (index >= pairwise_keys_start) /* clear it */
 		rx_tkip_phase1_write(dev, index, 0, NULL);
 	if (key)

@@ -4334,7 +4334,7 @@ out_unlock:
 /* Locking: wl->mutex
  * Returns the current dev. This might be different from the passed in dev,
  * because the core might be gone away while we unlocked the mutex. */
-static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev)
+static struct b43_wldev *b43_wireless_core_stop(struct b43_wldev *dev)
 {
 	struct b43_wl *wl;
 	struct b43_wldev *orig_dev;
drivers/net/wireless/b43/main.h +1 -1
index c46430c..fa56b22 100644
@@ -73,7 +73,7 @@ static inline int b43_is_ofdm_rate(int rate)
 u8 b43_ieee80211_antenna_sanitize(struct b43_wldev *dev,
 				  u8 antenna_nr);
 
-void b43_tsf_read(struct b43_wldev *dev, u64 * tsf);
+void b43_tsf_read(struct b43_wldev *dev, u64 *tsf);
 void b43_tsf_write(struct b43_wldev *dev, u64 tsf);
 
 u32 b43_shm_read32(struct b43_wldev *dev, u16 routing, u16 offset);
drivers/net/wireless/b43/xmit.h +0 -0
index ba61153..fed8657 100644

drivers/net/wireless/b43/xmit.h size_t b43_txhdr_size(struct b43_wldev *dev) · line 209

Quoted 8 lines
drivers/net/wireless/b43/xmit.h +1 -1
@@ -203,7 +203,7 @@ size_t b43_txhdr_size(struct b43_wldev *dev)
 
 
 int b43_generate_txhdr(struct b43_wldev *dev,
-		       u8 * txhdr,
+		       u8 *txhdr,
 		       struct sk_buff *skb_frag,
 		       struct ieee80211_tx_info *txctl, u16 cookie);
Acked-by Michael Buesch <[email protected]>
Signature · 8 lines
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20151019/351472f6/attachment-0001.sig>
#4 lore raw

Re: [v2,2/3] net: wireless: b43: Coding Style

In reply to Paul McQuade
Quoted 4 lines · Paul Mcquade

Fixed Pointer Coding Style

Signed-off-by Paul McQuade <[email protected]>
Acked-by Michael Buesch <[email protected]>

Please fix the From: name like i just replied in another of your patch and this patch will not apply anymore as the driver has moved to a new location drivers/net/wireless/broadcom/b43/

can you please rebase it against the current tree and send.

regards
sudip

author
#5 lore raw

PATCH v2 3/3 net: wireless: b43: Statics are init to 0

In reply to Paul McQuade

No Need to state Statics are a 0 or NULL

Signed-off-by Paul McQuade <[email protected]>
---
 drivers/net/wireless/b43/main.c   | 2 +-
 drivers/net/wireless/b43/phy_lp.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/b43/main.c +1 -1
index 040caa4..2b50650 100644
@@ -109,7 +109,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
 module_param_named(verbose, b43_modparam_verbose, int, 0644);
 MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
 
-static int b43_modparam_pio = 0;
+static int b43_modparam_pio;
 module_param_named(pio, b43_modparam_pio, int, 0644);
 MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");
drivers/net/wireless/b43/phy_lp.c +1 -1
index 058a9f2..086f0ba 100644
@@ -2502,7 +2502,7 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
 {
 	struct ssb_bus *bus = dev->dev->sdev->bus;
 
-	static const struct b206x_channel *chandata = NULL;
+	static const struct b206x_channel *chandata;
 	u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000;
 	u32 freqref, vco_freq, val1, val2, val3, timeout, timeoutref, count;
 	u16 old_comm15, scale;
Signature · 1 line
2.6.1
#6 lore raw

Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0

drivers/net/wireless/b43/phy_lp.c static int lpphy_b2063_tune(struct b43_wldev *dev, · line 2508

Quoted 13 lines · On Mon, 19 Oct 2015 17:02:23 +0100 Paul McQuade <[email protected]> wrote:
drivers/net/wireless/b43/phy_lp.c +1 -1
index 058a9f2..086f0ba 100644
@@ -2502,7 +2502,7 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
 {
 	struct ssb_bus *bus = dev->dev->sdev->bus;
 
-	static const struct b206x_channel *chandata = NULL;
+	static const struct b206x_channel *chandata;
 	u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000;
 	u32 freqref, vco_freq, val1, val2, val3, timeout, timeoutref, count;
 	u16 old_comm15, scale;

Why on earth is this static anyway? That seems really wrong here. The static should be removed (and the =NULL init be left in place.)

Signature · 8 lines
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20151019/5b6d1086/attachment-0001.sig>