python: don't append -D__SOFTFP__ to TARGET_CC_ARCH for armv6/armv7a
PATCH 1/1 python: don't append -D__SOFTFP__ to TARGET_CC_ARCH for armv6/armv7a
Remove obsolete hack which seems to date back to (at least) 2009. It's potentially harmful as python TARGET_CC_ARCH flags can leak through to other packages via the sysroot _sysconfigdata.py.
--- meta/recipes-devtools/python/python3_3.4.3.bb | 5 +---- meta/recipes-devtools/python/python_2.7.9.bb | 5 ----- 2 files changed, 1 insertion(+), 9 deletions(-)
meta/recipes-devtools/python/python3_3.4.3.bb +1 -4
@@ -56,10 +56,7 @@ CACHED_CONFIGUREVARS = "ac_cv_have_chflags=no \ ac_cv_file__dev_ptmx=yes \ ac_cv_file__dev_ptc=no \ " -# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :( -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__" -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__" + TARGET_CC_ARCH += "-DNDEBUG -fno-inline" EXTRA_OEMAKE += "CROSS_COMPILE=yes" EXTRA_OECONF += "CROSSPYTHONPATH=${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/ --without-ensurepip"
meta/recipes-devtools/python/python_2.7.9.bb +0 -5
@@ -34,11 +34,6 @@ inherit autotools multilib_header python-dir pythonnative CONFIGUREOPTS += " --with-system-ffi " -# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :( -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__" -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__" - # The following is a hack until we drop ac_cv_sizeof_off_t from site files EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', 'ac_cv_sizeof_off_t=8', '', d)} ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
Signature · 1 line
1.9.1
Quoted 21 lines · Andre McCurdy
Remove obsolete hack which seems to date back to (at least) 2009. It's potentially harmful as python
TARGET_CC_ARCHflags can leak through to other packages via the sysroot_sysconfigdata.py.Signed-off-by Andre McCurdy <[email protected]>---
meta/recipes-devtools/python/python3_3.4.3.bb | 5 +---- meta/recipes-devtools/python/python_2.7.9.bb | 5 -----2 files changed, 1 insertion(+), 9 deletions(-)meta/recipes-devtools/python/python3_3.4.3.bb +0
-0@@ -56,10 +56,7 @@ CACHED_CONFIGUREVARS = "ac_cv_have_chflags=no \ ac_cv_file__dev_ptmx=yes \ ac_cv_file__dev_ptc=no \"
meta/recipes-devtools/python/python3_3.4.3.bb CACHED_CONFIGUREVARS = "ac_cv_have_chflags=no \
Quoted 4 lines
meta/recipes-devtools/python/python3_3.4.3.bb +0
-4-# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :( -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__" -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__”
this is OK although, it would be interesting to know if you build any modules that used ctypes.so even if it did work it seems wrong to pass this flag atleast it should check for callconvention=hard
Quoted 29 lines
+
TARGET_CC_ARCH+= "-DNDEBUG -fno-inline"EXTRA_OEMAKE+= "CROSS_COMPILE=yes"EXTRA_OECONF+= "CROSSPYTHONPATH=${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/ --without-ensurepip"meta/recipes-devtools/python/python_2.7.9.bb +0
-0@@ -34,11 +34,6 @@ inherit autotools multilib_header python-dir pythonnativeCONFIGUREOPTS += " --with-system-ffi "
meta/recipes-devtools/python/python_2.7.9.bb +0
-5-# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :( -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__" -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__" -# The following is a hack until we drop
ac_cv_sizeof_off_tfrom site filesEXTRA_OECONF+= "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', 'ac_cv_sizeof_off_t=8', '', d)} ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"--
1.9.1--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 13 lines · Khem Raj
Quoted 13 lines · Andre McCurdy
Remove obsolete hack which seems to date back to (at least) 2009. It's potentially harmful as python
TARGET_CC_ARCHflags can leak through to other packages via the sysroot_sysconfigdata.py.Signed-off-by Andre McCurdy <[email protected]>---
meta/recipes-devtools/python/python3_3.4.3.bb | 5 +---- meta/recipes-devtools/python/python_2.7.9.bb | 5 -----2 files changed, 1 insertion(+), 9 deletions(-)
Quoted 14 lines
meta/recipes-devtools/python/python3_3.4.3.bb CACHED_CONFIGUREVARS = "ac_cv_have_chflags=no \
Quoted 12 lines
meta/recipes-devtools/python/python3_3.4.3.bb +0
-0@@ -56,10 +56,7 @@ CACHED_CONFIGUREVARS = "ac_cv_have_chflags=no \ ac_cv_file__dev_ptmx=yes \ ac_cv_file__dev_ptc=no \"
meta/recipes-devtools/python/python3_3.4.3.bb +0
-4-# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :( -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__" -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__”this is OK although, it would be interesting to know if you build any modules that used ctypes.so
-D__SOFTFP__ shows up unexpectedly on the gcc command line when building gpsd from meta-oe.
Quoted 32 lines
even if it did work it seems wrong to pass this flag atleast it should check for callconvention=hard
Quoted 29 lines
+
TARGET_CC_ARCH+= "-DNDEBUG -fno-inline"EXTRA_OEMAKE+= "CROSS_COMPILE=yes"EXTRA_OECONF+= "CROSSPYTHONPATH=${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/ --without-ensurepip"meta/recipes-devtools/python/python_2.7.9.bb +0
-0@@ -34,11 +34,6 @@ inherit autotools multilib_header python-dir pythonnativeCONFIGUREOPTS += " --with-system-ffi "
meta/recipes-devtools/python/python_2.7.9.bb +0
-5-# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :( -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__" -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__" -# The following is a hack until we drop
ac_cv_sizeof_off_tfrom site filesEXTRA_OECONF+= "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', 'ac_cv_sizeof_off_t=8', '', d)} ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"--
1.9.1--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core