Skip to contentSkip to conversation

Drivers: hv: vss: run only on supported host versions

PATCH New Olaf Hering 1 participant 1 message Oct 20, 2015 Hyper-V/Azure core and drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Drivers: hv: vss: run only on supported host versions

The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an empty icframe_vercnt/icmsg_vercnt. But the host ignores that and continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird errors during boot and general misbehaviour.

Check the Windows version to work around the host bug, skip hv_vss_init on WS2012 and older.

---

v2: use if < WS2012R2 instead of switch() as suggested by Vitaly.

 drivers/hv/hv_snapshot.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/hv/hv_snapshot.c +5 -0
index a548ae4..81882d4 100644
@@ -331,6 +331,11 @@ static void vss_on_reset(void)
 int
 hv_vss_init(struct hv_util_service *srv)
 {
+	if (vmbus_proto_version < VERSION_WIN8_1) {
+		pr_warn("Integration service 'Backup (volume snapshot)'"
+			" not supported on this host version.\n");
+		return -ENOTSUPP;
+	}
 	recv_buffer = srv->recv_buffer;
 
 	/*