Skip to contentSkip to conversation

Git-p4 fails with NameError with python 2.7.2

PATCH In review Etienne Girard 6 participants 10 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

Hello,

Git-p4 fail when I try to rebase with the error: "NameError: global name 'ctypes' is not defined". The error occurs when I use python 2.7.2 that is installed by default on my company's computers (it goes without saying that everything works fine with python 2.7.10).

I'm a beginner in python, but simply importing ctypes at the beginning of the script does the trick. I was wondering if submitting a patch for this issue is worth the trouble, when a satisfying solution is not using a 4 years old version of python.

Best regards

#1 lore raw
Quoted 11 lines · Etienne Girard

Hello,

Git-p4 fail when I try to rebase with the error: "NameError: global name 'ctypes' is not defined". The error occurs when I use python 2.7.2 that is installed by default on my company's computers (it goes without saying that everything works fine with python 2.7.10).

I'm a beginner in python, but simply importing ctypes at the beginning of the script does the trick. I was wondering if submitting a patch for this issue is worth the trouble, when a satisfying solution is not using a 4 years old version of python.

If you're able to submit a patch that would be great!

Thanks,
Luke

#2 lore raw
Quoted 8 lines · Luke Diamand
Quoted 7 lines · Etienne Girard

Hello,

Git-p4 fail when I try to rebase with the error: "NameError: global name 'ctypes' is not defined". The error occurs when I use python 2.7.2 that is installed by default on my company's computers (it goes without saying that everything works fine with python 2.7.10).

Quoted 6 lines
Quoted 4 lines

I'm a beginner in python, but simply importing ctypes at the beginning of the script does the trick. I was wondering if submitting a patch for this issue is worth the trouble, when a satisfying solution is not using a 4 years old version of python.

If you're able to submit a patch that would be great!

Lars's 4d25dc44 (git-p4: check free space during streaming, 2015-09-26) introduced two references to ctypes.* and there is no 'import ctypes' anywhere in the script.

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

#3 lore raw
Quoted 18 lines · Junio C Hamano
Quoted 8 lines · Luke Diamand
Quoted 7 lines · Etienne Girard

Hello,

Git-p4 fail when I try to rebase with the error: "NameError: global name 'ctypes' is not defined". The error occurs when I use python 2.7.2 that is installed by default on my company's computers (it goes without saying that everything works fine with python 2.7.10).

Quoted 6 lines
Quoted 4 lines

I'm a beginner in python, but simply importing ctypes at the beginning of the script does the trick. I was wondering if submitting a patch for this issue is worth the trouble, when a satisfying solution is not using a 4 years old version of python.

If you're able to submit a patch that would be great!

Quoted 7 lines

Lars's 4d25dc44 (git-p4: check free space during streaming, 2015-09-26) introduced two references to ctypes.* and there is no 'import ctypes' anywhere in the script.

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"?

No.
You need to import the ctypes module.

However in Python it is possible to "inject" the ctypes module (and any other name) in the builtin namespace.
The builtin module contains names that are accessible without importing them:
https://docs.python.org/2/library/__builtin__.html

IMHO, some code is messing with the __builtin__ module.

Running pyflakes on git-p4.py code I get:
git-p4.py:26: 'zlib' imported but unused
git-p4.py:640: local variable 'v' is assigned to but never used git-p4.py:2114: local variable 'rhs_index' is assigned to but never used

Running pylint I get a **lot** of warning and style issues; and the following errors:
E:112,21: Undefined variable 'ctypes' (undefined-variable) E:113, 8: Undefined variable 'ctypes' (undefined-variable) E:113,51: Undefined variable 'ctypes' (undefined-variable) E:113,94: Undefined variable 'ctypes' (undefined-variable) E:1002,51: No value for argument 'contentFile' in method call (no-value-for-parameter)

pyflakes is not reporting an error for ctypes.
Whatever the cause, the code must be fixed to import the ctypes module.

P.S.:
Sorry for the double message.
The first message contained an HTML part and was rejected by vger.kernel.org.

Regards Manlio

#4 lore raw

PATCH 1/1 git-p4: import the ctypes module

In reply to Junio C Hamano

The ctypes module is used on windows to calculate free disk space, so it must be imported.

---
 git-p4.py | 1 +
 1 file changed, 1 insertion(+)
Quoted 27 lines · Junio C Hamano
Quoted 19 lines · Luke Diamand
Quoted 9 lines · Etienne Girard

Hello,

Git-p4 fail when I try to rebase with the error: "NameError:
global
name 'ctypes' is not defined". The error occurs when I use python 2.7.2 that is installed by default on my company's computers (it goes
without saying that everything works fine with python 2.7.10).

Quoted 7 lines

I'm a beginner in python, but simply importing ctypes at the beginning
of the script does the trick. I was wondering if submitting a patch
for this issue is worth the trouble, when a satisfying solution is not
using a 4 years old version of python.

Quoted 1 line

If you're able to submit a patch that would be great!

Lars's (git-p4: check free space during streaming, 2015-09-26) introduced two references to ctypes.* and there is no 'import ctypes' anywhere in the script.

Quoted 5 lines

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

No, you cannot do that. The reason others may not have noticed this bug is that in git-p4.py, ctypes is only used on windows.

111 if platform.system() == 'Windows':
112 free_bytes = ctypes.c_ulonglong(0)
113 ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))

The fact that it works for the OP with 2.7.10 is puzzling (assuming that it's on the same system). But this patch should help.

git-p4.py +1 -0
index daa60c6..212ef2b 100755
@@ -24,6 +24,7 @@ import shutil
 import stat
 import zipfile
 import zlib
+import ctypes
 
 try:
     from subprocess import CalledProcessError
Signature · 1 line
2.6.2-323-g60bd420
#5 lore raw

Re: [PATCH] git-p4: import the ctypes module

Quoted 9 lines · Dennis Kaarsemaker
Quoted 5 lines

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

No, you cannot do that. The reason others may not have noticed this bug is that in git-p4.py, ctypes is only used on windows.

Quoted 6 lines

111 if platform.system() == 'Windows':
112 free_bytes = ctypes.c_ulonglong(0)
113 ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))

The fact that it works for the OP with 2.7.10 is puzzling (assuming that it's on the same system).

Exactly. That is where my "I am puzzled" comes from.

The patch looks obviously the right thing to do. Luke? Lars?

Quoted 13 lines
git-p4.py +1 -0
index daa60c6..212ef2b 100755
@@ -24,6 +24,7 @@ import shutil
 import stat
 import zipfile
 import zlib
+import ctypes
 
 try:
     from subprocess import CalledProcessError
#6 lore raw

Re: [PATCH] git-p4: import the ctypes module

Quoted 15 lines · Junio C Hamano
Quoted 13 lines · Dennis Kaarsemaker
Quoted 5 lines

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

No, you cannot do that. The reason others may not have noticed this bug is that in git-p4.py, ctypes is only used on windows.

111 if platform.system() == 'Windows':
112 free_bytes = ctypes.c_ulonglong(0)
113 ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))

Quoted 6 lines
Quoted 2 lines

The fact that it works for the OP with 2.7.10 is puzzling (assuming that it's on the same system).

Exactly. That is where my "I am puzzled" comes from.

The patch looks obviously the right thing to do. Luke? Lars?

It looks sensible to me, and works fine on Linux, thanks. ack.

I can't test on Windows today but I can't see why it wouldn't work.

Luke

#7 lore raw

Re: [PATCH] git-p4: import the ctypes module

Hello,

I couldn't work further on this yesterday (but I read Documentation/SubmittingPatches, which is a good start I guess). The diff proposed by Dennis works on my machine, I'll try to figure out why the original script worked with 2.7.10.

Thanks

2015-10-21 1:00 GMT+02:00 Luke Diamand <[email protected]>:

Quoted 38 lines · Junio C Hamano
Quoted 20 lines
Quoted 17 lines · Dennis Kaarsemaker
Quoted 5 lines

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

No, you cannot do that. The reason others may not have noticed this bug is that
in git-p4.py, ctypes is only used on windows.

111 if platform.system() == 'Windows':
112 free_bytes = ctypes.c_ulonglong(0)
113
ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))

Quoted 8 lines
Quoted 3 lines

The fact that it works for the OP with 2.7.10 is puzzling (assuming that it's
on the same system).

Exactly. That is where my "I am puzzled" comes from.

The patch looks obviously the right thing to do. Luke? Lars?

It looks sensible to me, and works fine on Linux, thanks. ack.

I can't test on Windows today but I can't see why it wouldn't work.

Luke

#8 lore raw

Re: [PATCH] git-p4: import the ctypes module

I was wrong, the script doesn't work on my machine if ctypes is not imported regardless of python version. I guess I was confused by using a version of git-p4 before ctypes was introduced, the failing version and the patched version, as well as several python versions.

Sorry for this misleading claim, and thanks for the quick fix.

2015-10-21 10:23 GMT+02:00 Etienne Girard <[email protected]>:

Quoted 48 lines

Hello,

I couldn't work further on this yesterday (but I read Documentation/SubmittingPatches, which is a good start I guess). The diff proposed by Dennis works on my machine, I'll try to figure out why the original script worked with 2.7.10.

Thanks

2015-10-21 1:00 GMT+02:00 Luke Diamand <[email protected]>:

Quoted 38 lines · Junio C Hamano
Quoted 20 lines
Quoted 17 lines · Dennis Kaarsemaker
Quoted 5 lines

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

No, you cannot do that. The reason others may not have noticed this bug is that
in git-p4.py, ctypes is only used on windows.

111 if platform.system() == 'Windows':
112 free_bytes = ctypes.c_ulonglong(0)
113
ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))

Quoted 8 lines
Quoted 3 lines

The fact that it works for the OP with 2.7.10 is puzzling (assuming that it's
on the same system).

Exactly. That is where my "I am puzzled" comes from.

The patch looks obviously the right thing to do. Luke? Lars?

It looks sensible to me, and works fine on Linux, thanks. ack.

I can't test on Windows today but I can't see why it wouldn't work.

Luke

#9 lore raw

Re: [PATCH] git-p4: import the ctypes module

In reply to Etienne Girard

Hi Etienne,

thanks for reporting this! Junio is right, I messed that up on my Windows testing box! :-( Sorry!
If you have any questions around submitting patches I am happy to help as I just recently went through the learning process myself!

@Dennis: Thanks for the quick patch!

Thanks,
Lars

Quoted 48 lines · Etienne Girard

Hello,

I couldn't work further on this yesterday (but I read Documentation/SubmittingPatches, which is a good start I guess). The diff proposed by Dennis works on my machine, I'll try to figure out why the original script worked with 2.7.10.

Thanks

2015-10-21 1:00 GMT+02:00 Luke Diamand <[email protected]>:

Quoted 38 lines · Junio C Hamano
Quoted 20 lines
Quoted 17 lines · Dennis Kaarsemaker
Quoted 5 lines

I do not follow Python development, but does the above mean that with recent 2.x you can say ctypes without first saying "import ctypes"? It feels somewhat non-pythonesque that identifiers like this is given to you without you asking with an explicit 'import', so I am puzzled.

No, you cannot do that. The reason others may not have noticed this bug is that
in git-p4.py, ctypes is only used on windows.

111 if platform.system() == 'Windows':
112 free_bytes = ctypes.c_ulonglong(0)
113
ctypes.windll.kernel32.GetDiskFreeSpaceExW(ctypes.c_wchar_p(os.getcwd()), None, None, ctypes.pointer(free_bytes))

Quoted 8 lines
Quoted 3 lines

The fact that it works for the OP with 2.7.10 is puzzling (assuming that it's
on the same system).

Exactly. That is where my "I am puzzled" comes from.

The patch looks obviously the right thing to do. Luke? Lars?

It looks sensible to me, and works fine on Linux, thanks. ack.

I can't test on Windows today but I can't see why it wouldn't work.

Luke