Skip to contentSkip to conversation

serial: msm_serial: Make config tristate

PATCH In review Stephen Boyd 3 participants 3 messages Oct 21, 2015 – Oct 22, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: msm_serial: Make config tristate

This driver works as a module, so mark it as a tristate config instead of a bool.

Cc Paul Gortmaker <[email protected]>

---

I tested this with a busybox ramdisk that modprobes msm_serial and then runs a getty on ttyMSM0. This patch should supersede Paul's earlier patch that removes the module code from this driver.

 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
index 1aec4404062d..e4f35da3de27 100644
@@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
 	  say Y or M.  Otherwise, say N.
 
 config SERIAL_MSM
-	bool "MSM on-chip serial port support"
+	tristate "MSM on-chip serial port support"
 	depends on ARCH_QCOM
 	select SERIAL_CORE
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Stephen Boyd

This driver works as a module, so mark it as a tristate config instead of a bool.

Cc Paul Gortmaker <[email protected]>
Quoted 8 lines

---

I tested this with a busybox ramdisk that modprobes msm_serial and then runs a getty on ttyMSM0. This patch should supersede Paul's earlier patch that removes the module code from this driver.

 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw
In reply to Stephen Boyd
Quoted 10 lines · [[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05)…

This driver works as a module, so mark it as a tristate config instead of a bool.

Cc Paul Gortmaker <[email protected]>

---

I tested this with a busybox ramdisk that modprobes msm_serial and then runs a getty on ttyMSM0. This patch should supersede Paul's earlier patch that removes the module code from this driver.

Thanks, I'll drop my patch for this driver.

Paul.
--

Quoted 21 lines
 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
index 1aec4404062d..e4f35da3de27 100644
@@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
 	  say Y or M.  Otherwise, say N.
 
 config SERIAL_MSM
-	bool "MSM on-chip serial port support"
+	tristate "MSM on-chip serial port support"
 	depends on ARCH_QCOM
 	select SERIAL_CORE
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project