Skip to contentSkip to conversation

net: wireless: ath: Remove unneeded variable ret returning 0

PATCH Superseded Punit Vara 2 participants 3 messages Oct 22, 2015

Subsystems (3)
Networking Network drivers Atheros ATH5K wireless driver

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Punit Vara

author
#0 lore raw

PATCH v3 14/15 net: wireless: ath: Remove unneeded variable ret returning 0

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck:

-Unneeded variable: "ret". Return "0" on line 1733

Remove unneccesary variable ret created to return zero.

Also removed empty line suggested by Sergei

Signed-off-by Punit Vara <[email protected]>
---
 drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath5k/eeprom.c +2 -3
index 94d34ee..0c82ea5 100644
@@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
 	struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
 	u32 offset;
 	u16 val;
-	int ret = 0, i;
-
+	int i;
 	offset = AR5K_EEPROM_CTL(ee->ee_version) +
 				AR5K_EEPROM_N_CTLS(ee->ee_version);
 

@@ -1730,7 +1729,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
 		}
 	}
 
-	return ret;
+	return 0;
 }
Signature · 1 line
2.5.3
#1 lore raw

Hello.

Quoted 19 lines · Punit Vara

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck:

-Unneeded variable: "ret". Return "0" on line 1733

Remove unneccesary variable ret created to return zero.

Also removed empty line suggested by Sergei

Signed-off-by Punit Vara <[email protected]>
---
  drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath5k/eeprom.c +0 -0
index 94d34ee..0c82ea5 100644

drivers/net/wireless/ath/ath5k/eeprom.c ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) · line 1711

Quoted 5 lines
drivers/net/wireless/ath/ath5k/eeprom.c +0 -2
@@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
  	struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
  	u32 offset;
  	u16 val;
-	int ret = 0, i;
-

No, this one shouldn't have been removed. There should an empty line
between the declarations and the statements.

drivers/net/wireless/ath/ath5k/eeprom.c ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) · line 1713

Quoted 4 lines
drivers/net/wireless/ath/ath5k/eeprom.c +1 -0
+	int i;
  	offset = AR5K_EEPROM_CTL(ee->ee_version) +
  				AR5K_EEPROM_N_CTLS(ee->ee_version);

MBR, Sergei

author
#2 lore raw
Quoted 34 lines · Sergei Shtylyov

Hello.

Quoted 20 lines · Punit Vara

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck:

-Unneeded variable: "ret". Return "0" on line 1733

Remove unneccesary variable ret created to return zero.

Also removed empty line suggested by Sergei

Signed-off-by Punit Vara <[email protected]>
---
  drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath5k/eeprom.c +0 -0
index 94d34ee..0c82ea5 100644

drivers/net/wireless/ath/ath5k/eeprom.c ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) · line 1711

Quoted 5 lines
drivers/net/wireless/ath/ath5k/eeprom.c +0 -2
@@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
        struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
        u32 offset;
        u16 val;
-       int ret = 0, i;
-

No, this one shouldn't have been removed. There should an empty line
between the declarations and the statements.

Quoted 7 lines

drivers/net/wireless/ath/ath5k/eeprom.c ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) · line 1713

Quoted 4 lines
drivers/net/wireless/ath/ath5k/eeprom.c +1 -0
+       int i;
        offset = AR5K_EEPROM_CTL(ee->ee_version) +
                                AR5K_EEPROM_N_CTLS(ee->ee_version);

MBR, Sergei

I have resent patch with update but I cant see it in my mailbox I dont know Why.. Sorry if You are getting mail more time. I am sending final version v5 as last.Please sorry for inconvenience