Skip to contentSkip to conversation

net: encx24j600: Fix mask to update LED configuration

PATCH Applied [email protected] 2 participants 2 messages Oct 22, 2015 – Oct 26, 2015

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 net: encx24j600: Fix mask to update LED configuration

From: Jon Ringle <[email protected]>

This fixes the mask used to update the LED configuration so that it clears the necessary bits as well as setting the bits according to the mask. Also reverse the LED configuration to show the Link state + collisions in LEDA and the Link state + TX/RX events in LEDB.

Signed-off-by Jon Ringle <[email protected]>
---
 drivers/net/ethernet/microchip/encx24j600.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/microchip/encx24j600.c +3 -3
index e1329d9..bf08ce2 100644
@@ -617,10 +617,10 @@ static int encx24j600_hw_init(struct encx24j600_priv *priv)
 		   (eidled & REVID_MASK) >> REVID_SHIFT);
 
 	/* PHY Leds: link status,
-	 * LEDA: Link + transmit/receive events
-	 * LEDB: Link State + colision events
+	 * LEDA: Link State + collision events
+	 * LEDB: Link State + transmit/receive events
 	 */
-	encx24j600_update_reg(priv, EIDLED, 0xbc00, 0xbc00);
+	encx24j600_update_reg(priv, EIDLED, 0xff00, 0xcb00);
 
 	/* Loopback disabled */
 	encx24j600_write_reg(priv, MACON1, 0x9);
Signature · 1 line
2.4.1
maintainer Applied
#1 lore raw

From: [email protected]
Date: Thu, 22 Oct 2015 15:09:04 -0400

Quoted 8 lines

From: Jon Ringle <[email protected]>

This fixes the mask used to update the LED configuration so that it clears the necessary bits as well as setting the bits according to the mask. Also reverse the LED configuration to show the Link state + collisions in LEDA and the Link state + TX/RX events in LEDB.

Signed-off-by Jon Ringle <[email protected]>

Applied, thanks.