Skip to contentSkip to conversation

i40e:Fix variable assignment in the function i40e_set_ringparam

PATCH New Nicholas Krause 1 participant 1 message Oct 23, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e:Fix variable assignment in the function i40e_set_ringparam

This fixes variable assignment in the function i40e_set_ringparam to properly assign the internal variable to the return value of the call to the function i40e_up to properly allow us to signal the caller when a error has occurred when trying to bring up the device rather then assume incorrectly that it always succeeds for this particular call in the function i40e_set_ringparm.

---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +1 -1
index e972b5e..13ef808 100644
@@ -1233,7 +1233,7 @@ static int i40e_set_ringparam(struct net_device *netdev,
 		rx_rings = NULL;
 	}
 
-	i40e_up(vsi);
+	err = i40e_up(vsi);
 
 free_tx:
 	/* error cleanup if the Rx allocations failed after getting Tx */
Signature · 1 line
2.1.4