Skip to contentSkip to conversation

imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1

PATCH Applied Eric Nelson 2 participants 3 messages Oct 23, 2015 – Oct 26, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx6-mmdc: restore RALAT/WALAT in MMDC0, not MMDC1

---
 arch/arm/mach-imx/imx6-mmdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/imx6-mmdc.c +1 -1
index 40fe0cf..7840c1a 100644
@@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
 	writel(v, P0_IPS + MAPSR);
 
 	/* restore MDMISC value (RALAT, WALAT) */
-	writel(esdmisc_val, P1_IPS + MDMISC);
+	writel(esdmisc_val, P0_IPS + MDMISC);
 
 	/* clear DQS pull ups */
 	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
Signature · 7 lines
2.6.2


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
maintainer Applied
#1 lore raw
Quoted 4 lines · Eric Nelson
---
 arch/arm/mach-imx/imx6-mmdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

Quoted 18 lines
arch/arm/mach-imx/imx6-mmdc.c +1 -1
index 40fe0cf..7840c1a 100644
@@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
 	writel(v, P0_IPS + MAPSR);
 
 	/* restore MDMISC value (RALAT, WALAT) */
-	writel(esdmisc_val, P1_IPS + MDMISC);
+	writel(esdmisc_val, P0_IPS + MDMISC);
 
 	/* clear DQS pull ups */
 	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
Signature · 1 line
2.6.2
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

Hi Sascha,

Quoted 22 lines · Sascha Hauer
Quoted 4 lines · Eric Nelson
---
 arch/arm/mach-imx/imx6-mmdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

Quoted 12 lines
arch/arm/mach-imx/imx6-mmdc.c +1 -1
index 40fe0cf..7840c1a 100644
@@ -474,7 +474,7 @@ int mmdc_do_dqs_calibration(void)
 	writel(v, P0_IPS + MAPSR);
 
 	/* restore MDMISC value (RALAT, WALAT) */
-	writel(esdmisc_val, P1_IPS + MDMISC);
+	writel(esdmisc_val, P0_IPS + MDMISC);
 
Quoted 7 lines
Quoted 6 lines
arch/arm/mach-imx/imx6-mmdc.c +0 -0
 	/* clear DQS pull ups */
 	v = readl(IOMUXC_SW_PAD_CTL_PAD_DRAM_SDQS0) & ~0x7000;
Signature · 1 line
2.6.2

Note that this typo should have had an impact on performance because RALAT and WALAT for MMDC0 would be left at their max values.

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox