ARM: dts: Add Altera L2 Cache and OCRAM EDAC entries
PATCH v7 1/3 ARM: dts: Add Altera L2 Cache and OCRAM EDAC entries
From: Thor Thayer <[email protected]>
Adding the device tree entries and bindings needed to support the Altera L2 cache and On-Chip RAM EDAC. This patch relies upon an earlier patch to declare and setup On-chip RAM properly.
http://www.spinics.net/lists/devicetree/msg51117.html
---
v7: No Change
v6: Change to nested EDAC device nodes based on community
feedback. Remove L2 syscon. Use consolidated binding.
v3-5: No Change
v2: Remove OCRAM declaration and reference prior patch.
--- .../bindings/arm/altera/socfpga-edac.txt | 46 ++++++++++++++++++++++ arch/arm/boot/dts/socfpga.dtsi | 20 ++++++++++ 2 files changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +46 -0
@@ -0,0 +1,46 @@ +Altera SoCFPGA Error Detection and Correction [EDAC] + +Required Properties: +- compatible : Should be "altr,edac" +- #address-cells: must be 1 +- #size-cells: must be 1 +- ranges : standard definition, should translate from local addresses + +Subcomponents: + +L2 Cache ECC +Required Properties: +- compatible : Should be "altr,l2-edac" +- reg : Address and size for ECC error interrupt clear registers. +- interrupts : Should be single bit error interrupt, then double bit error + interrupt. Note the rising edge type. + +On Chip RAM ECC +Required Properties: +- compatible : Should be "altr,ocram-edac" +- reg : Address and size for ECC error interrupt clear registers. +- iram : phandle to On-Chip RAM definition. +- interrupts : Should be single bit error interrupt, then double bit error + interrupt. Note the rising edge type. + +Example: + + soc_ecc { + compatible = "altr,edac"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + l2edac at ffd08140 { + compatible = "altr,l2-edac"; + reg = <0xffd08140 0x4>; + interrupts = <0 36 1>, <0 37 1>; + }; + + ocramedac at ffd08144 { + compatible = "altr,ocram-edac"; + reg = <0xffd08144 0x4>; + iram = <&ocram>; + interrupts = <0 178 1>, <0 179 1>; + }; + };
arch/arm/boot/dts/socfpga.dtsi +20 -0
@@ -660,6 +660,26 @@ interrupts = <0 39 4>; }; + soc_ecc { + compatible = "altr,edac"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + l2edac at ffd08140 { + compatible = "altr,l2-edac"; + reg = <0xffd08140 0x4>; + interrupts = <0 36 1>, <0 37 1>; + }; + + ocramedac at ffd08144 { + compatible = "altr,ocram-edac"; + reg = <0xffd08144 0x4>; + iram = <&ocram>; + interrupts = <0 178 1>, <0 179 1>; + }; + }; + L2: l2-cache at fffef000 { compatible = "arm,pl310-cache"; reg = <0xfffef000 0x1000>;
Signature · 1 line
2.4.5
Rob Herring
maintainerPATCH v7 1/3 ARM: dts: Add Altera L2 Cache and OCRAM EDAC entries
Quoted 27 lines · dinguyen at opensource.altera.com
From: Thor Thayer <[email protected]>
Adding the device tree entries and bindings needed to support the Altera L2 cache and On-Chip RAM EDAC. This patch relies upon an earlier patch to declare and setup On-chip RAM properly.
http://www.spinics.net/lists/devicetree/msg51117.htmlSigned-off-by Thor Thayer <[email protected]>Signed-off-by Dinh Nguyen <[email protected]>---
v7: No Change
v6: Change to nested EDAC device nodes based on community
feedback. Remove L2 syscon. Use consolidated binding.
v3-5: No Change
v2: Remove OCRAM declaration and reference prior patch.--- .../bindings/arm/altera/socfpga-edac.txt | 46 ++++++++++++++++++++++ arch/arm/boot/dts/socfpga.dtsi | 20 ++++++++++ 2 files changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-edac.txtDocumentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +0
-0
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 4
Quoted 4 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +4
-0@@ -0,0 +1,46 @@ +Altera SoCFPGA Error Detection and Correction [EDAC] + +Required Properties: +- compatible : Should be "altr,edac"
What is the actual block name? I doubt it happens to match the kernel subsystem.
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 7
Quoted 3 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +3
-0+- #address-cells: must be 1 +- #size-cells: must be 1 +- ranges : standard definition, should translate from local addresses
What is the point of having 2 levels? I think you can remove it.
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 13
Quoted 6 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +6
-0+ +Subcomponents: + +L2 Cache ECC +Required Properties: +- compatible : Should be "altr,l2-edac"
Same comment about name. It should also have the chip name in it.
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 20
Quoted 7 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +7
-0+- reg : Address and size for ECC error interrupt clear registers. +- interrupts : Should be single bit error interrupt, then double bit error + interrupt. Note the rising edge type. + +On Chip RAM ECC +Required Properties: +- compatible : Should be "altr,ocram-edac"
Ditto.
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 22
Quoted 2 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +2
-0+- reg : Address and size for ECC error interrupt clear registers. +- iram : phandle to On-Chip RAM definition.
This should probably be standardized and put into the SRAM binding. There's 2 cases to consider: phandle to all of SRAM and phandle to sub-node of SRAM.
Quoted 24 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +24
-0+- interrupts : Should be single bit error interrupt, then double bit error + interrupt. Note the rising edge type. + +Example: + + soc_ecc { + compatible = "altr,edac"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + l2edac at ffd08140 { + compatible = "altr,l2-edac"; + reg = <0xffd08140 0x4>; + interrupts = <0 36 1>, <0 37 1>; + }; + + ocramedac at ffd08144 { + compatible = "altr,ocram-edac"; + reg = <0xffd08144 0x4>; + iram = <&ocram>; + interrupts = <0 178 1>, <0 179 1>; + }; + };
PATCH v7 1/3 ARM: dts: Add Altera L2 Cache and OCRAM EDAC entries
Hi Rob.
Quoted 22 lines · Rob Herring
Quoted 21 lines · dinguyen at opensource.altera.com
From: Thor Thayer <[email protected]>
Adding the device tree entries and bindings needed to support the Altera L2 cache and On-Chip RAM EDAC. This patch relies upon an earlier patch to declare and setup On-chip RAM properly.
http://www.spinics.net/lists/devicetree/msg51117.htmlSigned-off-by Thor Thayer <[email protected]>Signed-off-by Dinh Nguyen <[email protected]>---
v7: No Change
v6: Change to nested EDAC device nodes based on community
feedback. Remove L2 syscon. Use consolidated binding.
v3-5: No Change
v2: Remove OCRAM declaration and reference prior patch.--- .../bindings/arm/altera/socfpga-edac.txt | 46 ++++++++++++++++++++++ arch/arm/boot/dts/socfpga.dtsi | 20 ++++++++++ 2 files changed, 66 insertions(+)create mode 100644
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt
Quoted 14 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 4
Quoted 10 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +4
-0@@ -0,0 +1,46 @@ +Altera SoCFPGA Error Detection and Correction [EDAC] + +Required Properties: +- compatible : Should be "altr,edac"What is the actual block name? I doubt it happens to match the kernel subsystem.
OK. I'll rename to altr,socfpga-ecc-manager
Quoted 6 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 7
Quoted 3 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +3
-0+- #address-cells: must be 1 +- #size-cells: must be 1 +- ranges : standard definition, should translate from local addressesWhat is the point of having 2 levels? I think you can remove it.
The L2 cache ECC and On-Chip RAM ECC are contiguous registers in the ecc-manager block. I may not understand your question but it seems like 2 levels is correct in that case.
Quoted 9 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 13
Quoted 6 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +6
-0+ +Subcomponents: + +L2 Cache ECC +Required Properties: +- compatible : Should be "altr,l2-edac"Same comment about name. It should also have the chip name in it.
OK. I will add socfpga to all of the compatible fields.
Quoted 10 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 20
Quoted 7 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +7
-0+- reg : Address and size for ECC error interrupt clear registers. +- interrupts : Should be single bit error interrupt, then double bit error + interrupt. Note the rising edge type. + +On Chip RAM ECC +Required Properties: +- compatible : Should be "altr,ocram-edac"Ditto.
Quoted 7 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt line 22
Quoted 2 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +2
-0+- reg : Address and size for ECC error interrupt clear registers. +- iram : phandle to On-Chip RAM definition.This should probably be standardized and put into the SRAM binding. There's 2 cases to consider: phandle to all of SRAM and phandle to sub-node of SRAM.
OK. We are currently allocating all our On-Chip RAM (SRAM) to the pool so I think the phandle to all of SRAM is fine, right?
Thank you for reviewing.
Thor
Quoted 24 lines
Quoted 24 lines
Documentation/devicetree/bindings/arm/altera/socfpga-edac.txt new file +24
-0+- interrupts : Should be single bit error interrupt, then double bit error + interrupt. Note the rising edge type. + +Example: + + soc_ecc { + compatible = "altr,edac"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + l2edac at ffd08140 { + compatible = "altr,l2-edac"; + reg = <0xffd08140 0x4>; + interrupts = <0 36 1>, <0 37 1>; + }; + + ocramedac at ffd08144 { + compatible = "altr,ocram-edac"; + reg = <0xffd08144 0x4>; + iram = <&ocram>; + interrupts = <0 178 1>, <0 179 1>; + }; + };