Add SPI to platform_no_drv_owner.cocci warnings
Subsystems (2)
PATCH 1/1 Add SPI to platform_no_drv_owner.cocci warnings
Remove .owner field if calls are used which set it automatically
Signed-off-by Andrew F. Davis <[email protected]>
--- scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++ 1 file changed, 73 insertions(+)
scripts/coccinelle/api/platform_no_drv_owner.cocci +73 -0
@@ -12,6 +12,7 @@ virtual report declarer name module_i2c_driver; declarer name module_platform_driver; declarer name module_platform_driver_probe; +declarer name module_spi_driver; identifier __driver; @@ (
@@ -20,6 +21,8 @@ identifier __driver; module_platform_driver(__driver); | module_platform_driver_probe(__driver, ...); +| + module_spi_driver(__driver); ) @fix1 depends on match1 && patch && !context && !org && !report@
@@ -40,6 +43,15 @@ identifier match1.__driver; } }; +@fix1_spi depends on match1 && patch && !context && !org && !report@ +identifier match1.__driver; +@@ + static struct spi_driver __driver = { + .driver = { +- .owner = THIS_MODULE, + } + }; + @match2@ identifier __driver; @@
@@ -51,6 +63,8 @@ identifier __driver; platform_create_bundle(&__driver, ...) | i2c_add_driver(&__driver) +| + spi_register_driver(&__driver) ) @fix2 depends on match2 && patch && !context && !org && !report@
@@ -71,6 +85,15 @@ identifier match2.__driver; } }; +@fix2_spi depends on match2 && patch && !context && !org && !report@ +identifier match2.__driver; +@@ + static struct spi_driver __driver = { + .driver = { +- .owner = THIS_MODULE, + } + }; + // ---------------------------------------------------------------------------- @fix1_context depends on match1 && !patch && (context || org || report)@
@@ -95,6 +118,17 @@ position j0; } }; +@fix1_spi_context depends on match1 && !patch && (context || org || report)@ +identifier match1.__driver; +position j0; +@@ + + static struct spi_driver __driver = { + .driver = { +* .owner@j0 = THIS_MODULE, + } + }; + @fix2_context depends on match2 && !patch && (context || org || report)@ identifier match2.__driver; position j0;
@@ -117,6 +151,17 @@ position j0; } }; +@fix2_spi_context depends on match2 && !patch && (context || org || report)@ +identifier match2.__driver; +position j0; +@@ + + static struct spi_driver __driver = { + .driver = { +* .owner@j0 = THIS_MODULE, + } + }; + // ---------------------------------------------------------------------------- @script:python fix1_org depends on org@
@@ -133,6 +178,13 @@ j0 << fix1_i2c_context.j0; msg = "No need to set .owner here. The core will do it." coccilib.org.print_todo(j0[0], msg) +@script:python fix1_spi_org depends on org@ +j0 << fix1_spi_context.j0; +@@ + +msg = "No need to set .owner here. The core will do it." +coccilib.org.print_todo(j0[0], msg) + @script:python fix2_org depends on org@ j0 << fix2_context.j0; @@
@@ -147,6 +199,13 @@ j0 << fix2_i2c_context.j0; msg = "No need to set .owner here. The core will do it." coccilib.org.print_todo(j0[0], msg) +@script:python fix2_spi_org depends on org@ +j0 << fix2_spi_context.j0; +@@ + +msg = "No need to set .owner here. The core will do it." +coccilib.org.print_todo(j0[0], msg) + // ---------------------------------------------------------------------------- @script:python fix1_report depends on report@
@@ -163,6 +222,13 @@ j0 << fix1_i2c_context.j0; msg = "No need to set .owner here. The core will do it." coccilib.report.print_report(j0[0], msg) +@script:python fix1_spi_report depends on report@ +j0 << fix1_spi_context.j0; +@@ + +msg = "No need to set .owner here. The core will do it." +coccilib.report.print_report(j0[0], msg) + @script:python fix2_report depends on report@ j0 << fix2_context.j0; @@
@@ -177,3 +243,10 @@ j0 << fix2_i2c_context.j0; msg = "No need to set .owner here. The core will do it." coccilib.report.print_report(j0[0], msg) +@script:python fix2_spi_report depends on report@ +j0 << fix2_spi_context.j0; +@@ + +msg = "No need to set .owner here. The core will do it." +coccilib.report.print_report(j0[0], msg) +
Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Brown
maintainerQuoted 5 lines · Andrew F. Davis
Remove .owner field if calls are used which set it automatically
Signed-off-by Andrew F. Davis <[email protected]>--- scripts/coccinelle/api/platform_no_drv_owner.cocci | 73 ++++++++++++++++++++++
You need to send this to whoever the maintainers for the coccinelle script are.