libxslt: CVE-2015-7995

PATCH In review Armin Kuster 3 participants 5 messages Oct 29, 2015 – Nov 6, 2015

lore

Share & tools

lore

Armin Kuster

author

2015-10-29 23:22 UTC #0 lore raw

PATCH 1/1 libxslt: CVE-2015-7995

From: Armin Kuster <[email protected]>

This is a is being give a High rating so please consider it for all 1.1.28 versions.

A type confusion error within the libxslt "xsltStylePreCompute()" function in preproc.c can lead to a DoS. Confirmed in version 1.1.28, other versions may also be affected.

Signed-off-by Armin Kuster <[email protected]>

---
 .../libxslt/libxslt/CVE-2015-7995.patch            | 33 ++++++++++++++++++++++
 meta/recipes-support/libxslt/libxslt_1.1.28.bb     |  3 +-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch

meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch new file +33 -0

new file mode 100644
index 0000000..e4d09c2
@@ -0,0 +1,33 @@
+From 7ca19df892ca22d9314e95d59ce2abdeff46b617 Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <[email protected]>
+Date: Thu, 29 Oct 2015 19:33:23 +0800
+Subject: Fix for type confusion in preprocessing attributes
+
+CVE-2015-7995 http://www.openwall.com/lists/oss-security/2015/10/27/10
+We need to check that the parent node is an element before dereferencing
+its namespace
+
+Upstream-Status: Backport
+
+https://git.gnome.org/browse/libxslt/commit/?id=7ca19df892ca22d9314e95d59ce2abdeff46b617
+
+Signed-off-by: Armin Kuster <[email protected]>
+
+---
+ libxslt/preproc.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+Index: libxslt-1.1.28/libxslt/preproc.c
+===================================================================
+--- libxslt-1.1.28.orig/libxslt/preproc.c
++++ libxslt-1.1.28/libxslt/preproc.c
+@@ -2245,7 +2245,8 @@ xsltStylePreCompute(xsltStylesheetPtr st
+ 	} else if (IS_XSLT_NAME(inst, "attribute")) {
+ 	    xmlNodePtr parent = inst->parent;
+ 
+-	    if ((parent == NULL) || (parent->ns == NULL) ||
++	    if ((parent == NULL) ||
++	        (parent->type != XML_ELEMENT_NODE) || (parent->ns == NULL) ||
+ 		((parent->ns != inst->ns) &&
+ 		 (!xmlStrEqual(parent->ns->href, inst->ns->href))) ||
+ 		(!xmlStrEqual(parent->name, BAD_CAST "attribute-set"))) {

meta/recipes-support/libxslt/libxslt_1.1.28.bb +2 -1

index 166bcd8..87fabec 100644
@@ -10,7 +10,8 @@ DEPENDS = "libxml2"
 
 SRC_URI = "ftp://xmlsoft.org/libxslt//libxslt-${PV}.tar.gz \
            file://pkgconfig_fix.patch \
-           file://pkgconfig.patch"
+           file://pkgconfig.patch \
+           file://CVE-2015-7995.patch"
 
 SRC_URI[md5sum] = "9667bf6f9310b957254fdcf6596600b7"
 SRC_URI[sha256sum] = "5fc7151a57b89c03d7b825df5a0fae0a8d5f05674c0e7cf2937ecec4d54a028c"

Signature · 1 line

2.3.5

akuster808

author

2015-11-05 20:29 UTC #1 lore raw

Ping.

- armin

Quoted 70 lines · Armin Kuster

From: Armin Kuster <[email protected]>

This is a is being give a High rating so please consider it for all 1.1.28 versions.

A type confusion error within the libxslt "xsltStylePreCompute()" function in preproc.c can lead to a DoS. Confirmed in version 1.1.28, other versions may also be affected.

Signed-off-by Armin Kuster <[email protected]>

---
 .../libxslt/libxslt/CVE-2015-7995.patch            | 33 ++++++++++++++++++++++
 meta/recipes-support/libxslt/libxslt_1.1.28.bb     |  3 +-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch

meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch new file +33 -0

new file mode 100644
index 0000000..e4d09c2
@@ -0,0 +1,33 @@
+From 7ca19df892ca22d9314e95d59ce2abdeff46b617 Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <[email protected]>
+Date: Thu, 29 Oct 2015 19:33:23 +0800
+Subject: Fix for type confusion in preprocessing attributes
+
+CVE-2015-7995 http://www.openwall.com/lists/oss-security/2015/10/27/10
+We need to check that the parent node is an element before dereferencing
+its namespace
+
+Upstream-Status: Backport
+
+https://git.gnome.org/browse/libxslt/commit/?id=7ca19df892ca22d9314e95d59ce2abdeff46b617
+
+Signed-off-by: Armin Kuster <[email protected]>
+
+---
+ libxslt/preproc.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+Index: libxslt-1.1.28/libxslt/preproc.c
+===================================================================
+--- libxslt-1.1.28.orig/libxslt/preproc.c
++++ libxslt-1.1.28/libxslt/preproc.c
+@@ -2245,7 +2245,8 @@ xsltStylePreCompute(xsltStylesheetPtr st
+ 	} else if (IS_XSLT_NAME(inst, "attribute")) {
+ 	    xmlNodePtr parent = inst->parent;
+ 
+-	    if ((parent == NULL) || (parent->ns == NULL) ||
++	    if ((parent == NULL) ||
++	        (parent->type != XML_ELEMENT_NODE) || (parent->ns == NULL) ||
+ 		((parent->ns != inst->ns) &&
+ 		 (!xmlStrEqual(parent->ns->href, inst->ns->href))) ||
+ 		(!xmlStrEqual(parent->name, BAD_CAST "attribute-set"))) {

meta/recipes-support/libxslt/libxslt_1.1.28.bb +2 -1

index 166bcd8..87fabec 100644
@@ -10,7 +10,8 @@ DEPENDS = "libxml2"
 
 SRC_URI = "ftp://xmlsoft.org/libxslt//libxslt-${PV}.tar.gz \
            file://pkgconfig_fix.patch \
-           file://pkgconfig.patch"
+           file://pkgconfig.patch \
+           file://CVE-2015-7995.patch"
 
 SRC_URI[md5sum] = "9667bf6f9310b957254fdcf6596600b7"
 SRC_URI[sha256sum] = "5fc7151a57b89c03d7b825df5a0fae0a8d5f05674c0e7cf2937ecec4d54a028c"

Burton, Ross

2015-11-05 20:31 UTC #2 lore raw

Quoted 2 lines · On 5 November 2015 at 20:29, akuster808 <[email protected]> wrote:

Ping.

Queued in mut, will be hitting the AB soon.

Ross

Joshua Lock

2015-11-05 22:01 UTC #3 lore raw

In reply to akuster808

Quoted 3 lines · On 05/11/15 20:29, akuster808 wrote:

Ping.
- armin

Hi Armin,

I've pushed this change to my joshuagl/fido-next branch of openembedded-core-contrib and am testing it now.

Thanks,

Joshua

1. http://cgit.openembedded.org/openembedded-core-contrib/log/?h=joshuagl/fido-next

Quoted 72 lines · Armin Kuster

Quoted 70 lines

From: Armin Kuster <[email protected]>

This is a is being give a High rating so please consider it for all 1.1.28 versions.

A type confusion error within the libxslt "xsltStylePreCompute()" function in preproc.c can lead to a DoS. Confirmed in version 1.1.28, other versions may also be affected.

Signed-off-by Armin Kuster <[email protected]>

---
  .../libxslt/libxslt/CVE-2015-7995.patch            | 33 ++++++++++++++++++++++
  meta/recipes-support/libxslt/libxslt_1.1.28.bb     |  3 +-
  2 files changed, 35 insertions(+), 1 deletion(-)

create mode 100644 meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch

meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch new file +33 -0

new file mode 100644
index 0000000..e4d09c2
@@ -0,0 +1,33 @@
+From 7ca19df892ca22d9314e95d59ce2abdeff46b617 Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <[email protected]>
+Date: Thu, 29 Oct 2015 19:33:23 +0800
+Subject: Fix for type confusion in preprocessing attributes
+
+CVE-2015-7995 http://www.openwall.com/lists/oss-security/2015/10/27/10
+We need to check that the parent node is an element before dereferencing
+its namespace
+
+Upstream-Status: Backport
+
+https://git.gnome.org/browse/libxslt/commit/?id=7ca19df892ca22d9314e95d59ce2abdeff46b617
+
+Signed-off-by: Armin Kuster <[email protected]>
+
+---
+ libxslt/preproc.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+Index: libxslt-1.1.28/libxslt/preproc.c
+===================================================================
+--- libxslt-1.1.28.orig/libxslt/preproc.c
++++ libxslt-1.1.28/libxslt/preproc.c
+@@ -2245,7 +2245,8 @@ xsltStylePreCompute(xsltStylesheetPtr st
+ 	} else if (IS_XSLT_NAME(inst, "attribute")) {
+ 	    xmlNodePtr parent = inst->parent;
+
+-	    if ((parent == NULL) || (parent->ns == NULL) ||
++	    if ((parent == NULL) ||
++	        (parent->type != XML_ELEMENT_NODE) || (parent->ns == NULL) ||
+ 		((parent->ns != inst->ns) &&
+ 		 (!xmlStrEqual(parent->ns->href, inst->ns->href))) ||
+ 		(!xmlStrEqual(parent->name, BAD_CAST "attribute-set"))) {

meta/recipes-support/libxslt/libxslt_1.1.28.bb +2 -1

index 166bcd8..87fabec 100644
@@ -10,7 +10,8 @@ DEPENDS = "libxml2"
 
  SRC_URI = "ftp://xmlsoft.org/libxslt//libxslt-${PV}.tar.gz \
             file://pkgconfig_fix.patch \
-           file://pkgconfig.patch"
+           file://pkgconfig.patch \
+           file://CVE-2015-7995.patch"
 
  SRC_URI[md5sum] = "9667bf6f9310b957254fdcf6596600b7"
  SRC_URI[sha256sum] = "5fc7151a57b89c03d7b825df5a0fae0a8d5f05674c0e7cf2937ecec4d54a028c"

akuster808

author

2015-11-06 01:16 UTC #4 lore raw

Quoted 9 lines · Joshua Lock

Quoted 3 lines · On 05/11/15 20:29, akuster808 wrote:
Ping.
- armin
Hi Armin,
I've pushed this change to my joshuagl/fido-next branch of openembedded-core-contrib and am testing it now.

thanks.

- armin

Quoted 90 lines

Thanks,

Joshua

1.
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=joshuagl/fido-next

Quoted 80 lines · Armin Kuster

Quoted 78 lines

From: Armin Kuster <[email protected]>

This is a is being give a High rating so please consider it for all 1.1.28 versions.

A type confusion error within the libxslt "xsltStylePreCompute()" function in preproc.c can lead to a DoS. Confirmed in version 1.1.28, other versions may also be affected.

Signed-off-by Armin Kuster <[email protected]>

---
  .../libxslt/libxslt/CVE-2015-7995.patch            | 33
++++++++++++++++++++++
  meta/recipes-support/libxslt/libxslt_1.1.28.bb     |  3 +-
  2 files changed, 35 insertions(+), 1 deletion(-)

create mode 100644
meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch

meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch new file +7 -0

new file mode 100644
index 0000000..e4d09c2
@@ -0,0 +1,33 @@
+From 7ca19df892ca22d9314e95d59ce2abdeff46b617 Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <[email protected]>
+Date: Thu, 29 Oct 2015 19:33:23 +0800
+Subject: Fix for type confusion in preprocessing attributes
+
+CVE-2015-7995 http://www.openwall.com/lists/oss-security/2015/10/27/10
+We need to check that the parent node is an element before

dereferencing

meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch new file +23 -0

+its namespace
+
+Upstream-Status: Backport
+
+https://git.gnome.org/browse/libxslt/commit/?id=7ca19df892ca22d9314e95d59ce2abdeff46b617
 
+
+Signed-off-by: Armin Kuster <[email protected]>
+
+---
+ libxslt/preproc.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+Index: libxslt-1.1.28/libxslt/preproc.c
+===================================================================
+--- libxslt-1.1.28.orig/libxslt/preproc.c
++++ libxslt-1.1.28/libxslt/preproc.c
+@@ -2245,7 +2245,8 @@ xsltStylePreCompute(xsltStylesheetPtr st
+     } else if (IS_XSLT_NAME(inst, "attribute")) {
+         xmlNodePtr parent = inst->parent;
+
+-        if ((parent == NULL) || (parent->ns == NULL) ||
++        if ((parent == NULL) ||
++            (parent->type != XML_ELEMENT_NODE) || (parent->ns ==

NULL) ||

meta/recipes-support/libxslt/libxslt/CVE-2015-7995.patch new file +3 -0

+         ((parent->ns != inst->ns) &&
+          (!xmlStrEqual(parent->ns->href, inst->ns->href))) ||
+         (!xmlStrEqual(parent->name, BAD_CAST "attribute-set"))) {

meta/recipes-support/libxslt/libxslt_1.1.28.bb +2 -1

index 166bcd8..87fabec 100644
@@ -10,7 +10,8 @@ DEPENDS = "libxml2"
 
  SRC_URI = "ftp://xmlsoft.org/libxslt//libxslt-${PV}.tar.gz \
             file://pkgconfig_fix.patch \
-           file://pkgconfig.patch"
+           file://pkgconfig.patch \
+           file://CVE-2015-7995.patch"
 
  SRC_URI[md5sum] = "9667bf6f9310b957254fdcf6596600b7"
  SRC_URI[sha256sum] =

"5fc7151a57b89c03d7b825df5a0fae0a8d5f05674c0e7cf2937ecec4d54a028c"