Skip to contentSkip to conversation

ata: disk_ata_drive: remove obsolete check for ID validity

PATCH Applied Peter Mamonov 2 participants 2 messages Oct 30, 2015 – Nov 2, 2015 libata

lore
Share & tools
lore

Peter Mamonov

author
#0 lore raw

PATCH 1/1 ata: disk_ata_drive: remove obsolete check for ID validity

Acked-by Juergen Borleis <[email protected]>
Signed-off-by Peter Mamonov <[email protected]>
---
 drivers/ata/disk_ata_drive.c | 17 -----------------
 1 file changed, 17 deletions(-)
drivers/ata/disk_ata_drive.c +0 -17
index ee1709e..d30d0ad 100644
@@ -26,16 +26,6 @@
 #include <disks.h>
 #include <dma.h>
 
-static int ata_id_is_valid(const uint16_t *id)
-{
-	if ((id[ATA_ID_FIELD_VALID] & 1) == 0) {
-		pr_debug("Drive's ID seems invalid\n");
-		return -EINVAL;
-	}
-
-	return 0;
-}
-
 static uint64_t ata_id_n_sectors(uint16_t *id)
 {
 	if (ata_id_has_lba(id)) {

@@ -244,13 +234,6 @@ static int ata_port_init(struct ata_port *port)
 
 	ata_fix_endianess(port->id, SECTOR_SIZE / sizeof(uint16_t));
 
-	rc = ata_id_is_valid(port->id);
-	if (rc) {
-		dev_err(dev, "ata id invalid\n");
-		free(port->id);
-		return rc;
-	}
-
 #ifdef DEBUG
 	ata_dump_id(port->id);
 #endif
Signature · 7 lines
2.1.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 5 lines · Peter Mamonov
Acked-by Juergen Borleis <[email protected]>
Signed-off-by Peter Mamonov <[email protected]>
---
 drivers/ata/disk_ata_drive.c | 17 -----------------
 1 file changed, 17 deletions(-)

Applied, thanks

Sascha

Quoted 40 lines
drivers/ata/disk_ata_drive.c +0 -17
index ee1709e..d30d0ad 100644
@@ -26,16 +26,6 @@
 #include <disks.h>
 #include <dma.h>
 
-static int ata_id_is_valid(const uint16_t *id)
-{
-	if ((id[ATA_ID_FIELD_VALID] & 1) == 0) {
-		pr_debug("Drive's ID seems invalid\n");
-		return -EINVAL;
-	}
-
-	return 0;
-}
-
 static uint64_t ata_id_n_sectors(uint16_t *id)
 {
 	if (ata_id_has_lba(id)) {

@@ -244,13 +234,6 @@ static int ata_port_init(struct ata_port *port)
 
 	ata_fix_endianess(port->id, SECTOR_SIZE / sizeof(uint16_t));
 
-	rc = ata_id_is_valid(port->id);
-	if (rc) {
-		dev_err(dev, "ata id invalid\n");
-		free(port->id);
-		return rc;
-	}
-
 #ifdef DEBUG
 	ata_dump_id(port->id);
 #endif
Signature · 1 line
2.1.4
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox