Skip to contentSkip to conversation

drm: Describe the Rotation property bits.

PATCH Superseded Robert Fekete 2 participants 3 messages Nov 2, 2015

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Describe the Rotation property bits.

Adds clarification of the rotation property bits. I.e. rotation is Counter clockwise and that reflects are applied before any rotation.

---
 include/drm/drm_crtc.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
include/drm/drm_crtc.h +5 -1
index 3f0c6909dda1..45334fa0cb10 100644
@@ -85,7 +85,11 @@ static inline uint64_t I642U64(int64_t val)
 	return (uint64_t)*((uint64_t *)&val);
 }
 
-/* rotation property bits */
+/*
+ * Rotation property bits. Rotate-(degrees) rotates the image by the specified
+ * amount in degrees in counter clockwise direction. reflect-x and reflect-y
+ * reflects the image along the specified axis prior to rotation
+ */
 #define DRM_ROTATE_MASK 0x0f
 #define DRM_ROTATE_0	0
 #define DRM_ROTATE_90	1
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 13 lines · Robert Fekete

Adds clarification of the rotation property bits. I.e. rotation is Counter clockwise and that reflects are applied before any rotation.

---
 include/drm/drm_crtc.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
include/drm/drm_crtc.h +0 -0
index 3f0c6909dda1..45334fa0cb10 100644

include/drm/drm_crtc.h static inline uint64_t I642U64(int64_t val) · line 89

Quoted 6 lines
include/drm/drm_crtc.h +2 -1
@@ -85,7 +85,11 @@ static inline uint64_t I642U64(int64_t val)
 	return (uint64_t)*((uint64_t *)&val);
 }
 
-/* rotation property bits */
+/*
+ * Rotation property bits. Rotate-(degrees)

the "rotate-" and "reflect-" things were supposed to be the names of the property bits. I guess some quotes around them would have been good.

In any case, I tink here we should refer to the define names. eg "DRM_ROTATE_<degrees> rotates the image by the ..."

Quoted 2 lines

rotates the image by the specified
+ * amount in degrees in counter clockwise direction. reflect-x and reflect-y

same here with
"DRM_REFLECT_X and DRM_REFLECT_Y ..."

Quoted 12 lines

+ * reflects the image along the specified axis prior to rotation
+ */
#define DRM_ROTATE_MASK 0x0f
#define DRM_ROTATE_0 0
#define DRM_ROTATE_90 1

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
Quoted 24 lines · Ville Syrjälä
Quoted 13 lines · Robert Fekete

Adds clarification of the rotation property bits. I.e. rotation is Counter clockwise and that reflects are applied before any rotation.

---
 include/drm/drm_crtc.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
include/drm/drm_crtc.h +0 -0
index 3f0c6909dda1..45334fa0cb10 100644

include/drm/drm_crtc.h static inline uint64_t I642U64(int64_t val) · line 89

Quoted 6 lines
include/drm/drm_crtc.h +2 -1
@@ -85,7 +85,11 @@ static inline uint64_t I642U64(int64_t val)
 	return (uint64_t)*((uint64_t *)&val);
 }
 
-/* rotation property bits */
+/*
+ * Rotation property bits. Rotate-(degrees)

the "rotate-" and "reflect-" things were supposed to be the names of the property bits. I guess some quotes around them would have been good.

Quoted 2 lines

In any case, I tink here we should refer to the define names. eg "DRM_ROTATE_<degrees> rotates the image by the ..."

Thanks for noticing. You are absolutely right, V2 coming up in a sec.

Quoted 5 lines
Quoted 2 lines

rotates the image by the specified
+ * amount in degrees in counter clockwise direction. reflect-x and reflect-y

same here with
"DRM_REFLECT_X and DRM_REFLECT_Y ..."

Yes!

Quoted 13 lines
Quoted 12 lines

+ * reflects the image along the specified axis prior to rotation
+ */
#define DRM_ROTATE_MASK 0x0f
#define DRM_ROTATE_0 0
#define DRM_ROTATE_90 1

Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 8 lines
BR
/Robert Fekete
Intel Open Source Technology Center

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel