Remove duplicated -Werror in dtc Makefile
PATCH 1/1 Remove duplicated -Werror in dtc Makefile
The "-Werror" compiler flag is currently declared twice in the Makefile, one time in WARNINGS, and one time in CFLAGS. Let's remove one of them.
Signed-off-by Thomas Huth <[email protected]>
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -18,7 +18,7 @@ CONFIG_LOCALVERSION = CPPFLAGS = -I libfdt -I . WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \ -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow -CFLAGS = -g -Os -fPIC -Werror $(WARNINGS) +CFLAGS = -g -Os -fPIC $(WARNINGS) BISON = bison LEX = flex
Signature · 1 line
1.8.3.1
A message that is not in the archive (sent off-list or not yet received): 1446552120-18659-1-git-send-email-thuth-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
David Gibson
AppliedQuoted 5 lines · Thomas Huth
The "-Werror" compiler flag is currently declared twice in the
Makefile, one time in WARNINGS, and one time in CFLAGS. Let's remove one of them.Signed-off-by Thomas Huth <[email protected]>
Applied, thanks. However, I moved the remaining -Werror from WARNINGS to CFLAGS - the idea is that WARNINGS controls just which warnings are enabled, wheres -Werror controls what happens when a warning occurs.
Quoted 17 lines
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-1@@ -18,7 +18,7 @@ CONFIG_LOCALVERSION = CPPFLAGS = -I libfdt -I . WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \ -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow -CFLAGS = -g -Os -fPIC -Werror $(WARNINGS) +CFLAGS = -g -Os -fPIC $(WARNINGS) BISON = bison LEX = flex
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson