fm10k: don't initialize fm10k_workqueue at global level
Subsystems (2)
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
From: Bruce Allan <[email protected]>
Cleans up checkpatch GLOBAL_INITIALIZERS error
---
-v2
* Fix title from checkpatch complaint
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/intel/fm10k/fm10k_main.c +2 -4
@@ -42,7 +42,7 @@ MODULE_LICENSE("GPL");MODULE_VERSION (DRV_VERSION );/* single workqueue for entire fm10k driver */ -struct workqueue_struct *fm10k_workqueue =NULL ; +struct workqueue_struct *fm10k_workqueue;/** * fm10k_init_module - Driver Registration Routine
@@ -56,8 +56,7 @@ static int __init fm10k_init_module(void)pr_info ("%s\n" , fm10k_copyright);/* create driver workqueue */ -if (!fm10k_workqueue) - fm10k_workqueue =create_workqueue ("fm10k" ); + fm10k_workqueue =create_workqueue ("fm10k" );fm10k_dbg_init ();
@@ -80,7 +79,6 @@ static void __exit fm10k_exit_module(void)/* destroy driver workqueue */ flush_workqueue (fm10k_workqueue);destroy_workqueue (fm10k_workqueue); - fm10k_workqueue =NULL ; }module_exit (fm10k_exit_module);
Signature · 1 line
2.6.1.264.gbab76a9
Allan
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
Quoted 9 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 11:35 AM
To: Intel Wired LAN
Cc: Allan, Bruce W; Keller, Jacob E
Subject: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelFrom: Bruce Allan <[email protected]>
Quoted 7 lines
Cleans up checkpatch
GLOBAL_INITIALIZERSerrorSigned-off-by Bruce Allan <[email protected]>Signed-off-by Jacob Keller <[email protected]>---
-v2
* Fix title from checkpatch complaint
Out of curiosity, what was wrong with the original v1 patch title and what was the exact checkpatch complaint?
Keller
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
Quoted 12 lines · Bruce W
Quoted 12 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 11:35 AM
To: Intel Wired LAN
Cc: Allan, Bruce W; Keller, Jacob E
Subject: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelFrom: Bruce Allan <[email protected]>
Cleans up checkpatch
GLOBAL_INITIALIZERSerror
Quoted 9 lines
Quoted 5 lines
Signed-off-by Bruce Allan <[email protected]>Signed-off-by Jacob Keller <[email protected]>---
-v2
* Fix title from checkpatch complaintOut of curiosity, what was wrong with the original v1 patch title and what was the exact checkpatch complaint?
checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error"
WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Regards,
Jake
Allan
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
Quoted 38 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 3:05 PM
To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
Subject: Re: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelQuoted 12 lines · Bruce W
Quoted 12 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 11:35 AM
To: Intel Wired LAN
Cc: Allan, Bruce W; Keller, Jacob E
Subject: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelFrom: Bruce Allan <[email protected]>
Cleans up checkpatch
GLOBAL_INITIALIZERSerrorQuoted 9 lines
Quoted 5 lines
Signed-off-by Bruce Allan <[email protected]>Signed-off-by Jacob Keller <[email protected]>---
-v2
* Fix title from checkpatch complaintOut of curiosity, what was wrong with the original v1 patch title and what was the exact checkpatch complaint?
checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch
GLOBAL_INITIALISERSerror"WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatchGLOBAL_INITIALISERSerror
Quoted 5 lines
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Regards,
Jake
Which version of checkpatch and options did you use? I tried with the one in Jeff's tree and others but do not get the same.
Keller
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
Quoted 41 lines · Bruce W
Quoted 41 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 3:05 PM
To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
Subject: Re: [PATCH v2] fm10k: don't initializefm10k_workqueueat global
levelQuoted 18 lines · Bruce W
Quoted 10 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 11:35 AM
To: Intel Wired LAN
Cc: Allan, Bruce W; Keller, Jacob E
Subject: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelFrom: Bruce Allan <[email protected]>
Quoted 7 lines
Cleans up checkpatch
GLOBAL_INITIALIZERSerrorSigned-off-by Bruce Allan <[email protected]>Signed-off-by Jacob Keller <[email protected]>---
-v2
* Fix title from checkpatch complaintQuoted 4 lines
Out of curiosity, what was wrong with the original v1 patch title and
what was the exact checkpatch complaint?checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch
GLOBAL_INITIALISERSerror"WARNING:EMAIL_SUBJECT: A patch subject line should describe the change
not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatchGLOBAL_INITIALISERSerror
Quoted 8 lines
Quoted 5 lines
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Regards,
JakeWhich version of checkpatch and options did you use? I tried with the one in Jeff's tree and others but do not get the same.
The one in Jeff's tree did it for me, and has been since commit
a2fe16b9d878 ("checkpatch: try to avoid poor patch subject lines")
I get:
WARNING: A patch subject line should describe the change not the tool that found it #4:
Subject: [PATCH] fm10k: fix checkpatch GLOBAL_INITIALISERS error
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Your patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Regards,
Jake
Allan
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
Quoted 73 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 3:20 PM
To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
Subject: Re: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelQuoted 41 lines · Bruce W
Quoted 41 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 3:05 PM
To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
Subject: Re: [PATCH v2] fm10k: don't initializefm10k_workqueueat global
levelQuoted 18 lines · Bruce W
Quoted 10 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 11:35 AM
To: Intel Wired LAN
Cc: Allan, Bruce W; Keller, Jacob E
Subject: [PATCH v2] fm10k: don't initializefm10k_workqueueat global levelFrom: Bruce Allan <[email protected]>
Quoted 7 lines
Cleans up checkpatch
GLOBAL_INITIALIZERSerrorSigned-off-by Bruce Allan <[email protected]>Signed-off-by Jacob Keller <[email protected]>---
-v2
* Fix title from checkpatch complaintQuoted 4 lines
Out of curiosity, what was wrong with the original v1 patch title and
what was the exact checkpatch complaint?checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch
GLOBAL_INITIALISERSerror"WARNING:EMAIL_SUBJECT: A patch subject line should describe the change
not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatchGLOBAL_INITIALISERSerrorQuoted 8 lines
Quoted 5 lines
total: 0 errors, 1 warnings, 0 checks, 24 lines checked
Regards,
JakeWhich version of checkpatch and options did you use? I tried with the one in Jeff's tree and others but do not get the same.
The one in Jeff's tree did it for me, and has been since commit
a2fe16b9d878("checkpatch: try to avoid poor patch subject lines")I get:
WARNING: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatchGLOBAL_INITIALISERSerrortotal: 0 errors, 1 warnings, 0 checks, 24 lines checked
Quoted 8 lines
Your patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH inMAINTAINERS.Regards,
Jake
Very odd, since it seems we are doing the same thing but get different results :(
Keller
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
Quoted 86 lines · Bruce W
Quoted 86 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 3:20 PM
To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
Subject: Re: [PATCH v2] fm10k: don't initializefm10k_workqueueat global
levelQuoted 48 lines · Bruce W
Quoted 48 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 3:05 PM
To: Allan, Bruce W; intel-wired-lan at lists.osuosl.org
Subject: Re: [PATCH v2] fm10k: don't initializefm10k_workqueueat
global
levelQuoted 19 lines · Bruce W
Quoted 11 lines
-----Original Message-----
From: Keller, Jacob E
Sent: Tuesday, November 03, 2015 11:35 AM
To: Intel Wired LAN
Cc: Allan, Bruce W; Keller, Jacob E
Subject: [PATCH v2] fm10k: don't initializefm10k_workqueueat
global levelFrom: Bruce Allan <[email protected]>
Quoted 7 lines
Cleans up checkpatch
GLOBAL_INITIALIZERSerrorSigned-off-by Bruce Allan <[email protected]>Signed-off-by Jacob Keller <[email protected]>---
-v2
* Fix title from checkpatch complaintQuoted 5 lines
Out of curiosity, what was wrong with the original v1 patch title
and
what was the exact checkpatch complaint?checkpatch.pl results for patch "[PATCH] fm10k: fix checkpatch
GLOBAL_INITIALISERSerror"WARNING:EMAIL_SUBJECT: A patch subject line should describe the change
not the tool that found it
#4:
Subject: [PATCH] fm10k: fix checkpatchGLOBAL_INITIALISERSerrortotal: 0 errors, 1 warnings, 0 checks, 24 lines checked
Quoted 6 lines
Quoted 2 lines
Regards,
JakeWhich version of checkpatch and options did you use? I tried with
the one in Jeff's tree and others but do not get the same.The one in Jeff's tree did it for me, and has been since commit
a2fe16b9d878("checkpatch: try to avoid poor patch subject lines")I get:
WARNING: A patch subject line should describe the change not the tool that
found it
#4:
Subject: [PATCH] fm10k: fix checkpatchGLOBAL_INITIALISERSerrortotal: 0 errors, 1 warnings, 0 checks, 24 lines checked
Your patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH inMAINTAINERS.
Quoted 5 lines
Quoted 2 lines
Regards,
JakeVery odd, since it seems we are doing the same thing but get different results :(
Do:
$git ls-tree HEAD scripts/checkpatch.pl
What is the output you get?
I get:
100755 blob f2a1131b2f8baf06f28e286d6b9203d4d1a873f6 scripts/checkpatch.pl
If you get the same sha1, then we should ensure we're checking the same commit output.
I ran the following commit from my reflog into checkpatch:4917fe7bef67 ("fm10k: fix checkpatch GLOBAL_INITIALISERS error")
which I have also attached to this email in format patch format.
Is it possible you're only showing the contents of the diff and not the actual subject header? This checkpatch warning won't show up if you don't pass it a full commit data and only pass it a diff.
Regards,
Jake
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fm10k-fix-checkpatch-GLOBAL_INITIALISERS-error.patch
Type: text/x-patch
Size: 1492 bytes
Desc: 0001-fm10k-fix-checkpatch-GLOBAL_INITIALISERS-error.patch
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151103/e19c9f75/attachment.bin>
Singh
PATCH v2 1/1 fm10k: don't initialize fm10k_workqueue at global level
In reply to Jacob Keller-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Jacob Keller
Sent: Tuesday, November 3, 2015 11:35 AM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [PATCH v2] fm10k: don't initialize fm10k_workqueue at global level
From: Bruce Allan <[email protected]>
Cleans up checkpatch GLOBAL_INITIALIZERS error
---