Fix mips XLP and Octeon3 assembly
PATCH 1/1 Fix mips XLP and Octeon3 assembly
There is a clash in the machine value, as Octeon3 was assigned one value by binutils, but the XLP patch decided to use the same value. Since the XLP value was not officially assigned, change it to avoid the clash.
This fixes an issue where certain instructions, such as DMUL, may be assembled incorrectly due to the clash.
Mark Hatle (1):
binutils: Fix XLP / Octeon 3 instruction clash
.../binutils/binutils/0012-Add-XLP-instructions-support.patch | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
1.9.3
PATCH 1/1 binutils: Fix XLP / Octeon 3 instruction clash
Use the value 0x00000080 for INSN_XLP, as the value 0x00000040 has already been assigned to INSN_OCTEON3 by the binutils project.
Without this change, invalid instructions can be generated for both INSN_XLP and INSN_OCTEON3.
--- .../binutils/binutils/0012-Add-XLP-instructions-support.patch | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch +7 -1
@@ -31,6 +31,12 @@ Netlogic. Also, update vendor name to NLM wherever applicable. Upstream-Status: Pending Signed-off-by: Khem Raj <[email protected]> + +Use 0x00000080 for INSN_XLP, the value 0x00000040 has already been assigned +to INSN_OCTEON3 + +Signed-off-by: Baoshan Pang <[email protected]> +Signed-off-by: Mark Hatle <[email protected]> --- bfd/aoutx.h | 1 + bfd/archures.c | 1 +
@@ -251,7 +257,7 @@ index ef26167..ef53ec6 100644 +/* Netlogic Xlr instruction */ +#define INSN_XLR 0x00000020 +/* Netlogic XlP instruction */ -+#define INSN_XLP 0x00000040 ++#define INSN_XLP 0x00000080 /* DSP ASE */ #define ASE_DSP 0x00000001
Signature · 1 line
1.9.3
Re: [PATCH] binutils: Fix XLP / Octeon 3 instruction clash
Quoted 6 lines · Mark Hatle
Use the value
0x00000080forINSN_XLP, as the value0x00000040has already been assigned toINSN_OCTEON3by the binutils project.Without this change, invalid instructions can be generated for both
INSN_XLPandINSN_OCTEON3.
this is ok. is octeon3 sent upstream yet ?
Quoted 39 lines
Signed-off-by Mark Hatle <[email protected]>--- .../binutils/binutils/0012-Add-XLP-instructions-support.patch | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch +7
-2@@ -31,6 +31,12 @@ Netlogic. Also, update vendor name to NLM wherever applicable. Upstream-Status: Pending Signed-off-by: Khem Raj <[email protected]> + +Use 0x00000080 for INSN_XLP, the value 0x00000040 has already been assigned +to INSN_OCTEON3 + +Signed-off-by: Baoshan Pang <[email protected]> +Signed-off-by: Mark Hatle <[email protected]> --- bfd/aoutx.h | 1 + bfd/archures.c | 1 +@@ -251,7 +257,7 @@ index ef26167..ef53ec6 100644 +/* Netlogic Xlr instruction */ +#define INSN_XLR 0x00000020 +/* Netlogic XlP instruction */ -+#define INSN_XLP 0x00000040 ++#define INSN_XLP 0x00000080 /* DSP ASE */ #define ASE_DSP 0x00000001 --1.9.3
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [PATCH] binutils: Fix XLP / Octeon 3 instruction clash
Quoted 9 lines · Khem Raj
Quoted 6 lines · Mark Hatle
Use the value
0x00000080forINSN_XLP, as the value0x00000040has already been assigned toINSN_OCTEON3by the binutils project.Without this change, invalid instructions can be generated for both
INSN_XLPandINSN_OCTEON3.this is ok. is octeon3 sent upstream yet ?
AFAIK, the octeon3 stuff is in the binutils master.
--Mark
Quoted 39 lines
Quoted 39 lines
Signed-off-by Mark Hatle <[email protected]>--- .../binutils/binutils/0012-Add-XLP-instructions-support.patch | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)meta/recipes-devtools/binutils/binutils/0012-Add-XLP-instructions-support.patch +7
-2@@ -31,6 +31,12 @@ Netlogic. Also, update vendor name to NLM wherever applicable. Upstream-Status: Pending Signed-off-by: Khem Raj <[email protected]> + +Use 0x00000080 for INSN_XLP, the value 0x00000040 has already been assigned +to INSN_OCTEON3 + +Signed-off-by: Baoshan Pang <[email protected]> +Signed-off-by: Mark Hatle <[email protected]> --- bfd/aoutx.h | 1 + bfd/archures.c | 1 +@@ -251,7 +257,7 @@ index ef26167..ef53ec6 100644 +/* Netlogic Xlr instruction */ +#define INSN_XLR 0x00000020 +/* Netlogic XlP instruction */ -+#define INSN_XLP 0x00000040 ++#define INSN_XLP 0x00000080 /* DSP ASE */ #define ASE_DSP 0x00000001 --1.9.3
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core