Skip to contentSkip to conversation

altera_jtag_uart: Adjust the declaration of debug_uart_init()

PATCH New Thomas Chou 4 participants 10 messages Nov 3, 2015 – Nov 6, 2015

lore
Share & tools
lore

Thomas Chou

author
#0 lore raw

PATCH 1/2 altera_jtag_uart: Adjust the declaration of debug_uart_init()

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
---
 drivers/serial/altera_jtag_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/altera_jtag_uart.c +1 -1
index 767603c..5f0d7ac 100644
@@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
 
 #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)
 {
 }
Signature · 1 line
2.5.0
author
#1 lore raw

PATCH 1/2 altera_jtag_uart: Adjust the declaration of debug_uart_init()

Quoted 8 lines · Thomas Chou

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
---
  drivers/serial/altera_jtag_uart.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-nios.

Quoted 14 lines
drivers/serial/altera_jtag_uart.c +1 -1
index 767603c..5f0d7ac 100644
@@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
 
  #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)
  {
  }
#2 lore raw

PATCH 1/2 altera_jtag_uart: Adjust the declaration of debug_uart_init()

Hi Thomas,

Quoted 23 lines · Thomas Chou
Quoted 9 lines · Thomas Chou

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
---
  drivers/serial/altera_jtag_uart.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-nios.

Quoted 6 lines
drivers/serial/altera_jtag_uart.c +0 -0
index 767603c..5f0d7ac 100644
@@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
Quoted 4 lines

drivers/serial/altera_jtag_uart.c U_BOOT_DRIVER(altera_jtaguart) = { · line 133

Quoted 4 lines
drivers/serial/altera_jtag_uart.c +1 -1
  #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)

BTW I think that should be static.

Quoted 4 lines

drivers/serial/altera_jtag_uart.c U_BOOT_DRIVER(altera_jtaguart) = { · line 136

Quoted 4 lines
drivers/serial/altera_jtag_uart.c +0 -0
  {
  }

Regards,
Simon

author
#3 lore raw

PATCH 1/2 altera_jtag_uart: Adjust the declaration of debug_uart_init()

Hi Simon,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/serial/altera_jtag_uart.c +0 -0
index 767603c..5f0d7ac 100644
@@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
Quoted 6 lines
Quoted 4 lines

drivers/serial/altera_jtag_uart.c U_BOOT_DRIVER(altera_jtaguart) = { · line 133

Quoted 4 lines
drivers/serial/altera_jtag_uart.c +1 -1
   #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)

BTW I think that should be static.

Will do. Thanks.

Best regards,
Thomas

#4 lore raw

PATCH 1/2 altera_jtag_uart: Adjust the declaration of debug_uart_init()

In reply to Thomas Chou
Quoted 4 lines · Thomas Chou

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Quoted 9 lines
---
 drivers/serial/altera_jtag_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/serial/altera_jtag_uart.c index 767603c..5f0d7ac 100644

drivers/serial/altera_jtag_uart.c U_BOOT_DRIVER(altera_jtaguart) = { · line 135

Quoted 7 lines
drivers/serial/altera_jtag_uart.c +1 -1
@@ -130,7 +130,7 @@ U_BOOT_DRIVER(altera_jtaguart) = {
 
 #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)
 {
 }

Best regards,
Marek Vasut

author
#6 lore raw

PATCH 2/2 altera_uart: Adjust the declaration of debug_uart_init()

In reply to Thomas Chou

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
---
 drivers/serial/altera_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/altera_uart.c +1 -1
index 4c4794e..6228981 100644
@@ -124,7 +124,7 @@ U_BOOT_DRIVER(altera_uart) = {
 
 #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)
 {
 	struct altera_uart_regs *regs = (void *)CONFIG_DEBUG_UART_BASE;
 	u32 div;
Signature · 1 line
2.5.0
#7 lore raw

PATCH 2/2 altera_uart: Adjust the declaration of debug_uart_init()

Quoted 4 lines · Thomas Chou

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
Reviewed-by Marek Vasut <[email protected]>
Quoted 9 lines
---
 drivers/serial/altera_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/altera_uart.c +0 -0
index 4c4794e..6228981 100644

drivers/serial/altera_uart.c U_BOOT_DRIVER(altera_uart) = { · line 130

Quoted 8 lines
drivers/serial/altera_uart.c +1 -1
@@ -124,7 +124,7 @@ U_BOOT_DRIVER(altera_uart) = {
 
 #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)
 {
 	struct altera_uart_regs *regs = (void *)CONFIG_DEBUG_UART_BASE;
 	u32 div;

Best regards,
Marek Vasut

author
#9 lore raw

PATCH 2/2 altera_uart: Adjust the declaration of debug_uart_init()

In reply to Thomas Chou
Quoted 8 lines · Thomas Chou

Follow commit 97b059730218 ("debug_uart: Adjust the declaration of debug_uart_init()")

Signed-off-by Thomas Chou <[email protected]>
---
  drivers/serial/altera_uart.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-nios.

Quoted 14 lines
drivers/serial/altera_uart.c +1 -1
index 4c4794e..6228981 100644
@@ -124,7 +124,7 @@ U_BOOT_DRIVER(altera_uart) = {
 
  #include <debug_uart.h>
 
-void debug_uart_init(void)
+void _debug_uart_init(void)
  {
  	struct altera_uart_regs *regs = (void *)CONFIG_DEBUG_UART_BASE;
  	u32 div;