Skip to contentSkip to conversation

spi: cadence_qspi: Ensure check for max frequency in place

PATCH New Chin Liang See 2 participants 5 messages Oct 17, 2015 – Nov 5, 2015 SPI

lore
Share & tools
lore

Chin Liang See

author
#0 lore raw

PATCH v5 4/5 spi: cadence_qspi: Ensure check for max frequency in place

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Pavel Machek <[email protected]>

---
Changes for v5
- shuffling the patches
Changes for v4
- no changes
Changes for v3
- Remove the printout
Changes for v2
- no changes

---
 drivers/spi/cadence_qspi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/spi/cadence_qspi.c +3 -0
index 5756178..4f7fd52 100644
@@ -122,6 +122,9 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
 	struct cadence_spi_priv *priv = dev_get_priv(bus);
 	int err;
 
+	if (hz > plat->max_hz)
+		hz = plat->max_hz;
+
 	/* Disable QSPI */
 	cadence_qspi_apb_controller_disable(priv->regbase);
Signature · 1 line
2.2.0
#1 lore raw

PATCH v5 4/5 spi: cadence_qspi: Ensure check for max frequency in place

Quoted 12 lines · Chin Liang See

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Pavel Machek <[email protected]>
Acked-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut

author
#2 lore raw

PATCH v5 4/5 spi: cadence_qspi: Ensure check for max frequency in place

Quoted 14 lines · marex at denx.de
Quoted 12 lines · Chin Liang See

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Pavel Machek <[email protected]>
Quoted 2 lines
Acked-by Marek Vasut <[email protected]>

Thanks Marek for the review.

I noticed these patches yet to be applied.
Wonder you able to apply these?

Thanks
Chin Liang

Quoted 2 lines

Best regards,
Marek Vasut

#3 lore raw

PATCH v5 4/5 spi: cadence_qspi: Ensure check for max frequency in place

Quoted 15 lines · Chin Liang See
Quoted 14 lines · marex at denx.de
Quoted 12 lines · Chin Liang See

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Pavel Machek <[email protected]>
Quoted 6 lines
Quoted 1 line
Acked-by Marek Vasut <[email protected]>

Thanks Marek for the review.

I noticed these patches yet to be applied.
Wonder you able to apply these?

Sorry about that, applied all five, thanks!

Best regards,
Marek Vasut

author
#4 lore raw

PATCH v5 4/5 spi: cadence_qspi: Ensure check for max frequency in place

Quoted 16 lines · marex at denx.de
Quoted 15 lines · Chin Liang See
Quoted 14 lines · marex at denx.de
Quoted 12 lines · Chin Liang See

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
Acked-by Pavel Machek <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Acked-by Marek Vasut <[email protected]>

Thanks Marek for the review.

I noticed these patches yet to be applied.
Wonder you able to apply these?

Sorry about that, applied all five, thanks!

No worries, thanks Marek!

Thanks
Chin Liang

Quoted 3 lines

Best regards,
Marek Vasut