drm/i915/bxt: Fix eDP panel fitting
Subsystems (2)
PATCH 1/1 drm/i915/bxt: Fix eDP panel fitting
BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths store panel fitter information in pipe_config->pch_pfit. However since HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in this structure (we wind up filling in pipe_config->gmch_pfit instead, which is ignored when we go to program the hardware). Make sure we always take the PCH code path on gen9+ platforms.
---
Not a regression as far as I know; I believe this has been broken since BXT support was added to the driver.
drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -1426,7 +1426,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,return ret; } -if (!HAS_PCH_SPLIT (dev)) +if (!HAS_PCH_SPLIT (dev) &&INTEL_INFO (dev)->gen <9 )intel_gmch_panel_fitting (intel_crtc, pipe_config, intel_connector->panel.fitting_mode);else
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 22 lines · Matt Roper
BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths store panel fitter information in
pipe_config->pch_pfit. However sinceHAS_PCH_SPLIT()is false for BXT we never actually wind up filling in this structure (we wind up filling inpipe_config->gmch_pfitinstead, which is ignored when we go to program the hardware). Make sure we always take the PCH code path on gen9+ platforms.Cc Imre Deak <[email protected]>Cc Chandra Konduru <[email protected]>Signed-off-by Matt Roper <[email protected]>---
Not a regression as far as I know; I believe this has been broken since BXT support was added to the driver.drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +0
-0
drivers/gpu/drm/i915/intel_dp.c intel_dp_compute_config(struct intel_encoder *encoder, · line 1429
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -1426,7 +1426,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,return ret; } -if (!HAS_PCH_SPLIT (dev)) +if (!HAS_PCH_SPLIT (dev) &&INTEL_INFO (dev)->gen <9 )
HAS_GMCH_DISPLAY() would be neater.
with that
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0
-0intel_gmch_panel_fitting (intel_crtc, pipe_config, intel_connector->panel.fitting_mode); elseSignature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 drm/i915/bxt: Fix eDP panel fitting (v2)
BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths store panel fitter information in pipe_config->pch_pfit. However since HAS_PCH_SPLIT() is false for BXT we never actually wind up filling in this structure (we wind up filling in pipe_config->gmch_pfit instead, which is ignored when we go to program the hardware). Make sure we always take the PCH code path on gen9+ platforms.
v2: Use HAS_GMCH_DISPLAY() to more cleanly describe the platforms that
actually want to use GMCH-style panel fitting. (Ville)
--- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +1 -1
@@ -1426,7 +1426,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,return ret; } -if (!HAS_PCH_SPLIT (dev)) +if (HAS_GMCH_DISPLAY (dev))intel_gmch_panel_fitting (intel_crtc, pipe_config, intel_connector->panel.fitting_mode);else
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915/bxt: Fix eDP panel fitting (v2)
Quoted 23 lines · On Wed, 4 Nov 2015 09:05:27 -0800 Matt Roper <[email protected]> wrote:
BXT CRTC scaling uses the same gen9 codepaths as SKL; these codepaths store panel fitter information in
pipe_config->pch_pfit. However sinceHAS_PCH_SPLIT()is false for BXT we never actually wind up filling in this structure (we wind up filling inpipe_config->gmch_pfitinstead, which is ignored when we go to program the hardware). Make sure we always take the PCH code path on gen9+ platforms.v2: Use
HAS_GMCH_DISPLAY()to more cleanly describe the platforms that
actually want to use GMCH-style panel fitting. (Ville)Cc Imre Deak <[email protected]>Cc Chandra Konduru <[email protected]>Signed-off-by Matt Roper <[email protected]>Reviewed-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +0
-0
drivers/gpu/drm/i915/intel_dp.c intel_dp_compute_config(struct intel_encoder *encoder, · line 1432
Quoted 8 lines
drivers/gpu/drm/i915/intel_dp.c +1
-1@@ -1426,7 +1426,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,return ret; } -if (!HAS_PCH_SPLIT (dev)) +if (HAS_GMCH_DISPLAY (dev))intel_gmch_panel_fitting (intel_crtc, pipe_config, intel_connector->panel.fitting_mode);else
Signature · 11 lines
-- Bob Paauwe [email protected] IOTG / PED Software Organization Intel Corp. Folsom, CA (916) 356-6193 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx