isci: remove SCSI host before detaching from SAS transport
Subsystems (2)
PATCH 1/3 isci: remove SCSI host before detaching from SAS transport
commit cff549e4860f ("scsi: proper state checking and module refcount handling in scsi_device_get")
, the reference count of scsi device was changed, which could lead to when rmmod with at least on drive attached, SCSI error handle will run into infinite loop, and lockup the system.
Fix it by remove scsi host first, this way scsi core will not send commands down after detaching SAS transport.
This is a follow up fix for Benjamin's fix for pm80xx.
See also:
http://www.spinics.net/lists/linux-scsi/msg90088.html
Signed-off-by Jack Wang <[email protected]>
--- drivers/scsi/isci/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/isci/init.c +2 -2
@@ -272,11 +272,11 @@ static void isci_unregister(struct isci_host *isci_host)if (!isci_host)return ; + shost =to_shost (isci_host); +scsi_remove_host (shost);sas_unregister_ha (&isci_host->sas_ha); - shost =to_shost (isci_host);sas_remove_host (shost); -scsi_remove_host (shost);scsi_host_put (shost); }
Signature · 1 line
1.9.1
Looks good,
Reviewed-by Christoph Hellwig <[email protected]>
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Jack" == Jack Wang <[email protected]> writes:
Applied patches 1-3.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering