Skip to contentSkip to conversation

aic94xx: remove SCSI host before detaching from SAS transport

PATCH In review Jack Wang 2 participants 2 messages Nov 5, 2015 SCSI

lore
Share & tools
lore

Jack Wang

author
#0 lore raw

PATCH 2/3 aic94xx: remove SCSI host before detaching from SAS transport

commit cff549e4860f ("scsi: proper state checking and module refcount handling in scsi_device_get")
the reference count of scsi device was changed, which could lead to when rmmod with at least on drive attached, SCSI error handle will run into infinite loop, and lockup the system.

Fix it by remove scsi host first, this way scsi core will not send commands down after detaching SAS transport.

This is a follow up fix for Benjamin's fix for pm80xx.

See also:
http://www.spinics.net/lists/linux-scsi/msg90088.html

---
 drivers/scsi/aic94xx/aic94xx_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/aic94xx/aic94xx_init.c +1 -1
index f6c336b..4b56976 100644
@@ -704,10 +704,10 @@ static int asd_unregister_sas_ha(struct asd_ha_struct *asd_ha)
 {
 	int err;
 
+	scsi_remove_host(asd_ha->sas_ha.core.shost);
 	err = sas_unregister_ha(&asd_ha->sas_ha);
 
 	sas_remove_host(asd_ha->sas_ha.core.shost);
-	scsi_remove_host(asd_ha->sas_ha.core.shost);
 	scsi_host_put(asd_ha->sas_ha.core.shost);
 
 	kfree(asd_ha->sas_ha.sas_phy);
Signature · 1 line
1.9.1