Patch "iwlwifi: mvm: fix D3 firmware PN programming" has been added to the 4.2-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iwlwifi: mvm: fix D3 firmware PN programming
to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iwlwifi-mvm-fix-d3-firmware-pn-programming.patch
and it can be found in the queue-4.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
2cf5eb3ab7bb7f2e3a70edcef236cd62c87db030Mon Sep 17 00:00:00 2001
From: Johannes Berg <[email protected]>
Date: Tue, 15 Sep 2015 14:36:09 +0200
Subject: iwlwifi: mvm: fix D3 firmware PN programming
From: Johannes Berg <[email protected]>
commit 2cf5eb3ab7bb7f2e3a70edcef236cd62c87db030 upstream.
The code to send the RX PN data (for each TID) to the firmware has a devastating bug: it overwrites the data for TID 0 with all the TID data, leaving the remaining TIDs zeroed. This will allow replays to actually be accepted by the firmware, which could allow waking up the system.
--- drivers/net/wireless/iwlwifi/mvm/d3.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/net/wireless/iwlwifi/mvm/d3.c +6 -6
@@ -293,12 +293,12 @@ static void iwl_mvm_wowlan_program_keys(u8 *pn = seq.ccmp.pn;ieee80211_get_key_rx_seq (key, i, &seq); - aes_sc->pn =cpu_to_le64 ((u64 )pn[5 ] | - ((u64 )pn[4 ] <<8 ) | - ((u64 )pn[3 ] <<16 ) | - ((u64 )pn[2 ] <<24 ) | - ((u64 )pn[1 ] <<32 ) | - ((u64 )pn[0 ] <<40 )); + aes_sc[i].pn =cpu_to_le64 ((u64 )pn[5 ] | + ((u64 )pn[4 ] <<8 ) | + ((u64 )pn[3 ] <<16 ) | + ((u64 )pn[2 ] <<24 ) | + ((u64 )pn[1 ] <<32 ) | + ((u64 )pn[0 ] <<40 )); } data->use_rsc_tsc = true;break ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.2/mac80211-fix-hwflags-debugfs-file-format.patch queue-4.2/iwlwifi-dvm-fix-d3-firmware-pn-programming.patch queue-4.2/iwlwifi-mvm-fix-d3-ccmp-tx-pn-assignment.patch queue-4.2/iwlwifi-fix-firmware-filename-for-3160.patch queue-4.2/iwlwifi-mvm-fix-d3-firmware-pn-programming.patch