Skip to contentSkip to conversation

igt/intel_aubdump: Use the right ring

PATCH In review Ben Widawsky 2 participants 2 messages Nov 6, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igt/intel_aubdump: Use the right ring

This prevents the simulator from barfing when it sees commands from another ring. I've been using this locally for a very long time.

Cc Kristian Høgsberg <[email protected]>
---
 tools/aubdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/aubdump.c +1 -1
index a17dc10..d9ee791 100644
@@ -315,7 +315,7 @@ dump_execbuffer2(int fd, struct drm_i915_gem_execbuffer2 *execbuffer2)
 {
 	struct drm_i915_gem_exec_object2 *exec_objects =
 		(struct drm_i915_gem_exec_object2 *) (uintptr_t) execbuffer2->buffers_ptr;
-	uint32_t ring_flag = 0;
+	uint32_t ring_flag = execbuffer2->flags & I915_EXEC_RING_MASK;
 	uint32_t offset = gtt_size;
 	struct drm_i915_gem_exec_object2 *obj;
 	struct bo *bo, *batch_bo;
Signature · 6 lines
2.6.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Ben Widawsky

This prevents the simulator from barfing when it sees commands from another ring. I've been using this locally for a very long time.

Yea, that looks good, thanks Ben.

Quoted 20 lines
Cc Kristian Høgsberg <[email protected]>
---
 tools/aubdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/aubdump.c +1 -2
index a17dc10..d9ee791 100644
@@ -315,7 +315,7 @@ dump_execbuffer2(int fd, struct drm_i915_gem_execbuffer2 *execbuffer2)
 {
        struct drm_i915_gem_exec_object2 *exec_objects =
                (struct drm_i915_gem_exec_object2 *) (uintptr_t) execbuffer2->buffers_ptr;
-       uint32_t ring_flag = 0;
+       uint32_t ring_flag = execbuffer2->flags & I915_EXEC_RING_MASK;
        uint32_t offset = gtt_size;
        struct drm_i915_gem_exec_object2 *obj;
        struct bo *bo, *batch_bo;
--
Quoted 2 lines

2.6.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx