Skip to contentSkip to conversation

Staging: lustre: dir: Remove wrapper function

PATCH In review Shivani Bhardwaj 2 participants 2 messages Nov 6, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: lustre: dir: Remove wrapper function

Remove the function ll_check_page() and replace all its calls with the function it wrapped.

---
 drivers/staging/lustre/lustre/llite/dir.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/staging/lustre/lustre/llite/dir.c +2 -7
index 5c9502b..842e6d6 100644
@@ -239,12 +239,6 @@ static int ll_dir_filler(void *_hash, struct page *page0)
 	return rc;
 }
 
-static void ll_check_page(struct inode *dir, struct page *page)
-{
-	/* XXX: check page format later */
-	SetPageChecked(page);
-}
-
 void ll_release_page(struct page *page, int remove)
 {
 	kunmap(page);
@@ -432,7 +426,8 @@ struct page *ll_get_dir_page(struct inode *dir, __u64 hash,
 		goto fail;
 	}
 	if (!PageChecked(page))
-		ll_check_page(dir, page);
+		/* XXX: check page format later */
+		SetPageChecked(page);
 	if (PageError(page)) {
 		CERROR("page error: "DFID" at %llu: rc %d\n",
 		       PFID(ll_inode2fid(dir)), hash, -5);
Signature · 1 line
2.1.0
Acked-by James Simmons on v1 1/1
#1 lore raw
Quoted 7 lines

From: devel [mailto:driverdev-devel-bounces at linuxdriverproject.org] On Behalf Of Shivani Bhardwaj
Sent: Friday, November 06, 2015 11:55 AM
To: gregkh at linuxfoundation.org
Cc: oleg.drokin at intel.com; devel at driverdev.osuosl.org; andreas.dilger at intel.com; linux-kernel at vger.kernel.org; lustre-devel at lists.lustre.org
Subject: [PATCH] Staging: lustre: dir: Remove wrapper function

Quoted 7 lines

Remove the function ll_check_page() and replace all its calls with the function it wrapped.

---
drivers/staging/lustre/lustre/llite/dir.c | 9 ++-------

1 file changed, 2 insertions(+), 7 deletions(-)
drivers/staging/lustre/lustre/llite/dir.c +2 -7
index 5c9502b..842e6d6 100644
@@ -239,12 +239,6 @@ static int ll_dir_filler(void *_hash, struct page *page0)
 	return rc;
 }
 
-static void ll_check_page(struct inode *dir, struct page *page)
-{
-	/* XXX: check page format later */
-	SetPageChecked(page);
-}
-
 void ll_release_page(struct page *page, int remove)
 {
 	kunmap(page);
@@ -432,7 +426,8 @@ struct page *ll_get_dir_page(struct inode *dir, __u64 hash,
 		goto fail;
 	}
 	if (!PageChecked(page))
-		ll_check_page(dir, page);
+		/* XXX: check page format later */
+		SetPageChecked(page);
 	if (PageError(page)) {
 		CERROR("page error: "DFID" at %llu: rc %d\n",
 		       PFID(ll_inode2fid(dir)), hash, -5);
Signature · 6 lines
2.1.0

_______________________________________________
devel mailing list
devel at linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel