comedi: comedi_parport: Fix coding style - use BIT macro
PATCH 1/1 comedi: comedi_parport: Fix coding style - use BIT macro
BIT macro is used for defining BIT location instead of shifting operator - coding style issue
Signed-off-by Ranjith <[email protected]>
--- drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/comedi_parport.c +2 -2
@@ -75,8 +75,8 @@#define PARPORT_DATA_REG 0x00#define PARPORT_STATUS_REG 0x01#define PARPORT_CTRL_REG 0x02 -#define PARPORT_CTRL_IRQ_ENA (1 << 4) -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) +#define PARPORT_CTRL_IRQ_ENA BIT(4) +#define PARPORT_CTRL_BIDIR_ENA BIT(5) static int parport_data_reg_insn_bits(struct comedi_device *dev, struct comedi_subdevice *s,
Signature · 1 line
1.7.10.4
Quoted 13 lines · Ranjith
BIT macro is used for defining BIT location instead of shifting operator - coding style issue
Signed-off-by Ranjith <[email protected]>--- drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/comedi/drivers/comedi_parport.c +0
-0
drivers/staging/comedi/drivers/comedi_parport.c line 82
Quoted 10 lines
drivers/staging/comedi/drivers/comedi_parport.c +2
-2@@ -75,8 +75,8 @@#define PARPORT_DATA_REG 0x00#define PARPORT_STATUS_REG 0x01#define PARPORT_CTRL_REG 0x02 -#define PARPORT_CTRL_IRQ_ENA (1 << 4) -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) +#define PARPORT_CTRL_IRQ_ENA BIT(4) +#define PARPORT_CTRL_BIDIR_ENA BIT(5) static int parport_data_reg_insn_bits(struct comedi_device *dev, struct comedi_subdevice *s,
Hello,
No problems with the patch but your sign-off needs to include your full legal name.
Regards,
Hartley