Skip to contentSkip to conversation

cef3: rework "fix build with gcc 4.9.4"

PATCH New Max Krummenacher 1 participant 1 message Nov 9, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cef3: rework "fix build with gcc 4.9.4"

The link errors addressed with commit '7887e66d5df998b91d4df24a150c32a692784451 fix build with gcc 4.9.4' occur only when linking with gold.
Thus apply the fix only if distro features contain ld-is-gold.

Upstream-Status: Inappropriate configuration

---
 recipes-browser/chromium/cef3_280796.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi

This addresses the review comment by Khem
http://lists.openembedded.org/pipermail/openembedded-devel/2015-November/104408.html

Max

recipes-browser/chromium/cef3_280796.bb +1 -1
index 079e820..d827b8e 100644
@@ -35,7 +35,7 @@ export BUILD_TARGET_ARCH="${TARGET_ARCH}"
 export GYP_DEFINES="${GYP_ARCH_DEFINES} release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
 
 EXTRA_OEGYP =	" \
-    -Ddisable_fatal_linker_warnings=1 \
+    ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '-Ddisable_fatal_linker_warnings=1', '', d)} \
 "
 
 do_configure_prepend() {
Signature · 1 line
1.8.4.5