fetch2: Remove crazy code in unpack

PATCH New Richard Purdie 1 participant 1 message Nov 10, 2015

Share & tools

Richard Purdie

author

2015-11-10 11:10 UTC #0 lore raw

PATCH 1/1 fetch2: Remove crazy code in unpack

This looks reasonable until you realise self.localpath is a function. Data expansion of something which isn't a string is the original value so this code just wastes CPU cycles and makes no sense. Remove it.

Signed-off-by Richard Purdie <[email protected]>

---
 bitbake/lib/bb/fetch2/__init__.py | 3 ---
 1 file changed, 3 deletions(-)

bitbake/lib/bb/fetch2/__init__.py +0 -3

index 288a1c8..d66a212 100644
@@ -1686,9 +1686,6 @@ class Fetch(object):
             ud = self.ud[u]
             ud.setup_localpath(self.d)
 
-            if self.d.expand(self.localpath) is None:
-                continue
-
             if ud.lockfile:
                 lf = bb.utils.lockfile(ud.lockfile)