mtd: jz4740_nand: fix build on jz4740 after removing gpio.h
Subsystems (3)
PATCH 1/1 mtd: jz4740_nand: fix build on jz4740 after removing gpio.h
Fallout from commit 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
We see errors like this:
drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_detect_bank':drivers/mtd/nand/jz4740_nand.c:340:9: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function) drivers/mtd/nand/jz4740_nand.c:340:9: note: each undeclared identifier is reported only once for each function it appears in drivers/mtd/nand/jz4740_nand.c:359:2: error: implicit declaration of function 'jz_gpio_set_function' [-Werror=implicit-function-declaration] drivers/mtd/nand/jz4740_nand.c:359:29: error: 'JZ_GPIO_FUNC_MEM_CS0' undeclared (first use in this function) drivers/mtd/nand/jz4740_nand.c:399:29: error: 'JZ_GPIO_FUNC_NONE' undeclared (first use in this function) drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_probe':drivers/mtd/nand/jz4740_nand.c:528:13: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function) drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_remove':drivers/mtd/nand/jz4740_nand.c:555:14: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)
Patched similarly to:
https://patchwork.linux-mips.org/patch/11089/
--- drivers/mtd/nand/jz4740_nand.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/nand/jz4740_nand.c +1 -0
@@ -25,6 +25,7 @@#include <linux/gpio.h> +#include <asm/mach-jz4740/gpio.h> #include <asm/mach-jz4740/jz4740_nand.h> #define JZ_REG_NAND_CTRL 0x50
Signature · 1 line
2.6.0.rc2.230.g3dd15c0
Quoted 15 lines · Brian Norris
Fallout from commit
832f5dacfa0b("MIPS: Remove all the uses of customgpio.h")We see errors like this:
drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_detect_bank':drivers/mtd/nand/jz4740_nand.c:340:9: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c:340:9: note: each undeclared identifier is reported only once for each function it appears indrivers/mtd/nand/jz4740_nand.c:359:2: error: implicit declaration of function 'jz_gpio_set_function' [-Werror=implicit-function-declaration]drivers/mtd/nand/jz4740_nand.c:359:29: error: 'JZ_GPIO_FUNC_MEM_CS0' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c:399:29: error: 'JZ_GPIO_FUNC_NONE' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_probe':drivers/mtd/nand/jz4740_nand.c:528:13: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_remove':drivers/mtd/nand/jz4740_nand.c:555:14: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)
Quoted 6 lines
Patched similarly to:
https://patchwork.linux-mips.org/patch/11089/
Fixes 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")Signed-off-by Brian Norris <[email protected]>
Looks, good, shall I funnel this upstream?
Ralf
Quoted 17 lines · Ralf Baechle
Quoted 15 lines · Brian Norris
Fallout from commit
832f5dacfa0b("MIPS: Remove all the uses of customgpio.h")We see errors like this:
drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_detect_bank':drivers/mtd/nand/jz4740_nand.c:340:9: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c:340:9: note: each undeclared identifier is reported only once for each function it appears indrivers/mtd/nand/jz4740_nand.c:359:2: error: implicit declaration of function 'jz_gpio_set_function' [-Werror=implicit-function-declaration]drivers/mtd/nand/jz4740_nand.c:359:29: error: 'JZ_GPIO_FUNC_MEM_CS0' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c:399:29: error: 'JZ_GPIO_FUNC_NONE' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_probe':drivers/mtd/nand/jz4740_nand.c:528:13: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)drivers/mtd/nand/jz4740_nand.c: In function 'jz_nand_remove':drivers/mtd/nand/jz4740_nand.c:555:14: error: 'JZ_GPIO_MEM_CS0' undeclared (first use in this function)
Quoted 8 lines
Quoted 6 lines
Patched similarly to:
https://patchwork.linux-mips.org/patch/11089/
Fixes 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")Signed-off-by Brian Norris <[email protected]>Looks, good, shall I funnel this upstream?
Actually, if you don't mind, I'll take it through MTD. I think I'll have a few things to push upstream this week anyway, and I'd like to get some of my MIPS-based build test configs working again in my development trees.
So...pushed to linux-mtd.git
Regards,
Brian
Quoted 6 lines · Brian Norris
Actually, if you don't mind, I'll take it through MTD. I think I'll have a few things to push upstream this week anyway, and I'd like to get some of my MIPS-based build test configs working again in my development trees.
So...pushed to linux-mtd.git
Cool, thanks!
Ralf