Skip to contentSkip to conversation

canutils: rdep on iproute2

PATCH Superseded Christopher Larson 4 participants 11 messages Nov 12, 2015 – Nov 18, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 canutils: rdep on iproute2

From: Christopher Larson <[email protected]>

busybox ip fails to configure can interfaces, so we need iproute2 to do so. See also http://www.armadeus.com/wiki/index.php?title=CAN_bus_Linux_driver.

---
 meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb +3 -0
index c220ead..e1508af 100644
@@ -15,3 +15,6 @@ SRC_URI = "git://git.pengutronix.de/git/tools/canutils.git;protocol=git \
 S = "${WORKDIR}/git"
 
 inherit autotools pkgconfig
+
+# Busybox ip doesn't support can interface configuration, use the real thing
+RDEPENDS_${PN} += "iproute2"
Signature · 1 line
2.2.1
#1 lore raw

PATCH 2/5 talloc,libtevent,libtdb: depend on attr

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built before them. There's currently no configuration option to explicitly control this dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

---
 meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
 meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
 meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb +1 -0
index 0b9e1f2..e349187 100644
@@ -1,6 +1,7 @@
 SUMMARY = "The tdb library"
 SECTION = "libs"
 LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"
 
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
                     file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +1 -1
index f297f30..c37eeb3 100644
@@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
 SECTION = "libs"
 LICENSE = "LGPLv3+"
 
-DEPENDS += "talloc libcap"
+DEPENDS += "talloc libcap attr"
 RDEPENDS_${PN} += "libtalloc"
 RDEPENDS_python-tevent = "python"
 
meta-oe/recipes-support/talloc/talloc_2.1.1.bb +1 -0
index 89c390f..7931374 100644
@@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with destructors"
 HOMEPAGE = "http://talloc.samba.org"
 SECTION = "libs"
 LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"
 
 SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
Signature · 1 line
2.2.1
#2 lore raw

Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Christopher Larson
Sent: Friday, November 13, 2015 4:17 AM
To: [email protected]
Cc: Christopher Larson
Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr

Quoted 7 lines

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built before them. There's currently no configuration option to explicitly control this dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

I added depends on libcap for libtevent for the same reason days ago, but it really concern me now, the 'libreplace' in these waf based packages check many packages(I see libbsd, libcap, libacl for now) existence then build with them if found, and there is no configure option to disable them, does anyone has a better idea how to make waf build in deterministic way? Maybe we should disable the built-in libraries 'libreplace' or add a PACKAGECONFIG for it?

Thanks,
Jackie

Quoted 60 lines
---
 meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
 meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
 meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes- renamed from meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb +0 -0

support/libtdb/libtdb_1.3.0.bb
index 0b9e1f2..e349187 100644

meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb +1 -0
@@ -1,6 +1,7 @@
 SUMMARY = "The tdb library"
 SECTION = "libs"
 LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"
 
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-
 3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
                     file://${COREBASE}/meta/files/common-licenses/GPL-

3.0;md5=c79ff39f19dfec6d293b95dea7b07891"

meta-oe/recipes- renamed from meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +0 -0

support/libtevent/libtevent_0.9.21.bb
index f297f30..c37eeb3 100644

meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +1 -1
@@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
 SECTION = "libs"
 LICENSE = "LGPLv3+"
 
-DEPENDS += "talloc libcap"
+DEPENDS += "talloc libcap attr"
 RDEPENDS_${PN} += "libtalloc"
 RDEPENDS_python-tevent = "python"
 
meta-oe/recipes- renamed from meta-oe/recipes-support/talloc/talloc_2.1.1.bb +0 -0

support/talloc/talloc_2.1.1.bb
index 89c390f..7931374 100644

meta-oe/recipes-support/talloc/talloc_2.1.1.bb +0 -0
@@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with

destructors"
HOMEPAGE = "http://talloc.samba.org"
SECTION = "libs"
LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"

SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz" LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-
3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
--
2.2.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw

Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

Quoted 20 lines · Jie (Jackie)
Quoted 2 lines

-----Original Message-----
From: [email protected] [mailto:

openembedded-devel-

Quoted 5 lines

[email protected]] On Behalf Of Christopher Larson
Sent: Friday, November 13, 2015 4:17 AM
To: [email protected]
Cc: Christopher Larson
Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on

attr

Quoted 5 lines

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built

before

Quoted 1 line

them. There's currently no configuration option to explicitly control

this

Quoted 2 lines

dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

Quoted 10 lines

I added depends on libcap for libtevent for the same reason days ago, but it really concern
me now, the 'libreplace' in these waf based packages check many packages(I see
libbsd, libcap, libacl for now) existence then build with them if found, and there
is no configure option to disable them, does anyone has a better idea how to
make waf build in deterministic way? Maybe we should disable the built-in libraries 'libreplace' or add a PACKAGECONFIG for it?

I don't think PACKAGECONFIG will help unless we have a way to explicitly disable or enable the dependency with waf, otherwise it'd still be non-deterministic. But I think that would be ideal, that's how we handle these things in autoconf, add an argument to let us explicitly enable/disable it. Hopefully someone else on the list knows enough about waf to be able to do so.

Signature · 5 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#4 lore raw

Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

Quoted 44 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Christopher Larson
Sent: Friday, November 13, 2015 11:20 AM
To: Openembedded Discussion
Subject: Re: [oe] [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

Quoted 20 lines · Jie (Jackie)
Quoted 2 lines

-----Original Message-----
From: [email protected] [mailto:

openembedded-devel-

Quoted 5 lines

[email protected]] On Behalf Of Christopher Larson
Sent: Friday, November 13, 2015 4:17 AM
To: [email protected]
Cc: Christopher Larson
Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on

attr

Quoted 5 lines

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built

before

Quoted 1 line

them. There's currently no configuration option to explicitly control

this

Quoted 2 lines

dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

Quoted 10 lines

I added depends on libcap for libtevent for the same reason days ago, but it really concern
me now, the 'libreplace' in these waf based packages check many packages(I see
libbsd, libcap, libacl for now) existence then build with them if found, and there
is no configure option to disable them, does anyone has a better idea how to
make waf build in deterministic way? Maybe we should disable the built-in libraries 'libreplace' or add a PACKAGECONFIG for it?

Quoted 1 line

I don't think PACKAGECONFIG will help unless we have a way to explicitly

You're right, a quick try show me that it doesn't help.

Thanks,
Jackie

Quoted 16 lines

disable or enable the dependency with waf, otherwise it'd still be non-deterministic. But I think that would be ideal, that's how we handle these things in autoconf, add an argument to let us explicitly enable/disable it. Hopefully someone else on the list knows enough about waf to be able to do so.
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-devel mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw

Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

In reply to Huang, Jie (Jackie)
Quoted 21 lines

Am 13.11.2015 um 03:48 schrieb Huang, Jie (Jackie) <[email protected]>:

Quoted 8 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Christopher Larson
Sent: Friday, November 13, 2015 4:17 AM
To: [email protected]
Cc: Christopher Larson
Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr

Quoted 7 lines

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built before them. There's currently no configuration option to explicitly control this dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

Quoted 6 lines

I added depends on libcap for libtevent for the same reason days ago, but it really concern me now, the 'libreplace' in these waf based packages check many packages(I see libbsd, libcap, libacl for now) existence then build with them if found, and there is no configure option to disable them, does anyone has a better idea how to make waf build in deterministic way? Maybe we should disable the built-in libraries 'libreplace' or add a PACKAGECONFIG for it?

I dug for it (libcap) since I couldn't find any reference in wscript & co and finally a

$ for l in tmp/sysroots/curie/usr/lib/lib*.so; do tmp/sysroots/x86_64-linux/usr/libexec/arm-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/4.9.3/arm-poky-linux-gnueabi-objdump -x $l; done | less
pointed the origins:

* libldap_r.so
* libsmbconf.so

Think it shouldn't be a dependency in tevent, but in openldap ...

I add it to my patch series - just wanted to let you know.

Wrt. libbsd - if libbsd is found, stdlcat etc. is used from there, otherwise own implementation via lib/replace is provided, similar for some attr calls - but they aren't used in tevent/talloc ... Looks as if lib/replace is a poor maintained libnbcompat alike :)

Cheers

Signature · 1 line
Jens Rehsack - [email protected]
#6 lore raw

Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

In reply to Christopher Larson
Quoted 53 lines

Am 12.11.2015 um 21:17 schrieb Christopher Larson <[email protected]>:

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built before them. There's currently no configuration option to explicitly control this dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

---

meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb +0 -0
index 0b9e1f2..e349187 100644
@@ -1,6 +1,7 @@

SUMMARY = "The tdb library"
SECTION = "libs"
LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"

LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
                    file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +0 -0
index f297f30..c37eeb3 100644
@@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"

SECTION = "libs"
LICENSE = "LGPLv3+"

meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +1 -1
-DEPENDS += "talloc libcap"
+DEPENDS += "talloc libcap attr"

RDEPENDS_${PN} += "libtalloc"
RDEPENDS_python-tevent = "python"

meta-oe/recipes-support/talloc/talloc_2.1.1.bb +0 -0
index 89c390f..7931374 100644
@@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with destructors"

HOMEPAGE = "http://talloc.samba.org"
SECTION = "libs"
LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"

Quoted 4 lines

SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \

Signature · 1 line
2.2.1

RDEPENDS is wrong for deterministic builds, since they leave a race condition open that attr is build parallel to libtevent and 2nd build is different to first build.

If you want, I handle that better in a patchy way I discussed with JaMa yesterday in #yocto (patch check out depending on PACKAGECONFIG)

Cheers

Signature · 1 line
Jens Rehsack - [email protected]
#7 lore raw

Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr

Quoted 68 lines · Jens Rehsack
Quoted 6 lines

Am 12.11.2015 um 21:17 schrieb Christopher Larson <[email protected]>:

From: Christopher Larson <[email protected]>

These will depend on libattr if it's available, and we need deterministic builds. This fixes a build-deps failure which occurs when attr is built

before

Quoted 1 line

them. There's currently no configuration option to explicitly control

this

Review

Quoted 11 lines

dependency, and I don't know enough about waf to add such an option, so unconditionally dep on it for now.

---

meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb

Quoted 10 lines

index 0b9e1f2..e349187 100644

meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb +0 -0
@@ -1,6 +1,7 @@

SUMMARY = "The tdb library"
SECTION = "libs"
LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"

LIC_FILES_CHKSUM =

"file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \

Quoted 1 line

file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb

Quoted 12 lines

index f297f30..c37eeb3 100644

meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +0 -0
@@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"

SECTION = "libs"
LICENSE = "LGPLv3+"

meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb +1 -1
-DEPENDS += "talloc libcap"
+DEPENDS += "talloc libcap attr"

RDEPENDS_${PN} += "libtalloc"
RDEPENDS_python-tevent = "python"

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb

meta-oe/recipes-support/talloc/talloc_2.1.1.bb SUMMARY = "Hierarchical, reference counted memory pool

Quoted 4 lines

index 89c390f..7931374 100644

meta-oe/recipes-support/talloc/talloc_2.1.1.bb +0 -0
@@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool

system with destructors"

Quoted 7 lines

HOMEPAGE = "http://talloc.samba.org"
SECTION = "libs"
LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"

SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz" LIC_FILES_CHKSUM =

"file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \

Quoted 2 lines

--
2.2.1

Quoted 6 lines

RDEPENDS is wrong for deterministic builds, since they leave a race condition open that attr is build parallel to libtevent and 2nd build is different to first build.

If you want, I handle that better in a patchy way I discussed with JaMa yesterday in #yocto (patch check out depending on PACKAGECONFIG)

I don't believe anyone said anything about rdepending on attr. This patch certainly doesn't, it adds to DEPENDS. But as was said earlier in the thread, a way to explicitly enable/disable the dep in the underlying buildsystem would be better.

Signature · 5 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#8 lore raw

PATCH 3/5 lowpan-tools: add missing flex/bison deps

In reply to Christopher Larson

From: Christopher Larson <[email protected]>

---
 meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb +1 -1
index f57df5d..b1bd926 100644
@@ -5,7 +5,7 @@ SECTION = "net"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-DEPENDS = "libnl python"
+DEPENDS = "flex-native bison-native libnl python"
 
 PV = "0.3.1+git${SRCPV}"
 SRC_URI = "git://git.code.sf.net/p/linux-zigbee/linux-zigbee \
Signature · 1 line
2.2.1
#9 lore raw

PATCH 4/5 ctdb: rdep on bash

In reply to Christopher Larson

From: Christopher Larson <[email protected]>

onnode is a shell script with bashisms and bash #!.

---
 meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb +3 -0
index 3731efd..5718c5f 100644
@@ -41,3 +41,6 @@ do_install_append() {
 SYSTEMD_SERVICE_${PN} = "ctdb.service"
 
 FILES_${PN} += "/run"
+
+# onnode is a shell script with bashisms and bash #!
+RDEPENDS_${PN} += "bash"
Signature · 1 line
2.2.1
#10 lore raw

PATCH 5/5 gpsd: also support bluez5

In reply to Christopher Larson

From: Christopher Larson <[email protected]>

gpsd uses libbluetooth, not the dbus interface, so it can work with bluez5 as well, as the library is compatible.

---
 meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb +2 -2
index dae39c2..6ae2f30 100644
@@ -34,8 +34,8 @@ SYSTEMD_OESCONS = "${@base_contains('DISTRO_FEATURES', 'systemd', 'true', 'false
 export STAGING_INCDIR
 export STAGING_LIBDIR
 
-PACKAGECONFIG ??= "qt ${@base_contains('DISTRO_FEATURES', 'bluetooth', '${BLUEZ}', '', d)}"
-PACKAGECONFIG[bluez4] = "bluez='true',bluez='false',bluez4"
+PACKAGECONFIG ??= "qt ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)}"
+PACKAGECONFIG[bluez] = "bluez='true',bluez='false',${BLUEZ}"
 PACKAGECONFIG[qt] = "qt='yes',qt='no',qt4-x11-free"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
Signature · 1 line
2.2.1