Skip to contentSkip to conversation

Driver: Vmxnet3: Fix use of mfTableLen for big endian architectures

PATCH In review Shrikrishna Khare 2 participants 3 messages Nov 13, 2015 – Nov 16, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Driver: Vmxnet3: Fix use of mfTableLen for big endian architectures

---
 drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++++---
 drivers/net/vmxnet3/vmxnet3_int.h | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)
drivers/net/vmxnet3/vmxnet3_drv.c +4 -3
index 46f4cad..899ea42 100644
@@ -2157,12 +2157,13 @@ vmxnet3_set_mc(struct net_device *netdev)
 		if (!netdev_mc_empty(netdev)) {
 			new_table = vmxnet3_copy_mc(netdev);
 			if (new_table) {
-				rxConf->mfTableLen = cpu_to_le16(
-					netdev_mc_count(netdev) * ETH_ALEN);
+				size_t sz = netdev_mc_count(netdev) * ETH_ALEN;
+
+				rxConf->mfTableLen = cpu_to_le16(sz);
 				new_table_pa = dma_map_single(
 							&adapter->pdev->dev,
 							new_table,
-							rxConf->mfTableLen,
+							sz,
 							PCI_DMA_TODEVICE);
 			}
 
drivers/net/vmxnet3/vmxnet3_int.h +2 -2
index 3f859a5..4c58c83 100644
@@ -69,10 +69,10 @@
 /*
  * Version numbers
  */
-#define VMXNET3_DRIVER_VERSION_STRING   "1.4.3.0-k"
+#define VMXNET3_DRIVER_VERSION_STRING   "1.4.4.0-k"
 
 /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */
-#define VMXNET3_DRIVER_VERSION_NUM      0x01040300
+#define VMXNET3_DRIVER_VERSION_NUM      0x01040400
 
 #if defined(CONFIG_PCI_MSI)
 	/* RSS only makes sense if MSI-X is supported. */
Signature · 1 line
1.8.5.6
#2 lore raw
Quoted 11 lines · David Miller

From: Shrikrishna Khare <[email protected]>
Date: Fri, 13 Nov 2015 15:42:10 -0800

Quoted 3 lines

You guys really have to stop targetting simple, straightforward, bug fixes at net-next. That is not appropriate.

Bug fixes should target 'net'.

Thanks for applying this patch to net.

Will send similar patches to net in future.

Thanks,
Shri