Skip to contentSkip to conversation

Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint_maxp()

PATCH In review Cheah Kok Cheong 3 participants 4 messages Nov 14, 2015 – Nov 16, 2015

Subsystems (2)
Sound Edirol ua-101/ua-1000 driver
lore
Share & tools
lore

Cheah Kok Cheong

author
#0 lore raw

PATCH 1/1 Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint_maxp()

Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")

And commit 29cc88979a88 ("USB: use usb_endpoint_maxp() instead of le16_to_cpu()")

This trivial patch convert remaining user.

Patched against
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

Signed-off-by Cheah Kok Cheong <[email protected]>
---
 sound/usb/misc/ua101.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/usb/misc/ua101.c +2 -2
index 9581089..c19a5dd 100644
@@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
 		return -ENXIO;
 	}
 	ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
-	ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
+	ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
 
 	epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
 	if (!usb_endpoint_is_isoc_out(epd)) {

@@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
 		return -ENXIO;
 	}
 	ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
-	ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
+	ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
 	return 0;
 }
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Cheah Kok Cheong

Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")

And commit 29cc88979a88 ("USB: use usb_endpoint_maxp() instead of le16_to_cpu()")

These sentences no verb.

Quoted 2 lines

Patched against
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

This does not belong into the commit message.

Quoted 1 line
Signed-off-by Cheah Kok Cheong <[email protected]>

Otherwise:

Acked-by Clemens Ladisch <[email protected]>
Quoted 25 lines
---
 sound/usb/misc/ua101.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/usb/misc/ua101.c +2 -2
index 9581089..c19a5dd 100644
@@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
 		return -ENXIO;
 	}
 	ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
-	ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
+	ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
 
 	epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
 	if (!usb_endpoint_is_isoc_out(epd)) {

@@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
 		return -ENXIO;
 	}
 	ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
-	ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
+	ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
 	return 0;
 }
#2 lore raw
Quoted 12 lines · Clemens Ladisch
Quoted 4 lines · Cheah Kok Cheong

Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")

And commit 29cc88979a88 ("USB: use usb_endpoint_maxp() instead of le16_to_cpu()")

These sentences no verb.

Quoted 2 lines

Patched against
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

Quoted 6 lines

This does not belong into the commit message.

Quoted 1 line
Signed-off-by Cheah Kok Cheong <[email protected]>

Otherwise:

Acked-by Clemens Ladisch <[email protected]>

Applied now with some manual fixes.

thanks,

Takashi

Quoted 27 lines
Quoted 26 lines
---
 sound/usb/misc/ua101.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/usb/misc/ua101.c +2 -2
index 9581089..c19a5dd 100644
@@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
 		return -ENXIO;
 	}
 	ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
-	ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
+	ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
 
 	epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
 	if (!usb_endpoint_is_isoc_out(epd)) {

@@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
 		return -ENXIO;
 	}
 	ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
-	ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
+	ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
 	return 0;
 }
author
#3 lore raw
Quoted 21 lines · Takashi Iwai
Quoted 12 lines · Clemens Ladisch
Quoted 4 lines · Cheah Kok Cheong

Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")

And commit 29cc88979a88 ("USB: use usb_endpoint_maxp() instead of le16_to_cpu()")

These sentences no verb.

Quoted 2 lines

Patched against
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

Quoted 6 lines

This does not belong into the commit message.

Quoted 1 line
Signed-off-by Cheah Kok Cheong <[email protected]>

Otherwise:

Acked-by Clemens Ladisch <[email protected]>
Quoted 7 lines

Applied now with some manual fixes.

thanks,

Takashi

Sorry for the commit message mistakes. Will keep in mind. Thank you all.
Brgds,
CheahKC