Skip to contentSkip to conversation

drivers:pci:hotplug Fix space prohibited after function name

PATCH In review Bogicevic Sasa 2 participants 2 messages Nov 15, 2015 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers:pci:hotplug Fix space prohibited after function name

This fixes warning that a space is prohibited after function name

---
 drivers/pci/hotplug/pci_hotplug_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/hotplug/pci_hotplug_core.c +1 -1
index 2bac1b9..d379d49 100644
@@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
 	u32 test;
 	int retval = 0;
 
-	ltest = simple_strtoul (buf, NULL, 10);
+	ltest = simple_strtoul(buf, NULL, 10);
 	test = (u32)(ltest & 0xffffffff);
 	dbg("test = %d\n", test);
 
Signature · 1 line
2.1.4
#1 lore raw
Quoted 12 lines · Bogicevic Sasa

This fixes warning that a space is prohibited after function name

---
 drivers/pci/hotplug/pci_hotplug_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/hotplug/pci_hotplug_core.c +0 -0
index 2bac1b9..d379d49 100644

drivers/pci/hotplug/pci_hotplug_core.c static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf, · line 230

Quoted 6 lines
drivers/pci/hotplug/pci_hotplug_core.c +1 -1
@@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
        u32 test;
        int retval = 0;
 
-       ltest = simple_strtoul (buf, NULL, 10);
+       ltest = simple_strtoul(buf, NULL, 10);
        test = (u32)(ltest & 0xffffffff);

Looks like all above could be replaced by

int retval;

retval = kstrtou32(… &test);
if (retval)
return retval;

Quoted 10 lines
drivers/pci/hotplug/pci_hotplug_core.c +0 -1
        dbg("test = %d\n", test);
 
--

2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
With Best Regards,
Andy Shevchenko