toshiba_acpi: Fix blank screen at boot if transflective backlight is supported
Subsystems (3)
Azael Avalos
maintainerPATCH 1/1 toshiba_acpi: Fix blank screen at boot if transflective backlight is supported
If transflective backlight is supported and the brightness is zero (lowest brightness level), the set_lcd_brightness function will activate the transflective backlight, making the LCD appear to be turned off.
This patch fixes the issue by incrementing the brightness level, and by doing so, avoiding the activation of the tranflective backlight.
--- drivers/platform/x86/toshiba_acpi.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/platform/x86/toshiba_acpi.c +8 -0
@@ -2634,6 +2634,14 @@ static int toshiba_acpi_setup_backlight(struct toshiba_acpi_dev *dev) brightness =__get_lcd_brightness (dev);if (brightness <0 )return 0 ; +/* +* If transflective backlight is supported and the brightness is zero +* (lowest brightness level), the set_lcd_brightness function will +* activate the transflective backlight, making the LCD appear to be +* turned off, simply increment the brightness level to avoid that. +*/ +if (dev->tr_backlight_supported && brightness ==0 ) + brightness++; ret =set_lcd_brightness (dev, brightness);if (ret) {pr_debug ("Backlight method is read-only, disabling backlight support\n" );
Signature · 1 line
2.6.2
Quoted 6 lines · Azael Avalos
If transflective backlight is supported and the brightness is zero (lowest brightness level), the
set_lcd_brightnessfunction will activate the transflective backlight, making the LCD appear to be turned off.This patch fixes the issue by incrementing the brightness level, and by doing so, avoiding the activation of the tranflective backlight.
So... I'm not sure this is a bug or even wrong behavior. The lowest setting on my Thinkpad Yoga 12 is also "off" in Linux. Same is true for my Mac Book Pro (in Mac OS X).
From what I can tell, what this patch does is merely disable the lowest setting.
What is it about this behavior that is considered to be wrong?
Quoted 31 lines
Cc <[email protected]> # 4.3+Reported-and-tested-by Fabian Koester <[email protected]>Signed-off-by Azael Avalos <[email protected]>--- drivers/platform/x86/toshiba_acpi.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/platform/x86/toshiba_acpi.c +8
-0@@ -2634,6 +2634,14 @@ static int toshiba_acpi_setup_backlight(struct toshiba_acpi_dev *dev) brightness =__get_lcd_brightness (dev);if (brightness <0 )return 0 ; +/* +* If transflective backlight is supported and the brightness is zero +* (lowest brightness level), the set_lcd_brightness function will +* activate the transflective backlight, making the LCD appear to be +* turned off, simply increment the brightness level to avoid that. +*/ +if (dev->tr_backlight_supported && brightness ==0 ) + brightness++; ret =set_lcd_brightness (dev, brightness);if (ret) {pr_debug ("Backlight method is read-only, disabling backlight support\n" );Signature · 1 line
2.6.2
Signature · 2 lines
Darren Hart Intel Open Source Technology Center
Azael Avalos
maintainerHi Darren,
2015-11-20 16:16 GMT-07:00 Darren Hart <[email protected]>:
Quoted 11 lines · Azael Avalos
Quoted 6 lines
If transflective backlight is supported and the brightness is zero (lowest brightness level), the
set_lcd_brightnessfunction will activate the transflective backlight, making the LCD appear to be turned off.This patch fixes the issue by incrementing the brightness level, and by doing so, avoiding the activation of the tranflective backlight.
So... I'm not sure this is a bug or even wrong behavior. The lowest setting on my Thinkpad Yoga 12 is also "off" in Linux. Same is true for my Mac Book Pro (in Mac OS X).
Yeah, and even on "regular" (with non transflective backlight) Toshibas zero is also "off" and no problem is observed.
Quoted 2 lines
From what I can tell, what this patch does is merely disable the lowest setting.
Nope, we are just not letting the driver enable transflective backlight and continue using the "normal" brightness range.
Quoted 3 lines
What is it about this behavior that is considered to be wrong?
The problem is with laptops with transflective backlight support.
The code for transflective backlight is fused with the LCD backlight code (go figure...), so if a Toshiba laptop with transflective support is detected, the max brightness levels are raised by one.
A regular laptop's brightness levels are 0-7, but on a laptop with transflective support, the brightness levels are 0-8, zero being "activate transflective backlight" and 1-8 the regular brightness levels.
So, when a laptop with transflective support AND an initial brightness level of zero gets probed for backlight support, the set_lcd_brightness function activates the transfective backlight, as the brightness levels are still not incremented, and thus, the screen goes dark.
I hope this clarifies a bit the situation here.
Cheers
Azael
Signature · 1 line
-- El mundo apesta y vosotros apestais tambien --
Quoted 39 lines · Azael Avalos
Hi Darren,
2015-11-20 16:16 GMT-07:00 Darren Hart <[email protected]>:
Quoted 11 lines · Azael Avalos
Quoted 6 lines
If transflective backlight is supported and the brightness is zero (lowest brightness level), the
set_lcd_brightnessfunction will activate the transflective backlight, making the LCD appear to be turned off.This patch fixes the issue by incrementing the brightness level, and by doing so, avoiding the activation of the tranflective backlight.
So... I'm not sure this is a bug or even wrong behavior. The lowest setting on my Thinkpad Yoga 12 is also "off" in Linux. Same is true for my Mac Book Pro (in Mac OS X).
Yeah, and even on "regular" (with non transflective backlight) Toshibas zero is also "off" and no problem is observed.
Quoted 2 lines
From what I can tell, what this patch does is merely disable the lowest setting.
Nope, we are just not letting the driver enable transflective backlight and continue using the "normal" brightness range.
Quoted 3 lines
What is it about this behavior that is considered to be wrong?
The problem is with laptops with transflective backlight support.
The code for transflective backlight is fused with the LCD backlight code (go figure...), so if a Toshiba laptop with transflective support is detected, the max brightness levels are raised by one.
A regular laptop's brightness levels are 0-7, but on a laptop with transflective support, the brightness levels are 0-8, zero being "activate transflective backlight" and 1-8 the regular brightness levels.
Quoted 8 lines
So, when a laptop with transflective support AND an initial brightness level of zero gets probed for backlight support, the
set_lcd_brightnessfunction activates the transfective backlight, as the brightness levels are still not incremented, and thus, the screen goes dark.I hope this clarifies a bit the situation here.
Thanks, queued to testing.
Signature · 2 lines
Darren Hart Intel Open Source Technology Center