vhost: relax log address alignment
Subsystems (5)
Michael S. Tsirkin
maintainerPATCH 1/1 vhost: relax log address alignment
commit 5d9a07b0de512b77bf28d2401e5fe3351f00a240 ("vhost: relax used address alignment") fixed the alignment for the used virtual address, but not for the physical address used for logging.
That's a mistake: alignment should clearly be the same for virtual and physical addresses,
Signed-off-by Michael S. Tsirkin <[email protected]>
--- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/vhost/vhost.c +1 -1
@@ -819,7 +819,7 @@ long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp) BUILD_BUG_ON(__alignof__ *vq->used > VRING_USED_ALIGN_SIZE);if ((a.avail_user_addr & (VRING_AVAIL_ALIGN_SIZE -1 )) || (a.used_user_addr & (VRING_USED_ALIGN_SIZE -1 )) || - (a.log_guest_addr & (sizeof (u64) -1 ))) { + (a.log_guest_addr & (VRING_USED_ALIGN_SIZE -1 ))) { r = -EINVAL ;break ; }
Signature · 1 line
MST
Quoted 17 lines · Michael S. Tsirkin
commit
5d9a07b0de512b77bf28d2401e5fe3351f00a240("vhost: relax used address alignment") fixed the alignment for the used virtual address, but not for the physical address used for logging.That's a mistake: alignment should clearly be the same for virtual and physical addresses,
Signed-off-by Michael S. Tsirkin <[email protected]>--- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/vhost/vhost.c +0
-0
drivers/vhost/vhost.c long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp) · line 825
Quoted 8 lines
drivers/vhost/vhost.c +1
-1@@ -819,7 +819,7 @@ long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp) BUILD_BUG_ON(__alignof__ *vq->used > VRING_USED_ALIGN_SIZE);if ((a.avail_user_addr & (VRING_AVAIL_ALIGN_SIZE -1 )) || (a.used_user_addr & (VRING_USED_ALIGN_SIZE -1 )) || - (a.log_guest_addr & (sizeof (u64) -1 ))) { + (a.log_guest_addr & (VRING_USED_ALIGN_SIZE -1 ))) { r = -EINVAL ;break ; }
Acked-by Jason Wang <[email protected]>