qom: add a test case for complex property finalization
PATCH 1/1 qom: add a test case for complex property finalization
QDev has some quite complex object child/link relationships which place some requirements on the object_property_del_all method to consider that properties can be modified while being iterated over.
This extends the QOM property test case to replicate the QDev like structure and expose any potential bugs in the object_property_del_all method.
--- tests/check-qom-proplist.c | 159 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 159 insertions(+)
tests/check-qom-proplist.c +159 -0
@@ -152,6 +152,148 @@ static const TypeInfo dummy_info = { .class_size = sizeof(DummyObjectClass), }; + +/* +* The following 3 object classes are used to +* simulate the kind of relationships seen in +* qdev, which result in complex object +* property destruction ordering. +* +* DummyDev has a 'bus' child to a DummyBus +* DummyBus has a 'backend' child to a DummyBackend +* DummyDev has a 'backend' link to DummyBackend +* +* When DummyDev is finalized, it unparents the +* DummyBackend, which unparents the DummyDev +* which deletes the 'backend' link from DummyDev +* to DummyBackend. This illustrates that the +* object_property_del_all() method needs to +* cope with the list of properties being changed +* while it iterates over them. +*/ +typedef struct DummyDev DummyDev ; +typedef struct DummyDevClass DummyDevClass ; +typedef struct DummyBus DummyBus ; +typedef struct DummyBusClass DummyBusClass ; +typedef struct DummyBackend DummyBackend ; +typedef struct DummyBackendClass DummyBackendClass ; + +#define TYPE_DUMMY_DEV "qemu-dummy-dev" +#define TYPE_DUMMY_BUS "qemu-dummy-bus" +#define TYPE_DUMMY_BACKEND "qemu-dummy-backend" + +#define DUMMY_DEV (obj) \ + OBJECT_CHECK(DummyDev, (obj), TYPE_DUMMY_DEV) +#define DUMMY_BUS (obj) \ + OBJECT_CHECK(DummyBus, (obj), TYPE_DUMMY_BUS) +#define DUMMY_BACKEND (obj) \ + OBJECT_CHECK(DummyBackend, (obj), TYPE_DUMMY_BACKEND) + +struct DummyDev { +Object parent_obj; + +DummyBus *bus; +}; + +struct DummyDevClass { +ObjectClass parent_class; +}; + +struct DummyBus { +Object parent_obj; + +DummyBackend *backend; +}; + +struct DummyBusClass { +ObjectClass parent_class; +}; + +struct DummyBackend { +Object parent_obj; +}; + +struct DummyBackendClass { +ObjectClass parent_class; +}; + + +static void dummy_dev_init (Object *obj) +{ +DummyDev *dev =DUMMY_DEV (obj); +DummyBus *bus =DUMMY_BUS (object_new (TYPE_DUMMY_BUS )); +DummyBackend *backend =DUMMY_BACKEND (object_new (TYPE_DUMMY_BACKEND )); + +object_property_add_child (obj,"bus" ,OBJECT (bus),NULL ); + dev->bus = bus; +object_property_add_child (OBJECT (bus),"backend" ,OBJECT (backend),NULL ); + bus->backend = backend; + +object_property_add_link (obj,"backend" ,TYPE_DUMMY_BACKEND , + (Object **)&bus->backend,NULL ,0 ,NULL ); +} + +static void dummy_dev_unparent (Object *obj) +{ +DummyDev *dev =DUMMY_DEV (obj); +object_unparent (OBJECT (dev->bus)); +} + +static void dummy_dev_class_init (ObjectClass *klass,void *opaque) +{ + klass->unparent = dummy_dev_unparent; +} + + +static void dummy_bus_init (Object *obj) +{ +} + +static void dummy_bus_unparent (Object *obj) +{ +DummyBus *bus =DUMMY_BUS (obj); +object_property_del (obj->parent,"backend" ,NULL ); +object_unparent (OBJECT (bus->backend)); +} + +static void dummy_bus_class_init (ObjectClass *klass,void *opaque) +{ + klass->unparent = dummy_bus_unparent; +} + +static void dummy_backend_init (Object *obj) +{ +} + + +static const TypeInfo dummy_dev_info = { + .name =TYPE_DUMMY_DEV , + .parent =TYPE_OBJECT , + .instance_size =sizeof (DummyDev), + .instance_init = dummy_dev_init, + .class_size =sizeof (DummyDevClass), + .class_init = dummy_dev_class_init, +}; + +static const TypeInfo dummy_bus_info = { + .name =TYPE_DUMMY_BUS , + .parent =TYPE_OBJECT , + .instance_size =sizeof (DummyBus), + .instance_init = dummy_bus_init, + .class_size =sizeof (DummyBusClass), + .class_init = dummy_bus_class_init, +}; + +static const TypeInfo dummy_backend_info = { + .name =TYPE_DUMMY_BACKEND , + .parent =TYPE_OBJECT , + .instance_size =sizeof (DummyBackend), + .instance_init = dummy_backend_init, + .class_size =sizeof (DummyBackendClass), +}; + + +static void test_dummy_createv (void ) {Error *err =NULL ;
@@ -331,18 +473,35 @@ static void test_dummy_iterator(void) } +static void test_dummy_delchild (void ) +{ +Object *parent =object_get_objects_root (); +DummyDev *dev =DUMMY_DEV ( +object_new_with_props (TYPE_DUMMY_DEV , + parent, +"dev0" , + &error_abort, +NULL )); + +object_unparent (OBJECT (dev)); +} +int main (int argc,char **argv) {g_test_init (&argc, &argv,NULL );module_call_init (MODULE_INIT_QOM );type_register_static (&dummy_info); +type_register_static (&dummy_dev_info); +type_register_static (&dummy_bus_info); +type_register_static (&dummy_backend_info);g_test_add_func ("/qom/proplist/createlist" , test_dummy_createlist);g_test_add_func ("/qom/proplist/createv" , test_dummy_createv);g_test_add_func ("/qom/proplist/badenum" , test_dummy_badenum);g_test_add_func ("/qom/proplist/getenum" , test_dummy_getenum);g_test_add_func ("/qom/proplist/iterator" , test_dummy_iterator); +g_test_add_func ("/qom/proplist/delchild" , test_dummy_delchild);return g_test_run (); }
Signature · 1 line
2.5.0
Am 16.11.2015 um 16:37 schrieb Daniel P. Berrange:
Quoted 5 lines
QDev has some quite complex object child/link relationships which place some requirements on the
object_property_del_allmethod to consider that properties can be modified while being iterated over.
Quoted 8 lines
This extends the QOM property test case to replicate the QDev like structure and expose any potential bugs in the
object_property_del_allmethod.Signed-off-by Daniel P. Berrange <[email protected]>--- tests/check-qom-proplist.c | 159 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 159 insertions(+)
Thanks, queued on qom-next and sent a patch to include it in MAINTAINERS.
Andreas
Signature · 2 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)