comedi: dmm32at: Fix coding style - use BIT macro

PATCH In review Ranjith Thangavel 2 participants 2 messages Nov 16, 2015 Staging

Share & tools

Ranjith Thangavel

author

2015-11-16 17:05 UTC #0 lore raw

PATCH 1/1 comedi: dmm32at: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator, usleep_range is preferred over udelay - coding style issue

Signed-off-by Ranjith Thangavel <[email protected]>

---
 drivers/staging/comedi/drivers/dmm32at.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/comedi/drivers/dmm32at.c +2 -2

index d312fda..9f8c9eb 100644
@@ -508,7 +508,7 @@ static int dmm32at_reset(struct comedi_device *dev)
 	outb(DMM32AT_CTRL_RESETA, dev->iobase + DMM32AT_CTRL_REG);
 
 	/* allow a millisecond to reset */
-	udelay(1000);
+	usleep_range(1000, 1050);
 
 	/* zero scan and fifo control */
 	outb(0x0, dev->iobase + DMM32AT_FIFO_CTRL_REG);

@@ -524,7 +524,7 @@ static int dmm32at_reset(struct comedi_device *dev)
 	outb(DMM32AT_RANGE_U10, dev->iobase + DMM32AT_AI_CFG_REG);
 
 	/* should take 10 us to settle, here's a hundred */
-	udelay(100);
+	usleep_range(100, 150);
 
 	/* read back the values */
 	ailo = inb(dev->iobase + DMM32AT_AI_LO_CHAN_REG);

Signature · 1 line

1.7.10.4

Hartley Sweeten

2015-11-16 17:21 UTC #1 lore raw

Quoted 23 lines · Ranjith Thangavel

BIT macro is used for defining BIT location instead of shifting operator, usleep_range is preferred over udelay - coding style issue
Signed-off-by Ranjith Thangavel <[email protected]>
---
 drivers/staging/comedi/drivers/dmm32at.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/dmm32at.c +1 -1
index d312fda..9f8c9eb 100644
@@ -508,7 +508,7 @@ static int dmm32at_reset(struct comedi_device *dev)
 	outb(DMM32AT_CTRL_RESETA, dev->iobase + DMM32AT_CTRL_REG);
 
 	/* allow a millisecond to reset */
-	udelay(1000);
+	usleep_range(1000, 1050);
 
 	/* zero scan and fifo control */
 	outb(0x0, dev->iobase + DMM32AT_FIFO_CTRL_REG);

drivers/staging/comedi/drivers/dmm32at.c static int dmm32at_reset(struct comedi_device *dev) · line 530

Quoted 8 lines

drivers/staging/comedi/drivers/dmm32at.c +1 -1

@@ -524,7 +524,7 @@ static int dmm32at_reset(struct comedi_device *dev)
 	outb(DMM32AT_RANGE_U10, dev->iobase + DMM32AT_AI_CFG_REG);
 
 	/* should take 10 us to settle, here's a hundred */
-	udelay(100);
+	usleep_range(100, 150);
 
 	/* read back the values */
 	ailo = inb(dev->iobase + DMM32AT_AI_LO_CHAN_REG);

Nothing in this patch uses the BIT macro.

Please make sure your commit messages actually match the patch.

You also posted a different patch on Saturday with the exact same commit message.

Hartley